The branch, master has been updated via 79fd60dd3872f136528821d1c755f55fa60b3450 (commit) from 210181de7503966ea9fbfdbe2c030ab7b04b973c (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 79fd60dd3872f136528821d1c755f55fa60b3450 Author: Volker Lendecke <v...@samba.org> Date: Fri Jul 24 10:21:07 2009 -0400 Fix a few uninitialized variable warnings I know those warnings are bogus, but both Coverity and gcc don't get it. ----------------------------------------------------------------------- Summary of changes: source3/smbd/smb2_break.c | 2 +- source3/smbd/smb2_create.c | 20 ++++++++++---------- source3/smbd/smb2_find.c | 2 +- source3/smbd/smb2_getinfo.c | 2 +- source3/smbd/smb2_ioctl.c | 2 +- source3/smbd/smb2_negprot.c | 2 +- source3/smbd/smb2_notify.c | 2 +- source3/smbd/smb2_read.c | 4 ++-- source3/smbd/smb2_server.c | 2 +- source3/smbd/smb2_write.c | 2 +- 10 files changed, 20 insertions(+), 20 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/smb2_break.c b/source3/smbd/smb2_break.c index 25952fd..ba02dad 100644 --- a/source3/smbd/smb2_break.c +++ b/source3/smbd/smb2_break.c @@ -92,7 +92,7 @@ static void smbd_smb2_request_oplock_break_done(struct tevent_req *subreq) int i = req->current_idx; uint64_t in_file_id_persistent; uint64_t in_file_id_volatile; - uint8_t out_oplock_level; + uint8_t out_oplock_level = 0; DATA_BLOB outbody; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c index b455f82..511e448 100644 --- a/source3/smbd/smb2_create.c +++ b/source3/smbd/smb2_create.c @@ -141,16 +141,16 @@ static void smbd_smb2_request_create_done(struct tevent_req *subreq) uint8_t *outhdr; DATA_BLOB outbody; DATA_BLOB outdyn; - uint8_t out_oplock_level; - uint32_t out_create_action; - NTTIME out_creation_time; - NTTIME out_last_access_time; - NTTIME out_last_write_time; - NTTIME out_change_time; - uint64_t out_allocation_size; - uint64_t out_end_of_file; - uint32_t out_file_attributes; - uint64_t out_file_id_volatile; + uint8_t out_oplock_level = 0; + uint32_t out_create_action = 0; + NTTIME out_creation_time = 0; + NTTIME out_last_access_time = 0; + NTTIME out_last_write_time = 0; + NTTIME out_change_time = 0; + uint64_t out_allocation_size = 0; + uint64_t out_end_of_file = 0; + uint32_t out_file_attributes = 0; + uint64_t out_file_id_volatile = 0; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_find.c b/source3/smbd/smb2_find.c index 55ea1c5..89ba54c 100644 --- a/source3/smbd/smb2_find.c +++ b/source3/smbd/smb2_find.c @@ -137,7 +137,7 @@ static void smbd_smb2_request_find_done(struct tevent_req *subreq) DATA_BLOB outbody; DATA_BLOB outdyn; uint16_t out_output_buffer_offset; - DATA_BLOB out_output_buffer; + DATA_BLOB out_output_buffer = data_blob_null; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c index 5a6e3d7..b3cf892 100644 --- a/source3/smbd/smb2_getinfo.c +++ b/source3/smbd/smb2_getinfo.c @@ -130,7 +130,7 @@ static void smbd_smb2_request_getinfo_done(struct tevent_req *subreq) DATA_BLOB outbody; DATA_BLOB outdyn; uint16_t out_output_buffer_offset; - DATA_BLOB out_output_buffer; + DATA_BLOB out_output_buffer = data_blob_null; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_ioctl.c b/source3/smbd/smb2_ioctl.c index 85da92e..e1e26f1 100644 --- a/source3/smbd/smb2_ioctl.c +++ b/source3/smbd/smb2_ioctl.c @@ -126,7 +126,7 @@ static void smbd_smb2_request_ioctl_done(struct tevent_req *subreq) uint64_t in_file_id_volatile; uint32_t out_input_offset; uint32_t out_output_offset; - DATA_BLOB out_output_buffer; + DATA_BLOB out_output_buffer = data_blob_null; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c index b312a7f..a60ea63 100644 --- a/source3/smbd/smb2_negprot.c +++ b/source3/smbd/smb2_negprot.c @@ -76,7 +76,7 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req) size_t c; uint16_t security_mode; uint16_t dialect_count; - uint16_t dialect; + uint16_t dialect = 0; uint32_t capabilities; /* TODO: drop the connection with INVALI_PARAMETER */ diff --git a/source3/smbd/smb2_notify.c b/source3/smbd/smb2_notify.c index f6d83ae..4b9cbc4 100644 --- a/source3/smbd/smb2_notify.c +++ b/source3/smbd/smb2_notify.c @@ -108,7 +108,7 @@ static void smbd_smb2_request_notify_done(struct tevent_req *subreq) DATA_BLOB outbody; DATA_BLOB outdyn; uint16_t out_output_buffer_offset; - DATA_BLOB out_output_buffer; + DATA_BLOB out_output_buffer = data_blob_null; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_read.c b/source3/smbd/smb2_read.c index 4299351..c052125 100644 --- a/source3/smbd/smb2_read.c +++ b/source3/smbd/smb2_read.c @@ -117,8 +117,8 @@ static void smbd_smb2_request_read_done(struct tevent_req *subreq) DATA_BLOB outbody; DATA_BLOB outdyn; uint8_t out_data_offset; - DATA_BLOB out_data_buffer; - uint32_t out_data_remaining; + DATA_BLOB out_data_buffer = data_blob_null; + uint32_t out_data_remaining = 0; NTSTATUS status; NTSTATUS error; /* transport error */ diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c index 204e57d..2ae2ed2 100644 --- a/source3/smbd/smb2_server.c +++ b/source3/smbd/smb2_server.c @@ -1523,7 +1523,7 @@ static void smbd_smb2_request_incoming(struct tevent_req *subreq) struct smbd_server_connection *conn = tevent_req_callback_data(subreq, struct smbd_server_connection); NTSTATUS status; - struct smbd_smb2_request *req; + struct smbd_smb2_request *req = NULL; status = smbd_smb2_request_read_recv(subreq, conn, &req); TALLOC_FREE(subreq); diff --git a/source3/smbd/smb2_write.c b/source3/smbd/smb2_write.c index f1606be..9f26f33 100644 --- a/source3/smbd/smb2_write.c +++ b/source3/smbd/smb2_write.c @@ -124,7 +124,7 @@ static void smbd_smb2_request_write_done(struct tevent_req *subreq) uint8_t *outhdr; DATA_BLOB outbody; DATA_BLOB outdyn; - uint32_t out_count; + uint32_t out_count = 0; NTSTATUS status; NTSTATUS error; /* transport error */ -- Samba Shared Repository