On Fri, 2009-10-09 at 17:35 +0200, Stefan (metze) Metzmacher wrote: > Hi Matthias, > > diff --git a/nsswitch/libwbclient/wbclient.h > > b/nsswitch/libwbclient/wbclient.h > > index 4dc6d23..ced82d8 100644 > > --- a/nsswitch/libwbclient/wbclient.h > > +++ b/nsswitch/libwbclient/wbclient.h > > @@ -427,10 +427,15 @@ struct wbcUserPasswordPolicyInfo { > > **/ > > > > enum wbcPasswordChangeRejectReason { > > - WBC_PWD_CHANGE_REJECT_OTHER=0, > > - WBC_PWD_CHANGE_REJECT_TOO_SHORT=1, > > - WBC_PWD_CHANGE_REJECT_IN_HISTORY=2, > > - WBC_PWD_CHANGE_REJECT_COMPLEXITY=5 > > + WBC_PWD_CHANGE_NO_ERROR=0, > > + WBC_PWD_CHANGE_PASSWORD_TOO_SHORT=1, > > + WBC_PWD_CHANGE_PWD_IN_HISTORY=2, > > + WBC_PWD_CHANGE_USERNAME_IN_PASSWORD=3, > > + WBC_PWD_CHANGE_FULLNAME_IN_PASSWORD=4, > > + WBC_PWD_CHANGE_NOT_COMPLEX=5, > > + WBC_PWD_CHANGE_MACHINE_NOT_DEFAULT=6, > > + WBC_PWD_CHANGE_FAILED_BY_FILTER=7, > > + WBC_PWD_CHANGE_PASSWORD_TOO_LONG=8 > > }; > > wbclient.h is a public interface, where we can't change existing code! > > At least we need to add the old enum values as defines to the new ones.
Martthias, *please* be extra-careful when you touch stuff outside source4 or in source4/lib/ldb We have APIs and possibly ABIs to keep stable, in case of doubt rather than just pushing the code send a patch to samba-technical for review. Simo. -- Simo Sorce Samba Team GPL Compliance Officer <s...@samba.org> Principal Software Engineer at Red Hat, Inc. <s...@redhat.com>