The branch, v3-5-test has been updated
       via  404f744... Fix posix_unlink test. Was doing grep without quotes 
around the target string. Jeremy.
      from  62620e9... Add comment explaining about symlink following & posix. 
Jeremy.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit 404f744772ab68ac5a4722818d447609c33a39b7
Author: Jeremy Allison <j...@samba.org>
Date:   Sat Oct 17 20:47:47 2009 -0700

    Fix posix_unlink test. Was doing grep without quotes around the
    target string.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/script/tests/test_smbclient_s3.sh |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/script/tests/test_smbclient_s3.sh 
b/source3/script/tests/test_smbclient_s3.sh
index f10bfea..ff50220 100755
--- a/source3/script/tests/test_smbclient_s3.sh
+++ b/source3/script/tests/test_smbclient_s3.sh
@@ -108,19 +108,20 @@ EOF
 
     if [ $ret != 0 ] ; then
        echo "$out"
-       echo "failed create then delete bad symlink"
+       echo "failed create then delete bad symlink with error $ret"
        false
        return
     fi
 
-    echo "$out" | grep $prompt >/dev/null 2>&1
+    echo "$out" | grep "$prompt" >/dev/null 2>&1
 
-    if [ $? = 0 ] ; then
+    ret=$?
+    if [ $ret = 0 ] ; then
        # got the correct prompt .. succeed
        true
     else
        echo "$out"
-       echo failed create then delete bad symlink
+       echo "failed create then delete bad symlink - grep failed with $ret"
        false
     fi
 }


-- 
Samba Shared Repository

Reply via email to