The branch, master has been updated
via d3a4294... s3: Fix initgroups return check
from 05b6e3f... s4:dcesrv_lsa.c - remove a superfluous empty line
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit d3a42946cc7d98070e90122341d234119ed94089
Author: Peter Watkins <trees...@gmail.com>
Date: Sun Feb 14 12:43:13 2010 +0100
s3: Fix initgroups return check
A return code of 1 from initgroups() is OK since apparently it means
the gid has already been set. The man page doesn't mention this.
-----------------------------------------------------------------------
Summary of changes:
source3/lib/system_smbd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/system_smbd.c b/source3/lib/system_smbd.c
index b22d15f..b4447c5 100644
--- a/source3/lib/system_smbd.c
+++ b/source3/lib/system_smbd.c
@@ -68,7 +68,7 @@ static int getgrouplist_internals(const char *user, gid_t
gid, gid_t *groups,
return -1;
}
- if (initgroups(user, gid) != 0) {
+ if (initgroups(user, gid) == -1) {
DEBUG(0, ("getgrouplist_internals: initgroups() failed!\n"));
SAFE_FREE(gids_saved);
return -1;
--
Samba Shared Repository
