The branch, master has been updated
via e55a975... s4-smbtorture: remove NotifyChangeKeyValue s3 skip in
RPC-WINREG:
via e46d3d9... s3-winreg: change notify call has no meaning when called
remotely.
from b4d0913... s3-registry: make sure root has full registry access (in
particular for make test).
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit e55a9758603d135ac3c83cbd96c24e557d9e4040
Author: Günther Deschner <g...@samba.org>
Date: Tue Mar 16 15:30:13 2010 +0100
s4-smbtorture: remove NotifyChangeKeyValue s3 skip in RPC-WINREG:
Guenther
commit e46d3d9475c59af8ba6810aeb1403c1aa9e37d9d
Author: Günther Deschner <g...@samba.org>
Date: Tue Mar 16 15:29:14 2010 +0100
s3-winreg: change notify call has no meaning when called remotely.
Just return not supported to make smbtorture happy.
Guenther
-----------------------------------------------------------------------
Summary of changes:
source3/rpc_server/srv_winreg_nt.c | 4 ----
source4/torture/rpc/winreg.c | 4 ----
2 files changed, 0 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_winreg_nt.c
b/source3/rpc_server/srv_winreg_nt.c
index 2a2ff68..38be56e 100644
--- a/source3/rpc_server/srv_winreg_nt.c
+++ b/source3/rpc_server/srv_winreg_nt.c
@@ -956,10 +956,6 @@ WERROR _winreg_LoadKey(pipes_struct *p, struct
winreg_LoadKey *r)
WERROR _winreg_NotifyChangeKeyValue(pipes_struct *p, struct
winreg_NotifyChangeKeyValue *r)
{
- /* fill in your code here if you think this call should
- do anything */
-
- p->rng_fault_state = True;
return WERR_NOT_SUPPORTED;
}
diff --git a/source4/torture/rpc/winreg.c b/source4/torture/rpc/winreg.c
index 651721c..e8d0943 100644
--- a/source4/torture/rpc/winreg.c
+++ b/source4/torture/rpc/winreg.c
@@ -90,10 +90,6 @@ static bool test_NotifyChangeKeyValue(struct dcerpc_pipe *p,
init_winreg_String(&r.in.string1, NULL);
init_winreg_String(&r.in.string2, NULL);
- if (torture_setting_bool(tctx, "samba3", false)) {
- torture_skip(tctx, "skipping NotifyChangeKeyValue test against
Samba 3");
- }
-
torture_assert_ntstatus_ok(tctx,
dcerpc_winreg_NotifyChangeKeyValue(p, tctx,
&r),
"NotifyChangeKeyValue failed");
--
Samba Shared Repository
