On Sun, 2010-04-11 at 21:34 +0200, Matthias Dieter Wallnöfer wrote: > Okay, okay - will remove them again. > > But I have to state that each torture output call seems to have a > different policy regarding newlines at the end or not: > > e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed. > > Is there an easy rule when yes, when no? It would be nice to see only > one method to don't have to worry about this. torture_fail, torture_result, etc. all receive a string with a description why the particular result occurred. Generally this description is only one sentence or less.
torture_comment() can be used for whatever comments you like and generally just outputs directly to stdout. It can be used for incremental output (including backspace characters) or multiple lines. Cheers, Jelmer > Jelmer Vernooij wrote: > > Hi Matthias, > > > > On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote: > > > >> The branch, master has been updated > >> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we > >> have them in the other failure messages > >> from 52ab3ca... s4:torture - "dbspeed" test > >> > >> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master > >> > >> > >> - Log ----------------------------------------------------------------- > >> commit c7dfe736a88549f5793521609aca68ca85545c1b > >> Author: Matthias Dieter Wallnfer<mwallnoe...@yahoo.de> > >> Date: Sun Apr 11 11:33:45 2010 +0200 > >> > >> s4:torture - "dbspeed" test - add newlines as we have them in the > >> other failure messages > >> > > torture_result() calls should generally *not* have any newlines, > > torture_result() adds one itself. > > > > Cheers, > > > > Jelmer > > >
signature.asc
Description: This is a digitally signed message part