The branch, v3-6-test has been updated
via 685035c... s3-dcerpc: fix build warning seen with -O3.
from a2f082e... s3-waf: remove pointless RPC_PARSE_SRC2.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -----------------------------------------------------------------
commit 685035ca86c824558db255c8df53a1e9c328a828
Author: Günther Deschner <g...@samba.org>
Date: Fri Aug 13 15:12:29 2010 +0200
s3-dcerpc: fix build warning seen with -O3.
"warning: assuming signed overflow does not occur when assuming that (X +
c) < X is always false"
Guenther
(cherry picked from commit bb8936c08709ea5e59eeba2f67359c7511fb89f0)
-----------------------------------------------------------------------
Summary of changes:
source3/librpc/rpc/dcerpc_helpers.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/librpc/rpc/dcerpc_helpers.c
b/source3/librpc/rpc/dcerpc_helpers.c
index 84f7ce4..f8ca8e6 100644
--- a/source3/librpc/rpc/dcerpc_helpers.c
+++ b/source3/librpc/rpc/dcerpc_helpers.c
@@ -898,9 +898,9 @@ NTSTATUS dcerpc_check_auth(struct pipe_auth_data *auth,
if (pkt->auth_length > pkt->frag_length) {
return NT_STATUS_INFO_LENGTH_MISMATCH;
}
- if ((pkt->auth_length
- + DCERPC_AUTH_TRAILER_LENGTH < pkt->auth_length) ||
- (pkt->auth_length
+ if (((unsigned int)pkt->auth_length
+ + DCERPC_AUTH_TRAILER_LENGTH < (unsigned int)pkt->auth_length) ||
+ ((unsigned int)pkt->auth_length
+ DCERPC_AUTH_TRAILER_LENGTH < DCERPC_AUTH_TRAILER_LENGTH)) {
/* Integer wrap attempt. */
return NT_STATUS_INFO_LENGTH_MISMATCH;
--
Samba Shared Repository
