The branch, v3-6-test has been updated via 2f08578 s3: Fix bug 7470 from 464666b talloc: Add a warning about talloc_autofree_context() and dlclose()
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log ----------------------------------------------------------------- commit 2f0857834e889a33b85e1c0aa46674fd0cd1a27c Author: Volker Lendecke <v...@samba.org> Date: Sat Sep 25 10:56:58 2010 -0700 s3: Fix bug 7470 S_IREAD and S_IWRITE are not standard. Thanks to Joachim Schmitz <schm...@hp.com> for reporting! ----------------------------------------------------------------------- Summary of changes: source3/registry/reg_api_regf.c | 2 +- source3/utils/net_rpc_registry.c | 3 ++- source3/utils/profiles.c | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/registry/reg_api_regf.c b/source3/registry/reg_api_regf.c index 8f249b5..20cd4fc 100644 --- a/source3/registry/reg_api_regf.c +++ b/source3/registry/reg_api_regf.c @@ -277,7 +277,7 @@ static WERROR backup_registry_key(struct registry_key_handle *krecord, /* open the registry file....fail if the file already exists */ regfile = regfio_open(fname, (O_RDWR|O_CREAT|O_EXCL), - (S_IREAD|S_IWRITE)); + (S_IRUSR|S_IWUSR)); if (regfile == NULL) { DEBUG(0,("backup_registry_key: failed to open \"%s\" (%s)\n", fname, strerror(errno) )); diff --git a/source3/utils/net_rpc_registry.c b/source3/utils/net_rpc_registry.c index cfc2a7e..787ecbf 100644 --- a/source3/utils/net_rpc_registry.c +++ b/source3/utils/net_rpc_registry.c @@ -1149,7 +1149,8 @@ static int rpc_registry_copy(struct net_context *c, int argc, const char **argv d_printf(_("ok\n")); d_printf(_("Opening %s...."), argv[1]); - if ( !(outfile = regfio_open( argv[1], (O_RDWR|O_CREAT|O_TRUNC), (S_IREAD|S_IWRITE) )) ) { + if ( !(outfile = regfio_open( argv[1], (O_RDWR|O_CREAT|O_TRUNC), + (S_IRUSR|S_IWUSR) )) ) { d_fprintf(stderr, _("Failed to open %s for writing\n"),argv[1]); goto out; } diff --git a/source3/utils/profiles.c b/source3/utils/profiles.c index f6f500a..4c46bba 100644 --- a/source3/utils/profiles.c +++ b/source3/utils/profiles.c @@ -278,7 +278,8 @@ int main( int argc, char *argv[] ) exit (1); } - if ( !(outfile = regfio_open( new_filename, (O_RDWR|O_CREAT|O_TRUNC), (S_IREAD|S_IWRITE) )) ) { + if ( !(outfile = regfio_open( new_filename, (O_RDWR|O_CREAT|O_TRUNC), + (S_IRUSR|S_IWUSR) )) ) { fprintf( stderr, "Failed to open new file %s!\n", new_filename ); fprintf( stderr, "Error was (%s)\n", strerror(errno) ); exit (1); -- Samba Shared Repository