The branch, v3-5-test has been updated via ec3bca6 s3: Fix bug 7688, rpcclient command line completion crashing from dcb31fa VERSION: Bump version number up to 3.5.6.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log ----------------------------------------------------------------- commit ec3bca61a10d8dcaa6a94046120dd414e39289b1 Author: Volker Lendecke <v...@samba.org> Date: Sat Sep 18 07:37:04 2010 -0700 s3: Fix bug 7688, rpcclient command line completion crashing We've grown more than 100 rpcclient commands by now, so this would overwrite the array of 100 completions. There's nicer ways to fix this problem, but 1000 rpcclient commands should be at least a bit away. ----------------------------------------------------------------------- Summary of changes: source3/rpcclient/rpcclient.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c index e24538b..f05facb 100644 --- a/source3/rpcclient/rpcclient.c +++ b/source3/rpcclient/rpcclient.c @@ -49,7 +49,7 @@ handle completion of commands for readline ****************************************************************************/ static char **completion_fn(const char *text, int start, int end) { -#define MAX_COMPLETIONS 100 +#define MAX_COMPLETIONS 1000 char **matches; int i, count=0; struct cmd_list *commands = cmd_list; -- Samba Shared Repository