On Sat, 2010-11-06 at 11:17 +0300, Matthieu Patou wrote: > Hi Jelmer, > > On 06/11/2010 05:26, Jelmer Vernooij wrote: > > The branch, master has been updated > > via 6505499 Inline test data. > > via 9bce367 PEP8 > > via 9f62c2b Add more tests. > > via a72e3d2 Default rev to None, consistent with other code. > > from 2b9b526 Fix a bug > > > > http://gitweb.samba.org/?p=build-farm.git;a=shortlog;h=master > > > > > > - Log ----------------------------------------------------------------- > > commit 65054993bf7cf96f17517bcc7edcc3db32de0667 > > Author: Jelmer Vernooij<jel...@samba.org> > > Date: Fri Nov 5 20:29:36 2010 +0100 > > > > Inline test data. > > > > commit 9bce36774b255246de091ad7a5810a72d9689d0c > > Author: Jelmer Vernooij<jel...@samba.org> > > Date: Fri Nov 5 20:16:41 2010 +0100 > > > > PEP8 > > > > commit 9f62c2bee32bac90800a8925223c2ebb9491ad9d > > Author: Jelmer Vernooij<jel...@samba.org> > > Date: Fri Nov 5 20:10:17 2010 +0100 > > > > Add more tests. > > > > commit a72e3d2abecf16202750a8a4b448a6fe5a1c0786 > > Author: Jelmer Vernooij<jel...@samba.org> > > Date: Fri Nov 5 20:04:43 2010 +0100 > > > > Default rev to None, consistent with other code. > > > > ----------------------------------------------------------------------- > > > > Summary of changes: > > buildfarm/data.py | 37 ++--------------------- > > buildfarm/tests/test_data.py | 63 > > ++++++++++++++++++++++++++++++++++++++-- > > buildfarm/tests/test_util.py | 24 ++++++++++++--- > > buildfarm/tests/testlist | 5 --- > > buildfarm/tests/testtree.conf | 9 ------ > > buildfarm/tests/testtree2.conf | 10 ------ > > 6 files changed, 82 insertions(+), 66 deletions(-) > > delete mode 100644 buildfarm/tests/testlist > > delete mode 100644 buildfarm/tests/testtree.conf > > delete mode 100644 buildfarm/tests/testtree2.conf > > > > > > Changeset truncated at 500 lines: > > > > diff --git a/buildfarm/data.py b/buildfarm/data.py > > index e2502d2..8a2ce6c 100644 > > --- a/buildfarm/data.py > > +++ b/buildfarm/data.py > > @@ -86,8 +86,7 @@ def build_status_from_logs(log, err): > > else: > > sstatus = None > > > > - return {"config": cstatus, "build": bstatus, "install": istatus,\ > > - "test": tstatus, "checker": sstatus, "other": other_failures} > > + return ((cstatus, bstatus, istatus, tstatus, sstatus), other_failures) > > > > > Frankly speaking I thinking having a dictionnary/hash as we can extend > without problem the structure to add more status ... The issue with a dictionary is that it's not ordered, with a tuple there is an order in the statusses (configure, build, test, install, checker). I'd be happy to change it to a namedtuple if you'd like to be able to explicitly name the statusses.
I'd be happy to see the base type changed to a custom (BuildStatus ?) class. Cheers, Jelmer
signature.asc
Description: This is a digitally signed message part