The branch, master has been updated via 139e2cb s3-printing: fix printer_list_traverse() from bfc4fe4 s3: Remove unused "retry" from cli_start_connection
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 139e2cbb13ca230b65ad4b1f5ff91a795d8cca02 Author: David Disseldorp <dd...@suse.de> Date: Mon Dec 20 16:08:02 2010 +0100 s3-printing: fix printer_list_traverse() The tdb traverse function returns the number of elements traversed, or less than zero on error, printer_list_traverse() is incorrectly checking for non-zero return. Autobuild-User: Andreas Schneider <a...@samba.org> Autobuild-Date: Mon Dec 20 18:44:41 CET 2010 on sn-devel-104 ----------------------------------------------------------------------- Summary of changes: source3/printing/printer_list.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/printing/printer_list.c b/source3/printing/printer_list.c index edc398b..f3f00f0 100644 --- a/source3/printing/printer_list.c +++ b/source3/printing/printer_list.c @@ -293,7 +293,7 @@ static NTSTATUS printer_list_traverse(printer_list_trv_fn_t *fn, } ret = db->traverse(db, fn, private_data); - if (ret != 0) { + if (ret < 0) { return NT_STATUS_UNSUCCESSFUL; } -- Samba Shared Repository