The branch, v3-6-test has been updated
via 29c81d9 s3: Fix Coverity ID 2100, BAD_SIZEOF
via 4791050 s3: Fix Coverity ID 2317: Uninitialized read
via 7567624 s3: Fix Coverity ID 2318: Uninitialized read
via 5592477 s3: Fix Coverity ID 2319: Uninitialized read
from f88484a s3-printing: fix memory leak in print_cups.c
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -----------------------------------------------------------------
commit 29c81d96dd722170f0a29cc0d8d3007102952ae7
Author: Volker Lendecke <v...@samba.org>
Date: Wed Mar 16 17:55:37 2011 +0100
s3: Fix Coverity ID 2100, BAD_SIZEOF
Autobuild-User: Volker Lendecke <vlen...@samba.org>
Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
commit 4791050404e17155fe81e885eb94d87a1ef59597
Author: Volker Lendecke <v...@samba.org>
Date: Wed Mar 16 17:19:13 2011 +0100
s3: Fix Coverity ID 2317: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
commit 7567624884be05b036b5a82934eec301471753c8
Author: Volker Lendecke <v...@samba.org>
Date: Wed Mar 16 17:19:13 2011 +0100
s3: Fix Coverity ID 2318: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
commit 55924773b9f090ae85cbd5131e95be82fe6919e2
Author: Volker Lendecke <v...@samba.org>
Date: Wed Mar 16 17:17:47 2011 +0100
s3: Fix Coverity ID 2319: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
-----------------------------------------------------------------------
Summary of changes:
source3/rpc_client/cli_winreg.c | 2 +-
source3/rpc_server/spoolss/srv_spoolss_util.c | 4 ++--
source3/winbindd/winbindd_misc.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_client/cli_winreg.c b/source3/rpc_client/cli_winreg.c
index 5b8635f..67f8573 100644
--- a/source3/rpc_client/cli_winreg.c
+++ b/source3/rpc_client/cli_winreg.c
@@ -499,7 +499,7 @@ NTSTATUS dcerpc_winreg_set_multi_sz(TALLOC_CTX *mem_ctx,
const char **data,
WERROR *pwerr)
{
- struct winreg_String wvalue;
+ struct winreg_String wvalue = { 0, };
DATA_BLOB blob;
WERROR result = WERR_OK;
NTSTATUS status;
diff --git a/source3/rpc_server/spoolss/srv_spoolss_util.c
b/source3/rpc_server/spoolss/srv_spoolss_util.c
index 383552c..dea023f 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_util.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_util.c
@@ -776,7 +776,7 @@ static WERROR winreg_printer_write_date(TALLOC_CTX *mem_ctx,
const char *value,
NTTIME data)
{
- struct winreg_String wvalue;
+ struct winreg_String wvalue = { 0, };
DATA_BLOB blob;
WERROR result = WERR_OK;
NTSTATUS status;
@@ -851,7 +851,7 @@ static WERROR winreg_printer_write_ver(TALLOC_CTX *mem_ctx,
const char *value,
uint64_t data)
{
- struct winreg_String wvalue;
+ struct winreg_String wvalue = { 0, };
DATA_BLOB blob;
WERROR result = WERR_OK;
NTSTATUS status;
diff --git a/source3/winbindd/winbindd_misc.c b/source3/winbindd/winbindd_misc.c
index 42ecea2..7d25167 100644
--- a/source3/winbindd/winbindd_misc.c
+++ b/source3/winbindd/winbindd_misc.c
@@ -319,7 +319,7 @@ void winbindd_dc_info(struct winbindd_cli_state *cli)
struct winbindd_domain *domain;
char *dc_name, *dc_ip;
- cli->request->domain_name[sizeof(cli->request->domain_name-1)] = '\0';
+ cli->request->domain_name[sizeof(cli->request->domain_name)-1] = '\0';
DEBUG(3, ("[%5lu]: domain_info [%s]\n", (unsigned long)cli->pid,
cli->request->domain_name));
--
Samba Shared Repository
