The branch, master has been updated via fbe19ba s3: Fix Coverity ID 2143: DEADCODE via 05dac2b s3: Fix Coverity ID 2143: DEADCODE via 6e9b69f s3: Fix Coverity ID 2173: FORWARD_NULL from dc36d75 Revert "Change strict allocate to default to true.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit fbe19ba39843d0c70758fc8d775b085a67224a94 Author: Volker Lendecke <v...@samba.org> Date: Mon Mar 28 11:12:32 2011 +0200 s3: Fix Coverity ID 2143: DEADCODE Autobuild-User: Volker Lendecke <vlen...@samba.org> Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104 commit 05dac2b7e68c53babf316ac42b2811f03db364a2 Author: Volker Lendecke <v...@samba.org> Date: Mon Mar 28 11:12:32 2011 +0200 s3: Fix Coverity ID 2143: DEADCODE commit 6e9b69fb0783188444d71fc3b3292cdc2efd6087 Author: Volker Lendecke <v...@samba.org> Date: Mon Mar 28 10:52:51 2011 +0200 s3: Fix Coverity ID 2173: FORWARD_NULL ----------------------------------------------------------------------- Summary of changes: source3/winbindd/winbindd_cm.c | 2 +- source3/winbindd/winbindd_samr.c | 8 -------- 2 files changed, 1 insertions(+), 9 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c index cfd60aa..302df1e 100644 --- a/source3/winbindd/winbindd_cm.c +++ b/source3/winbindd/winbindd_cm.c @@ -1667,7 +1667,7 @@ void invalidate_cm_connection(struct winbindd_cm_conn *conn) if (conn->lsa_pipe_tcp != NULL) { if (is_valid_policy_hnd(&conn->lsa_policy)) { - dcerpc_lsa_Close(conn->lsa_pipe->binding_handle, + dcerpc_lsa_Close(conn->lsa_pipe_tcp->binding_handle, talloc_tos(), &conn->lsa_policy, &result); diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c index 0bcfc30..d775cd7 100644 --- a/source3/winbindd/winbindd_samr.c +++ b/source3/winbindd/winbindd_samr.c @@ -46,10 +46,6 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx, struct auth_serversupplied_info *session_info = NULL; NTSTATUS status; - if (cli != NULL) { - goto done; - } - if (session_info == NULL) { status = make_session_info_system(mem_ctx, &session_info); if (!NT_STATUS_IS_OK(status)) { @@ -128,10 +124,6 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx, struct auth_serversupplied_info *session_info = NULL; NTSTATUS status; - if (cli != NULL) { - goto done; - } - if (session_info == NULL) { status = make_session_info_system(mem_ctx, &session_info); if (!NT_STATUS_IS_OK(status)) { -- Samba Shared Repository