Hi Andrew, while I like you changes to use lp_netbios_name(), lp_netbios_scope() and lp_workgroup() directly, I noticed that this changes changed the behavior if someone specifies these parameters on the command line.
lp_set_cmdline() doesn't cause the lp_set_cmdline("netbios name", "foo"); doesn't trigger that lp_netbios_name() will return "FOO", which would match the old behavior. I guess we need something similar to handle_realm() and szRealmUpper. metze
signature.asc
Description: OpenPGP digital signature