The branch, master has been updated via d0159f6 Free protect_ids in secret_store_domain_guid() as the caller of fetch_secrets() must free the result in order to not leak memory. from 54ae7ca selftest/knownfail: samba3.smb2.durable-v2-open.reopen{1,2} fails currently
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit d0159f6673e0fdf50f096548ea1a134c0e864ceb Author: Michele Baldessari <mich...@acksyn.org> Date: Thu Sep 6 17:32:11 2012 -0700 Free protect_ids in secret_store_domain_guid() as the caller of fetch_secrets() must free the result in order to not leak memory. Signed-off-by: Jeremy Allison <j...@samba.org> Autobuild-User(master): Jeremy Allison <j...@samba.org> Autobuild-Date(master): Fri Sep 7 04:11:43 CEST 2012 on sn-devel-104 ----------------------------------------------------------------------- Summary of changes: source3/passdb/machine_account_secrets.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/passdb/machine_account_secrets.c b/source3/passdb/machine_account_secrets.c index 70d7106..6320f4e 100644 --- a/source3/passdb/machine_account_secrets.c +++ b/source3/passdb/machine_account_secrets.c @@ -149,9 +149,11 @@ bool secrets_store_domain_guid(const char *domain, struct GUID *guid) if (strncmp(protect_ids, "TRUE", 4)) { DEBUG(0, ("Refusing to store a Domain SID, " "it has been marked as protected!\n")); + SAFE_FREE(protect_ids); return false; } } + SAFE_FREE(protect_ids); #endif slprintf(key, sizeof(key)-1, "%s/%s", SECRETS_DOMAIN_GUID, domain); -- Samba Shared Repository