The branch, master has been updated via 8697acd dsdb-cracknames: Always use talloc_zero() from d5d0a45 build(waf): Fix the --with-cluster build
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 8697acd4b08354fb4185b05da07f4399bda917bc Author: Andrew Bartlett <abart...@samba.org> Date: Wed Oct 24 11:56:02 2012 +1100 dsdb-cracknames: Always use talloc_zero() Otherwise, we will return un-initialised values to the caller, which will attempt to push them onto the wire. Found by Greg Dickie <g...@justaguy.ca>. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abart...@samba.org> Autobuild-Date(master): Wed Oct 24 05:12:04 CEST 2012 on sn-devel-104 ----------------------------------------------------------------------- Summary of changes: source4/dsdb/samdb/cracknames.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c index c366019..6ad8026 100644 --- a/source4/dsdb/samdb/cracknames.c +++ b/source4/dsdb/samdb/cracknames.c @@ -1472,7 +1472,7 @@ WERROR dcesrv_drsuapi_CrackNamesByNameFormat(struct ldb_context *sam_ctx, TALLOC uint32_t i, count; WERROR status; - *ctr1 = talloc(mem_ctx, struct drsuapi_DsNameCtr1); + *ctr1 = talloc_zero(mem_ctx, struct drsuapi_DsNameCtr1); W_ERROR_HAVE_NO_MEMORY(*ctr1); count = req1->count; -- Samba Shared Repository