The branch, v4-0-test has been updated via fffa771 Fix bug 10162 - POSIX ACL mapping failing when setting DENY ACE's from Windows. via c62c56c docs: point out side-effects of global "valid users" setting. from 43e5b94 libcli: continue to read from the socket even if the size is 0
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test - Log ----------------------------------------------------------------- commit fffa7712ad0712f963c8056ebfb9f2b98fcf1bdb Author: Daniel Liberman <danie...@gmail.com> Date: Thu Sep 19 20:28:33 2013 -0300 Fix bug 10162 - POSIX ACL mapping failing when setting DENY ACE's from Windows. Fix for ACL problem - not accepting DENY. Code was checking for pointer and not for content. Reviewed-by: Jeremy Allison <j...@samba.org> Reviewed-by: Michael Adam <ob...@samba.org> Autobuild-User(master): Michael Adam <ob...@samba.org> Autobuild-Date(master): Sat Sep 21 05:24:07 CEST 2013 on sn-devel-104 (cherry picked from commit e24fcf0f3e1b5b19d97a13786b09f069393b06d8) Autobuild-User(v4-0-test): Karolin Seeger <ksee...@samba.org> Autobuild-Date(v4-0-test): Mon Sep 23 11:23:14 CEST 2013 on sn-devel-104 commit c62c56cd8dc73340ced15071427469f9e7f5e4ad Author: Günther Deschner <g...@samba.org> Date: Tue Sep 17 12:47:58 2013 +0200 docs: point out side-effects of global "valid users" setting. Guenther Signed-off-by: Günther Deschner <g...@samba.org> Fix bug #10147 - Better document potential implications of a globally used "valid users". ----------------------------------------------------------------------- Summary of changes: docs-xml/smbdotconf/security/validusers.xml | 10 ++++++++++ source3/smbd/posix_acls.c | 2 +- 2 files changed, 11 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/smbdotconf/security/validusers.xml b/docs-xml/smbdotconf/security/validusers.xml index 313739d..ec3e11e 100644 --- a/docs-xml/smbdotconf/security/validusers.xml +++ b/docs-xml/smbdotconf/security/validusers.xml @@ -19,6 +19,16 @@ The current servicename is substituted for <parameter moreinfo="none">%S</parameter>. This is useful in the [homes] section. </para> + + <para><emphasis>Note: </emphasis>When used in the [global] section this + parameter may have unwanted side effects. For example: If samba is configured as a MASTER BROWSER (see + <parameter moreinfo="none">local master</parameter>, + <parameter moreinfo="none">os level</parameter>, + <parameter moreinfo="none">domain master</parameter>, + <parameter moreinfo="none">preferred master</parameter>) this option + will prevent workstations from being able to browse the network. + </para> + </description> <related>invalid users</related> diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c index 3ff34fc..713ad50 100644 --- a/source3/smbd/posix_acls.c +++ b/source3/smbd/posix_acls.c @@ -1807,7 +1807,7 @@ static bool add_current_ace_to_acl(files_struct *fsp, struct security_ace *psa, if (current_ace->attr == ALLOW_ACE) *got_file_allow = True; - if ((current_ace->attr == DENY_ACE) && got_file_allow) { + if ((current_ace->attr == DENY_ACE) && *got_file_allow) { DEBUG(0,("add_current_ace_to_acl: malformed " "ACL in file ACL ! Deny entry after " "Allow entry. Failing to set on file " -- Samba Shared Repository