The branch, v4-3-test has been updated via 2aa391a Changing log level of two entries to DBG_NOTICE via e70e7c1 lib: util: Make non-critical message a warning. from 88398fb s3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearer
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-3-test - Log ----------------------------------------------------------------- commit 2aa391a1a4a9b89b0beab61c947041061edc7786 Author: Marc Muehlfeld <mmuehlf...@samba.org> Date: Tue Nov 3 10:09:13 2015 +0100 Changing log level of two entries to DBG_NOTICE On domain members using RFC2307, machine acccounts without an uidNumber attribute are not retrieved via idmap_ad. This leads to many of the following two error messages: Username DOMAIN\machineaccountname$ is invalid on this system and Failed to map kerberos principal to system user (NT_STATUS_LOGON_FAILURE) Machine accounts don't have an uidNumber attribute, if not set manually. To avoid flooding the logs, setting message from debug level 1 to DBG_NOTICE. Bugreport: https://bugzilla.samba.org/show_bug.cgi?id=9912 Signed-off-by: Marc Muehlfeld <mmuehlf...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> Autobuild-User(master): Jeremy Allison <j...@samba.org> Autobuild-Date(master): Wed Nov 4 00:46:15 CET 2015 on sn-devel-104 (cherry picked from commit 18879dab9affffd79a647a4de697512c03e04425) Autobuild-User(v4-3-test): Karolin Seeger <ksee...@samba.org> Autobuild-Date(v4-3-test): Fri Nov 6 15:36:28 CET 2015 on sn-devel-104 commit e70e7c1a135fc3c56091606223079affd545532e Author: Jeremy Allison <j...@samba.org> Date: Tue Oct 27 17:08:50 2015 -0700 lib: util: Make non-critical message a warning. Non-root utilities (e.g. bin/net) call this via messaging_init(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=11566 Signed-off-by: Jeremy Allison <j...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> (cherry picked from commit 859e3415b38538ff6c023e4a56570d94a4fe4432) ----------------------------------------------------------------------- Summary of changes: lib/util/util.c | 4 ++-- source3/auth/auth_generic.c | 4 ++-- source3/auth/user_krb5.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/util/util.c b/lib/util/util.c index 393d83d..d8a84da 100644 --- a/lib/util/util.c +++ b/lib/util/util.c @@ -275,8 +275,8 @@ _PUBLIC_ bool directory_create_or_exist_strict(const char *dname, return false; } if (st.st_uid != uid && !uid_wrapper_enabled()) { - DEBUG(0, ("invalid ownership on directory " - "%s\n", dname)); + DBG_NOTICE("invalid ownership on directory " + "%s\n", dname); return false; } if ((st.st_mode & 0777) != dir_perms) { diff --git a/source3/auth/auth_generic.c b/source3/auth/auth_generic.c index 584b52f..74eb2fa 100644 --- a/source3/auth/auth_generic.c +++ b/source3/auth/auth_generic.c @@ -95,8 +95,8 @@ static NTSTATUS auth3_generate_session_info_pac(struct auth4_context *auth_ctx, &ntuser, &ntdomain, &username, &pw); if (!NT_STATUS_IS_OK(status)) { - DEBUG(1, ("Failed to map kerberos principal to system user " - "(%s)\n", nt_errstr(status))); + DBG_NOTICE("Failed to map kerberos principal to system user " + "(%s)\n", nt_errstr(status)); status = NT_STATUS_ACCESS_DENIED; goto done; } diff --git a/source3/auth/user_krb5.c b/source3/auth/user_krb5.c index 7442ea4..2b009ba 100644 --- a/source3/auth/user_krb5.c +++ b/source3/auth/user_krb5.c @@ -160,8 +160,8 @@ NTSTATUS get_user_from_kerberos_info(TALLOC_CTX *mem_ctx, /* extra sanity check that the guest account is valid */ if (!pw) { - DEBUG(1, ("Username %s is invalid on this system\n", - fuser)); + DBG_NOTICE("Username %s is invalid on this system\n", + fuser); return NT_STATUS_LOGON_FAILURE; } } -- Samba Shared Repository