The branch, master has been updated via 39bbd40 fix Invalid read of size 8 via 417a58a s4:torture:vfs: fix Invalid read of size 8 valgrind valgrind error (and segv) via 8d998db s4:torture:libnet: fix 'Syscall param writev(vector[...])' valgrind error via 0ae25ff s4:torture:libnet: fix 'Conditional jump or move' valgrind error via ef461a3 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via 4045931 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via 37696e9 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via b90f5f4 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via fbf476e s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via 2f137a9 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error via 9ce1f28 s4:torture:smb2 fix 'Use of uninitialised value of size 8' valgrind error. via d7e6d37 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via bfc2349 s4:torture:smb2 fix 'Use of uninitialised value of size 8' valgrind error. via dc927de s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. via 1ae1920 s4:torture:smb2: fix Use of 'uninitialised value of size 8' valgrind error. via cd7c57c s4:torture:raw: fix 'Invalid read of size 1 & Conditional jump or move' errors. via bb0c4a9 s4:torture:raw: fix 'Conditional jump or move' valgrind error. via 04d70f5 s4:torture:raw: fix 'use of uninitialised value of size 8' valgrind errors via de590da s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error via a22ccb0 s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error via 2a06c99 s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error via 83cb2ba s4:torture:basic: fix 'Conditional jump or move ' valgrind error via d949402 s4:torture:basic: fix 'Syscall param writev(vector[...])' valgrind error via 03302bc s4:libcli: fix 'Conditional jump or move' valgrind error via c20fb11 s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error. via 6806c14 s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error via a5ce559 s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error via 4d5a73e s4:torture:basic fix 'Syscall param writev(vector[...])' valgrind error via 60b2298 s4:lib:registry: fix 'Conditional jump or move' valgrind error. via 9cb4b1b s4:torture:rpc: fix valgrind 'Syscall param writev(vector[...])' valgrind error via c901d98 s4:torture:rpc: fix valgrind 'Syscall param writev(vector[...])' error via 9e8d748 s4:torture:rpc: fix valgrind Syscall param writev(vector[...]) error via 409cd51 s4:libnet: fix 'Syscall param writev(vector[...])' valgrind error via fcf2cbb selftest/samba4.blackbox.export.keytab: check AS-REQ with SPN via 20dc680 s4/heimdal: allow SPNs in AS-REQ via 957741c selftest/samba4.blackbox.export.keytab: check exported keytabs via 5927e46 selftest/samba4.blackbox.export.keytab: use spn based on fqdn via 3116e8d s4: add a minimal ktutil for selftest via deab6c6 s4/libnet: fix exporting to keytab by SPN via 35b2fb4 krb5_wrap: fix keep_old_entries logic in smb_krb5_kt_seek_and_delete_old_entries() via b26ae7f krb5_wrap: add enctype arg to smb_krb5_kt_seek_and_delete_old_entries() from 0c373f2 ctdb-tools: Drop onnode node specifications for recmaster/lvs/natgw
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 39bbd40cda3d37e32f2ef1d1a4199cda3a075417 Author: Noel Power <noel.po...@suse.com> Date: Fri Apr 15 12:42:06 2016 +0100 fix Invalid read of size 8 running rpc.dsgetinfo.DsGetReplicaInfo results in the following valgrind trace ==14966== Invalid read of size 8 ==14966== at 0x88B2D5D: dcerpc_binding_handle_call (binding_handle.c:538) ==14966== by 0x978F33B: dcerpc_drsuapi_DsUnbind_r (ndr_drsuapi_c.c:319) ==14966== by 0x2E9F19: torture_dsgetinfo_tcase_teardown (dsgetinfo.c:431) ==14966== by 0x95536EF: internal_torture_run_test (torture.c:452) ==14966== by 0x9553A4B: torture_run_test_restricted (torture.c:542) ==14966== by 0x260074: run_matching (smbtorture.c:110) ==14966== by 0x25FF36: run_matching (smbtorture.c:95) ==14966== by 0x260195: torture_run_named_tests (smbtorture.c:143) ==14966== by 0x261E14: main (smbtorture.c:665) ==14966== Address 0x28 is not stack'd, malloc'd or (recently) free'd ==14966== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> Autobuild-User(master): Andreas Schneider <a...@cryptomilk.org> Autobuild-Date(master): Mon Apr 25 14:01:33 CEST 2016 on sn-devel-144 commit 417a58a79f712fe56a98f0bdc6e2dcf5805740f0 Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 14:49:44 2016 +0100 s4:torture:vfs: fix Invalid read of size 8 valgrind valgrind error (and segv) when running smbtorture test 'vfs.fruit.SMB2/CREATE context AAPL.SMB2/CREATE context AAPL' (on non-osx system) the following valgrind errors occur ==2419== Invalid read of size 8 ==2419== at 0x4055EA: test_aapl (fruit.c:1939) ==2419== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==2419== by 0x955368F: internal_torture_run_test (torture.c:442) ==2419== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==2419== by 0x26013F: run_matching (smbtorture.c:110) ==2419== by 0x260001: run_matching (smbtorture.c:95) ==2419== by 0x260001: run_matching (smbtorture.c:95) ==2419== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==2419== by 0x261EDF: main (smbtorture.c:665) ==2419== Address 0x10 is not stack'd, malloc'd or (recently) free'd ==2419== =============================================================== INTERNAL ERROR: Signal 11 in pid 2419 (4.2.4) Please read the Trouble-Shooting section of the Samba HOWTO =============================================================== PANIC: internal error Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 8d998db7888a997c461c450f579ca4b4967dc85b Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 11:57:46 2016 +0100 s4:torture:libnet: fix 'Syscall param writev(vector[...])' valgrind error smbtorture test net.api.delshare.api.delshare generates the following valgrind trace ==29209== Syscall param writev(vector[...]) points to uninitialised byte(s) ==29209== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==29209== by 0x106CB033: writev_handler (async_sock.c:340) ==29209== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF673ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0x5D19325: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==29209== by 0x88B2E0D: dcerpc_binding_handle_call (binding_handle.c:556) ==29209== by 0xBC6B4A1: dcerpc_srvsvc_NetShareAdd_r (ndr_srvsvc_c.c:3327) ==29209== by 0x5990D8: test_addshare (libnet_share.c:194) ==29209== by 0x5992D5: torture_delshare (libnet_share.c:228) ==29209== by 0x9553F62: wrap_simple_test (torture.c:632) ==29209== by 0x955368F: internal_torture_run_test (torture.c:442) ==29209== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29209== by 0x26013F: run_matching (smbtorture.c:110) ==29209== by 0x260001: run_matching (smbtorture.c:95) ==29209== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==29209== by 0x261EDF: main (smbtorture.c:665) ==29209== Address 0x1887fd16 is 598 bytes inside a block of size 1,325 alloc'd ==29209== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==29209== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==29209== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==29209== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==29209== by 0xB0ED47D: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==29209== by 0xB0EC847: tstream_smbXcli_np_writev_write_next (tstream_smbXcli_np.c:578) ==29209== by 0xB0EC4D7: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==29209== by 0xC259DFA: tstream_writev_send (tsocket.c:695) ==29209== by 0xC25AD64: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==29209== by 0xF673023: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF677EED: ??? (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0xF673ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==29209== by 0x5D19325: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==29209== by 0x88B2E0D: dcerpc_binding_handle_call (binding_handle.c:556) ==29209== by 0xBC6B4A1: dcerpc_srvsvc_NetShareAdd_r (ndr_srvsvc_c.c:3327) ==29209== by 0x5990D8: test_addshare (libnet_share.c:194) ==29209== by 0x5992D5: torture_delshare (libnet_share.c:228) ==29209== by 0x9553F62: wrap_simple_test (torture.c:632) ==29209== by 0x955368F: internal_torture_run_test (torture.c:442) ==29209== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29209== by 0x26013F: run_matching (smbtorture.c:110) ==29209== by 0x260001: run_matching (smbtorture.c:95) ==29209== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==29209== by 0x261EDF: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 0ae25fff0aa941d3300d733d26c9f2697bc55ed2 Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 11:46:24 2016 +0100 s4:torture:libnet: fix 'Conditional jump or move' valgrind error smbtorture test net.domopen.domopen generated the following valgrind trace. ==29054== Conditional jump or move depends on uninitialised value(s) ==29054== at 0x9788D31: libnet_DomainOpen_send (libnet_domain.c:617) ==29054== by 0x9788E01: libnet_DomainOpen (libnet_domain.c:676) ==29054== by 0x595F5D: test_domainopen (domain.c:41) ==29054== by 0x5961AD: torture_domainopen (domain.c:101) ==29054== by 0x9553F62: wrap_simple_test (torture.c:632) ==29054== by 0x955368F: internal_torture_run_test (torture.c:442) ==29054== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29054== by 0x26013F: run_matching (smbtorture.c:110) ==29054== by 0x260001: run_matching (smbtorture.c:95) ==29054== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==29054== by 0x261EDF: main (smbtorture.c:665) ==29054== ==29054== Conditional jump or move depends on uninitialised value(s) ==29054== at 0x9788D95: libnet_DomainOpen_recv (libnet_domain.c:648) ==29054== by 0x9788E1D: libnet_DomainOpen (libnet_domain.c:677) ==29054== by 0x595F5D: test_domainopen (domain.c:41) ==29054== by 0x5961AD: torture_domainopen (domain.c:101) ==29054== by 0x9553F62: wrap_simple_test (torture.c:632) ==29054== by 0x955368F: internal_torture_run_test (torture.c:442) ==29054== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29054== by 0x26013F: run_matching (smbtorture.c:110) ==29054== by 0x260001: run_matching (smbtorture.c:95) ==29054== by 0x260260: torture_run_named_tests (smbtorture.c:143) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit ef461a3fef4e0e621b50d36b0b2d313ee272c425 Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 11:26:03 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.streams.attributes.attributes generates the following valgrind trace, ==17997== Use of uninitialised value of size 8 ==17997== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==17997== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==17997== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==17997== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==17997== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==17997== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==17997== by 0x5B030F3: smb2_close_send (close.c:42) ==17997== by 0x5B0358A: smb2_close (close.c:78) ==17997== by 0x5B087B3: smb2_util_close (util.c:40) ==17997== by 0x521457: test_stream_attributes (streams.c:1750) ==17997== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==17997== by 0x955368F: internal_torture_run_test (torture.c:442) ==17997== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==17997== by 0x26013F: run_matching (smbtorture.c:110) ==17997== by 0x260001: run_matching (smbtorture.c:95) ==17997== by 0x260001: run_matching (smbtorture.c:95) ==17997== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==17997== by 0x261EDF: main (smbtorture.c:665) ==17997== ==17997== Use of uninitialised value of size 8 ==17997== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==17997== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==17997== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==17997== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==17997== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==17997== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==17997== by 0x5B030F3: smb2_close_send (close.c:42) ==17997== by 0x5B0358A: smb2_close (close.c:78) ==17997== by 0x5B087B3: smb2_util_close (util.c:40) ==17997== by 0x521457: test_stream_attributes (streams.c:1750) ==17997== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==17997== by 0x955368F: internal_torture_run_test (torture.c:442) ==17997== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==17997== by 0x26013F: run_matching (smbtorture.c:110) ==17997== by 0x260001: run_matching (smbtorture.c:95) ==17997== by 0x260001: run_matching (smbtorture.c:95) ==17997== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==17997== by 0x261EDF: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 4045931f67b1afb03d3ba15d870aa7a4c0bc0d3e Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 11:00:25 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.streams.rename2.rename2 generates the following valgrind trace ==17379== Use of uninitialised value of size 8 ==17379== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==17379== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==17379== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==17379== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==17379== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==17379== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==17379== by 0x5B030F3: smb2_close_send (close.c:42) ==17379== by 0x5B0358A: smb2_close (close.c:78) ==17379== by 0x5B087B3: smb2_util_close (util.c:40) ==17379== by 0x51FBA7: test_stream_rename2 (streams.c:1381) ==17379== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==17379== by 0x955368F: internal_torture_run_test (torture.c:442) ==17379== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==17379== by 0x26013F: run_matching (smbtorture.c:110) ==17379== by 0x260001: run_matching (smbtorture.c:95) ==17379== by 0x260001: run_matching (smbtorture.c:95) ==17379== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==17379== by 0x261EDF: main (smbtorture.c:665) ==17379== ==17379== Use of uninitialised value of size 8 ==17379== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==17379== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==17379== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==17379== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==17379== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==17379== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==17379== by 0x5B030F3: smb2_close_send (close.c:42) ==17379== by 0x5B0358A: smb2_close (close.c:78) ==17379== by 0x5B087B3: smb2_util_close (util.c:40) ==17379== by 0x51FBA7: test_stream_rename2 (streams.c:1381) ==17379== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==17379== by 0x955368F: internal_torture_run_test (torture.c:442) ==17379== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==17379== by 0x26013F: run_matching (smbtorture.c:110) ==17379== by 0x260001: run_matching (smbtorture.c:95) ==17379== by 0x260001: run_matching (smbtorture.c:95) ==17379== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==17379== by 0x261EDF: main (smbtorture.c:665) ==17379== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 37696e9bdea98f76b02da788deda626129ae71fa Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 10:48:39 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.streams.names.names generated the following valgrind trace. (../source4/torture/smb2/streams.c:791) testing stream names ==17238== Use of uninitialised value of size 8 ==17238== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==17238== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==17238== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==17238== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==17238== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==17238== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==17238== by 0x5B030F3: smb2_close_send (close.c:42) ==17238== by 0x5B0358A: smb2_close (close.c:78) ==17238== by 0x5B087B3: smb2_util_close (util.c:40) ==17238== by 0x51E480: test_stream_names (streams.c:1053) ==17238== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==17238== by 0x955368F: internal_torture_run_test (torture.c:442) ==17238== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==17238== by 0x26013F: run_matching (smbtorture.c:110) ==17238== by 0x260001: run_matching (smbtorture.c:95) ==17238== by 0x260001: run_matching (smbtorture.c:95) ==17238== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==17238== by 0x261EDF: main (smbtorture.c:665) ==17238== ==17238== Use of uninitialised value of size 8 ==17238== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==17238== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==17238== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==17238== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==17238== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==17238== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==17238== by 0x5B030F3: smb2_close_send (close.c:42) ==17238== by 0x5B0358A: smb2_close (close.c:78) ==17238== by 0x5B087B3: smb2_util_close (util.c:40) ==17238== by 0x51E480: test_stream_names (streams.c:1053) ==17238== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==17238== by 0x955368F: internal_torture_run_test (torture.c:442) ==17238== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==17238== by 0x26013F: run_matching (smbtorture.c:110) ==17238== by 0x260001: run_matching (smbtorture.c:95) ==17238== by 0x260001: run_matching (smbtorture.c:95) ==17238== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==17238== by 0x261EDF: main (smbtorture.c:665) ==17238== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit b90f5f47dc895c1f7a822578f0d916b85b3aaa2c Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 10:32:48 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.streams.sharemodes.sharemodes generates the following valgrind trace ==16980== Use of uninitialised value of size 8 ==16980== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==16980== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16980== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==16980== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==16980== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16980== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16980== by 0x5B030F3: smb2_close_send (close.c:42) ==16980== by 0x5B0358A: smb2_close (close.c:78) ==16980== by 0x5B087B3: smb2_util_close (util.c:40) ==16980== by 0x51B4F3: test_stream_sharemodes (streams.c:557) ==16980== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16980== by 0x955368F: internal_torture_run_test (torture.c:442) ==16980== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16980== by 0x26013F: run_matching (smbtorture.c:110) ==16980== by 0x260001: run_matching (smbtorture.c:95) ==16980== by 0x260001: run_matching (smbtorture.c:95) ==16980== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16980== by 0x261EDF: main (smbtorture.c:665) ==16980== ==16980== Use of uninitialised value of size 8 ==16980== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==16980== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16980== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==16980== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==16980== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16980== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16980== by 0x5B030F3: smb2_close_send (close.c:42) ==16980== by 0x5B0358A: smb2_close (close.c:78) ==16980== by 0x5B087B3: smb2_util_close (util.c:40) ==16980== by 0x51B4F3: test_stream_sharemodes (streams.c:557) ==16980== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16980== by 0x955368F: internal_torture_run_test (torture.c:442) ==16980== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16980== by 0x26013F: run_matching (smbtorture.c:110) ==16980== by 0x260001: run_matching (smbtorture.c:95) ==16980== by 0x260001: run_matching (smbtorture.c:95) ==16980== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16980== by 0x261EDF: main (smbtorture.c:665) ==16980== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit fbf476e2d3a6411fc54acb1ac668a51cd903143d Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 10:22:37 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.streams.io.io generates the following valgrind trace ==16652== Use of uninitialised value of size 8 ==16652== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==16652== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16652== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==16652== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==16652== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16652== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16652== by 0x5B030F3: smb2_close_send (close.c:42) ==16652== by 0x5B0358A: smb2_close (close.c:78) ==16652== by 0x5B087B3: smb2_util_close (util.c:40) ==16652== by 0x51AF21: test_stream_io (streams.c:480) ==16652== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16652== by 0x955368F: internal_torture_run_test (torture.c:442) ==16652== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16652== by 0x26013F: run_matching (smbtorture.c:110) ==16652== by 0x260001: run_matching (smbtorture.c:95) ==16652== by 0x260001: run_matching (smbtorture.c:95) ==16652== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16652== by 0x261EDF: main (smbtorture.c:665) ==16652== ==16652== Use of uninitialised value of size 8 ==16652== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==16652== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16652== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==16652== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==16652== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16652== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16652== by 0x5B030F3: smb2_close_send (close.c:42) ==16652== by 0x5B0358A: smb2_close (close.c:78) ==16652== by 0x5B087B3: smb2_util_close (util.c:40) ==16652== by 0x51AF21: test_stream_io (streams.c:480) ==16652== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16652== by 0x955368F: internal_torture_run_test (torture.c:442) ==16652== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16652== by 0x26013F: run_matching (smbtorture.c:110) ==16652== by 0x260001: run_matching (smbtorture.c:95) ==16652== by 0x260001: run_matching (smbtorture.c:95) ==16652== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16652== by 0x261EDF: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 2f137a982c7e6e86611192af5fec87a7e5544cc5 Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 10:11:16 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error smbtorture test smb2.oplock.brl3.brl3 generated the following valgrind trace ==16564== Use of uninitialised value of size 8 ==16564== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==16564== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16564== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16564== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16564== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16564== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16564== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16564== by 0x5B07AAE: smb2_lock (lock.c:80) ==16564== by 0x4B62B1: test_smb2_oplock_brl3 (oplock.c:3578) ==16564== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16564== by 0x955368F: internal_torture_run_test (torture.c:442) ==16564== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16564== by 0x26013F: run_matching (smbtorture.c:110) ==16564== by 0x260001: run_matching (smbtorture.c:95) ==16564== by 0x260001: run_matching (smbtorture.c:95) ==16564== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16564== by 0x261EDF: main (smbtorture.c:665) ==16564== ==16564== Use of uninitialised value of size 8 ==16564== at 0x8F00649: _samba_rijndaelEncrypt (rijndael-alg-fst.c:963) ==16564== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16564== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16564== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16564== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16564== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16564== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16564== by 0x5B07AAE: smb2_lock (lock.c:80) ==16564== by 0x4B62B1: test_smb2_oplock_brl3 (oplock.c:3578) ==16564== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16564== by 0x955368F: internal_torture_run_test (torture.c:442) ==16564== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16564== by 0x26013F: run_matching (smbtorture.c:110) ==16564== by 0x260001: run_matching (smbtorture.c:95) ==16564== by 0x260001: run_matching (smbtorture.c:95) ==16564== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16564== by 0x261EDF: main (smbtorture.c:665) ==16564== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 9ce1f28b8ab31d6bb9f2468dd3cdd57bf34f7af7 Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 10:07:21 2016 +0100 s4:torture:smb2 fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.oplock.brl2.brl2 generates the following valgrind trace ==16443== Use of uninitialised value of size 8 ==16443== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==16443== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16443== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16443== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16443== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16443== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16443== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16443== by 0x5B07AAE: smb2_lock (lock.c:80) ==16443== by 0x4B5971: test_smb2_oplock_brl2 (oplock.c:3464) ==16443== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16443== by 0x955368F: internal_torture_run_test (torture.c:442) ==16443== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16443== by 0x26013F: run_matching (smbtorture.c:110) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16443== by 0x261EDF: main (smbtorture.c:665) ==16443== ==16443== Use of uninitialised value of size 8 ==16443== at 0x8F00649: _samba_rijndaelEncrypt (rijndael-alg-fst.c:963) ==16443== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16443== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16443== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16443== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16443== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16443== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16443== by 0x5B07AAE: smb2_lock (lock.c:80) ==16443== by 0x4B5971: test_smb2_oplock_brl2 (oplock.c:3464) ==16443== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16443== by 0x955368F: internal_torture_run_test (torture.c:442) ==16443== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16443== by 0x26013F: run_matching (smbtorture.c:110) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16443== by 0x261EDF: main (smbtorture.c:665) ==16443== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit d7e6d37e5e97c0c124f2c865118d28cc60ba6b92 Author: Noel Power <noel.po...@suse.com> Date: Wed Apr 20 09:53:50 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture smb2.oplock.brl1.brl1 generates the following valgrind trace ==16002== Use of uninitialised value of size 8 ==16002== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==16002== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16002== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16002== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16002== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16002== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16002== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16002== by 0x5B07AAE: smb2_lock (lock.c:80) ==16002== by 0x4B50D8: test_smb2_oplock_brl1 (oplock.c:3352) ==16002== by 0x48B7B5: wrap_simple_2smb2_test (smb2.c:112) ==16002== by 0x955368F: internal_torture_run_test (torture.c:442) ==16002== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16002== by 0x26013F: run_matching (smbtorture.c:110) ==16002== by 0x260001: run_matching (smbtorture.c:95) ==16002== by 0x260001: run_matching (smbtorture.c:95) ==16002== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16002== by 0x261EDF: main (smbtorture.c:665) ==16002== ==16002== Use of uninitialised value of size 8 ==16002== at 0x8F00649: _samba_rijndaelEncrypt (rijndael-alg-fst.c:963) ==16002== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16002== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16002== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16002== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16002== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16002== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16002== by 0x5B07AAE: smb2_lock (lock.c:80) ==16002== by 0x4B50D8: test_smb2_oplock_brl1 (oplock.c:3352) ==16002== by 0x48B7B5: wrap_simple_2smb2_test (smb2.c:112) ==16002== by 0x955368F: internal_torture_run_test (torture.c:442) ==16002== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16002== by 0x26013F: run_matching (smbtorture.c:110) ==16002== by 0x260001: run_matching (smbtorture.c:95) ==16002== by 0x260001: run_matching (smbtorture.c:95) ==16002== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16002== by 0x261EDF: main (smbtorture.c:665) ==16002== ==16002== Use of uninitialised value of size 8 ==16002== at 0x8F006AF: _samba_rijndaelEncrypt (rijndael-alg-fst.c:968) ==16002== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16002== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16002== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16002== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16002== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16002== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16002== by 0x5B07AAE: smb2_lock (lock.c:80) ==16002== by 0x4B50D8: test_smb2_oplock_brl1 (oplock.c:3352) ==16002== by 0x48B7B5: wrap_simple_2smb2_test (smb2.c:112) ==16002== by 0x955368F: internal_torture_run_test (torture.c:442) ==16002== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16002== by 0x26013F: run_matching (smbtorture.c:110) ==16002== by 0x260001: run_matching (smbtorture.c:95) ==16002== by 0x260001: run_matching (smbtorture.c:95) ==16002== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16002== by 0x261EDF: main (smbtorture.c:665) ==16002== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit bfc2349a566d2edb02d2a37bc9c81f1c4019af64 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 20:28:32 2016 +0100 s4:torture:smb2 fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.oplock.batch10.batch10 produces the following valgrind trace Use of uninitialised value of size 8 ==9662== at 0x8F005A1: _samba_rijndaelEncrypt (rijndael-alg-fst.c:956) ==9662== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==9662== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==9662== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==9662== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==9662== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==9662== by 0x5B04C89: smb2_write_send (write.c:49) ==9662== by 0x5B04F85: smb2_write (write.c:79) ==9662== by 0x4AD523: test_smb2_oplock_batch10 (oplock.c:1820) ==9662== by 0x48B7B5: wrap_simple_2smb2_test (smb2.c:112) ==9662== by 0x955368F: internal_torture_run_test (torture.c:442) ==9662== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==9662== by 0x26013F: run_matching (smbtorture.c:110) ==9662== by 0x260001: run_matching (smbtorture.c:95) ==9662== by 0x260001: run_matching (smbtorture.c:95) ==9662== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==9662== by 0x261EDF: main (smbtorture.c:665) ==9662== ==9662== Use of uninitialised value of size 8 ==9662== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==9662== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==9662== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==9662== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==9662== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==9662== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==9662== by 0x5B04C89: smb2_write_send (write.c:49) ==9662== by 0x5B04F85: smb2_write (write.c:79) ==9662== by 0x4AD523: test_smb2_oplock_batch10 (oplock.c:1820) ==9662== by 0x48B7B5: wrap_simple_2smb2_test (smb2.c:112) ==9662== by 0x955368F: internal_torture_run_test (torture.c:442) ==9662== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==9662== by 0x26013F: run_matching (smbtorture.c:110) ==9662== by 0x260001: run_matching (smbtorture.c:95) ==9662== by 0x260001: run_matching (smbtorture.c:95) ==9662== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==9662== by 0x261EDF: main (smbtorture.c:665) ==9662== Please enter the commit message for your changes. Lines starting Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit dc927dee2e266518c49deaa6fe5507bd5e4dbebd Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 19:49:02 2016 +0100 s4:torture:smb2: fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.notify.mask.mask ==6451== Use of uninitialised value of size 8 ==6451== at 0x8F005C2: _samba_rijndaelEncrypt (rijndael-alg-fst.c:957) ==6451== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==6451== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==6451== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==6451== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==6451== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==6451== by 0x5B030F3: smb2_close_send (close.c:42) ==6451== by 0x5B0358A: smb2_close (close.c:78) ==6451== by 0x5B087B3: smb2_util_close (util.c:40) ==6451== by 0x483E97: torture_smb2_notify_mask (notify.c:1061) ==6451== by 0x48B783: wrap_simple_2smb2_test (smb2.c:112) ==6451== by 0x955368F: internal_torture_run_test (torture.c:442) ==6451== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==6451== by 0x26013F: run_matching (smbtorture.c:110) ==6451== by 0x260001: run_matching (smbtorture.c:95) ==6451== by 0x260001: run_matching (smbtorture.c:95) ==6451== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==6451== by 0x261EDF: main (smbtorture.c:665) ==6451== ==6451== Use of uninitialised value of size 8 ==6451== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==6451== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==6451== by 0x8F01A74: aes_cmac_128_update (aes_cmac_128.c:151) ==6451== by 0xB0D11B7: smb2_signing_sign_pdu (smb2_signing.c:74) ==6451== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==6451== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==6451== by 0x5B030F3: smb2_close_send (close.c:42) ==6451== by 0x5B0358A: smb2_close (close.c:78) ==6451== by 0x5B087B3: smb2_util_close (util.c:40) ==6451== by 0x483E97: torture_smb2_notify_mask (notify.c:1061) ==6451== by 0x48B783: wrap_simple_2smb2_test (smb2.c:112) ==6451== by 0x955368F: internal_torture_run_test (torture.c:442) ==6451== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==6451== by 0x26013F: run_matching (smbtorture.c:110) ==6451== by 0x260001: run_matching (smbtorture.c:95) ==6451== by 0x260001: run_matching (smbtorture.c:95) ==6451== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==6451== by 0x261EDF: main (smbtorture.c:665) ==6451== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 1ae19203e265a679cae8284605a4a8b658a42fa4 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 19:12:27 2016 +0100 s4:torture:smb2: fix Use of 'uninitialised value of size 8' valgrind error. smbtorture test smb2.create.aclfile.aclfile produces the following valgrind trace ==6025== Use of uninitialised value of size 8 ==6025== at 0xFB0B061: _itoa_word (in /lib64/libc-2.19.so) ==6025== by 0xFB0EAD2: vfprintf (in /lib64/libc-2.19.so) ==6025== by 0xFB36712: vasprintf (in /lib64/libc-2.19.so) ==6025== by 0xAEBB348: ndr_print_debug_helper (ndr.c:314) ==6025== by 0xAEB8ED1: ndr_print_uint16 (ndr_basic.c:1055) ==6025== by 0x3E5951: ndr_print_security_ace (ndr_security.c:539) ==6025== by 0x3E6251: ndr_print_security_acl (ndr_security.c:642) ==6025== by 0x3E7A76: ndr_print_security_descriptor (ndr_security.c:890) ==6025== by 0xAEBB860: ndr_print_debug (ndr.c:409) ==6025== by 0x45FCB6: smb2_util_verify_sd (util.c:598) ==6025== by 0x502246: test_create_acl_ext (create.c:634) ==6025== by 0x506E13: test_create_acl_file (create.c:1232) ==6025== by 0x48B420: wrap_simple_1smb2_test (smb2.c:52) ==6025== by 0x955368F: internal_torture_run_test (torture.c:442) ==6025== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==6025== by 0x26013F: run_matching (smbtorture.c:110) ==6025== by 0x260001: run_matching (smbtorture.c:95) ==6025== by 0x260001: run_matching (smbtorture.c:95) ==6025== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==6025== by 0x261EDF: main (smbtorture.c:665) ==6025== ==6025== Conditional jump or move depends on uninitialised value(s) ==6025== at 0xFB0B068: _itoa_word (in /lib64/libc-2.19.so) ==6025== by 0xFB0EAD2: vfprintf (in /lib64/libc-2.19.so) ==6025== by 0xFB36712: vasprintf (in /lib64/libc-2.19.so) ==6025== by 0xAEBB348: ndr_print_debug_helper (ndr.c:314) ==6025== by 0xAEB8ED1: ndr_print_uint16 (ndr_basic.c:1055) ==6025== by 0x3E5951: ndr_print_security_ace (ndr_security.c:539) ==6025== by 0x3E6251: ndr_print_security_acl (ndr_security.c:642) ==6025== by 0x3E7A76: ndr_print_security_descriptor (ndr_security.c:890) ==6025== by 0xAEBB860: ndr_print_debug (ndr.c:409) ==6025== by 0x45FCB6: smb2_util_verify_sd (util.c:598) ==6025== by 0x502246: test_create_acl_ext (create.c:634) ==6025== by 0x506E13: test_create_acl_file (create.c:1232) ==6025== by 0x48B420: wrap_simple_1smb2_test (smb2.c:52) ==6025== by 0x955368F: internal_torture_run_test (torture.c:442) ==6025== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==6025== by 0x26013F: run_matching (smbtorture.c:110) ==6025== by 0x260001: run_matching (smbtorture.c:95) ==6025== by 0x260001: run_matching (smbtorture.c:95) ==6025== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==6025== by 0x261EDF: main (smbtorture.c:665) ==6025== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit cd7c57c85d9f3f6c27f28c120269f67e6d1ee45f Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 18:42:57 2016 +0100 s4:torture:raw: fix 'Invalid read of size 1 & Conditional jump or move' errors. smbtorture test raw.offline.offline generates the following valgrind trace(s). ==5130== at 0x2223AF: loadfile_callback (offline.c:107) ==5130== by 0x5AF73E6: loadfile_handler (loadfile.c:208) ==5130== by 0x5ADFEE0: smbcli_request_done (clitransport.c:395) ==5130== by 0xF676EEE: tevent_common_loop_timer_delay (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0xF677EF9: ??? (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0x223A16: torture_test_offline (offline.c:493) ==5130== by 0x9553F62: wrap_simple_test (torture.c:632) ==5130== by 0x955368F: internal_torture_run_test (torture.c:442) ==5130== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==5130== by 0x260121: run_matching (smbtorture.c:110) ==5130== by 0x25FFE3: run_matching (smbtorture.c:95) ==5130== by 0x260242: torture_run_named_tests (smbtorture.c:143) ==5130== by 0x261EC1: main (smbtorture.c:665) ==5130== Address 0x188b80d0 is 96 bytes inside a block of size 8,288 free'd ==5130== at 0x4C2A37C: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==5130== by 0xF4673A3: ??? (in /usr/lib64/libtalloc.so.2.1.5) ==5130== by 0xF460E42: _talloc_free (in /usr/lib64/libtalloc.so.2.1.5) ==5130== by 0x5AF7635: smb_composite_loadfile_recv (loadfile.c:278) ==5130== by 0x2222F7: loadfile_callback (offline.c:91) ==5130== by 0x5AF73E6: loadfile_handler (loadfile.c:208) ==5130== by 0x5ADFEE0: smbcli_request_done (clitransport.c:395) ==5130== by 0xF676EEE: tevent_common_loop_timer_delay (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0xF677EF9: ??? (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==5130== by 0x223A16: torture_test_offline (offline.c:493) ==5130== by 0x9553F62: wrap_simple_test (torture.c:632) ==5130== by 0x955368F: internal_torture_run_test (torture.c:442) ==5130== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==5130== by 0x260121: run_matching (smbtorture.c:110) ==5130== by 0x25FFE3: run_matching (smbtorture.c:95) ==5130== by 0x260242: torture_run_named_tests (smbtorture.c:143) ==5130== by 0x261EC1: main (smbtorture.c:665) ==5130== AND ==5428== Conditional jump or move depends on uninitialised value(s) ==5428== at 0x22270E: getoffline_callback (offline.c:197) ==5428== by 0x5ADFEE0: smbcli_request_done (clitransport.c:395) ==5428== by 0xF676EEE: tevent_common_loop_timer_delay (in /usr/lib64/libtevent.so.0.9.26) ==5428== by 0xF677EF9: ??? (in /usr/lib64/libtevent.so.0.9.26) ==5428== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==5428== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==5428== by 0x223A1B: torture_test_offline (offline.c:494) ==5428== by 0x9553F62: wrap_simple_test (torture.c:632) ==5428== by 0x955368F: internal_torture_run_test (torture.c:442) ==5428== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==5428== by 0x260126: run_matching (smbtorture.c:110) ==5428== by 0x25FFE8: run_matching (smbtorture.c:95) ==5428== by 0x260247: torture_run_named_tests (smbtorture.c:143) ==5428== by 0x261EC6: main (smbtorture.c:665) ==5428== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit bb0c4a95df109b49bb546d37b9347c4430d4f2a3 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 17:37:57 2016 +0100 s4:torture:raw: fix 'Conditional jump or move' valgrind error. smbtorture test raw.bench-tcon.bench-tcon produces the following valgrind trace ==32163== Conditional jump or move depends on uninitialised value(s) ==32163== at 0x1F9D61: rate_convert_secs (tconrate.c:149) ==32163== by 0x1FA04C: torture_bench_treeconnect (tconrate.c:189) ==32163== by 0x9553F62: wrap_simple_test (torture.c:632) ==32163== by 0x955368F: internal_torture_run_test (torture.c:442) ==32163== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==32163== by 0x260121: run_matching (smbtorture.c:110) ==32163== by 0x25FFE3: run_matching (smbtorture.c:95) ==32163== by 0x260242: torture_run_named_tests (smbtorture.c:143) ==32163== by 0x261EC1: main (smbtorture.c:665) ==32163== ==32163== Use of uninitialised value of size 8 ==32163== at 0xFB0B0BB: _itoa_word (in /lib64/libc-2.19.so) ==32163== by 0xFB0EAD2: vfprintf (in /lib64/libc-2.19.so) ==32163== by 0xFB15598: printf (in /lib64/libc-2.19.so) ==32163== by 0x1FA064: torture_bench_treeconnect (tconrate.c:188) ==32163== by 0x9553F62: wrap_simple_test (torture.c:632) ==32163== by 0x955368F: internal_torture_run_test (torture.c:442) ==32163== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==32163== by 0x260121: run_matching (smbtorture.c:110) ==32163== by 0x25FFE3: run_matching (smbtorture.c:95) ==32163== by 0x260242: torture_run_named_tests (smbtorture.c:143) ==32163== by 0x261EC1: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 04d70f5206c782de8b1746e6fb52698cfa337b76 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 17:02:29 2016 +0100 s4:torture:raw: fix 'use of uninitialised value of size 8' valgrind errors smbtorture test raw.acls.create_file.create_file produces the following valgrind trace ==31783== Use of uninitialised value of size 8 ==31783== at 0xFB0B061: _itoa_word (in /lib64/libc-2.19.so) ==31783== by 0xFB0EAD2: vfprintf (in /lib64/libc-2.19.so) ==31783== by 0xFB36712: vasprintf (in /lib64/libc-2.19.so) ==31783== by 0xAEBB348: ndr_print_debug_helper (ndr.c:314) ==31783== by 0xAEB8ED1: ndr_print_uint16 (ndr_basic.c:1055) ==31783== by 0x3E591A: ndr_print_security_ace (ndr_security.c:539) ==31783== by 0x3E621A: ndr_print_security_acl (ndr_security.c:642) ==31783== by 0x3E7A3F: ndr_print_security_descriptor (ndr_security.c:890) ==31783== by 0xAEBB860: ndr_print_debug (ndr.c:409) ==31783== by 0x20C91F: verify_sd (acls.c:89) ==31783== by 0x20D8C3: test_nttrans_create_ext (acls.c:306) ==31783== by 0x20E3A8: test_nttrans_create_file (acls.c:381) ==31783== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==31783== by 0x955368F: internal_torture_run_test (torture.c:442) ==31783== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==31783== by 0x260108: run_matching (smbtorture.c:110) ==31783== by 0x25FFCA: run_matching (smbtorture.c:95) ==31783== by 0x25FFCA: run_matching (smbtorture.c:95) ==31783== by 0x260229: torture_run_named_tests (smbtorture.c:143) ==31783== by 0x261EA8: main (smbtorture.c:665) ==31783== ==31783== Conditional jump or move depends on uninitialised value(s) ==31783== at 0xFB0B068: _itoa_word (in /lib64/libc-2.19.so) ==31783== by 0xFB0EAD2: vfprintf (in /lib64/libc-2.19.so) ==31783== by 0xFB36712: vasprintf (in /lib64/libc-2.19.so) ==31783== by 0xAEBB348: ndr_print_debug_helper (ndr.c:314) ==31783== by 0xAEB8ED1: ndr_print_uint16 (ndr_basic.c:1055) ==31783== by 0x3E591A: ndr_print_security_ace (ndr_security.c:539) ==31783== by 0x3E621A: ndr_print_security_acl (ndr_security.c:642) ==31783== by 0x3E7A3F: ndr_print_security_descriptor (ndr_security.c:890) ==31783== by 0xAEBB860: ndr_print_debug (ndr.c:409) ==31783== by 0x20C91F: verify_sd (acls.c:89) ==31783== by 0x20D8C3: test_nttrans_create_ext (acls.c:306) ==31783== by 0x20E3A8: test_nttrans_create_file (acls.c:381) ==31783== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==31783== by 0x955368F: internal_torture_run_test (torture.c:442) ==31783== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==31783== by 0x260108: run_matching (smbtorture.c:110) ==31783== by 0x25FFCA: run_matching (smbtorture.c:95) ==31783== by 0x25FFCA: run_matching (smbtorture.c:95) ==31783== by 0x260229: torture_run_named_tests (smbtorture.c:143) ==31783== by 0x261EA8: main (smbtorture.c:665) ==31783== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit de590daa1c10d28908652c3bf8bb7f04069408b1 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 16:34:06 2016 +0100 s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture test raw.streams.createdisp.createdisp results in the following valgrind trace ==30946== Syscall param writev(vector[...]) points to uninitialised byte(s) ==30946== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==30946== by 0x106CB033: writev_handler (async_sock.c:340) ==30946== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30946== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30946== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==30946== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==30946== by 0x5AE343E: smbcli_request_simple_recv (rawrequest.c:430) ==30946== by 0x5ADC8BC: smb_raw_close (rawfile.c:847) ==30946== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30946== by 0x209F0D: create_file_with_stream (streams.c:1502) ==30946== by 0x20A072: test_stream_create_disposition (streams.c:1527) ==30946== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30946== by 0x955368F: internal_torture_run_test (torture.c:442) ==30946== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30946== by 0x2600D6: run_matching (smbtorture.c:110) ==30946== by 0x25FF98: run_matching (smbtorture.c:95) ==30946== by 0x25FF98: run_matching (smbtorture.c:95) ==30946== by 0x2601F7: torture_run_named_tests (smbtorture.c:143) ==30946== by 0x261E76: main (smbtorture.c:665) ==30946== Address 0x187ebbc6 is 598 bytes inside a block of size 1,325 alloc'd ==30946== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30946== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==30946== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==30946== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==30946== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==30946== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==30946== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==30946== by 0x5ADC869: smb_raw_close_send (rawfile.c:832) ==30946== by 0x5ADC8AC: smb_raw_close (rawfile.c:846) ==30946== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30946== by 0x209F0D: create_file_with_stream (streams.c:1502) ==30946== by 0x20A072: test_stream_create_disposition (streams.c:1527) ==30946== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30946== by 0x955368F: internal_torture_run_test (torture.c:442) ==30946== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30946== by 0x2600D6: run_matching (smbtorture.c:110) ==30946== by 0x25FF98: run_matching (smbtorture.c:95) ==30946== by 0x25FF98: run_matching (smbtorture.c:95) ==30946== by 0x2601F7: torture_run_named_tests (smbtorture.c:143) ==30946== by 0x261E76: main (smbtorture.c:665 Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit a22ccb04a030ca9293df74ec0e5b3f8721702ae3 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 16:20:55 2016 +0100 s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture test raw.open.openx-over-dir.openx-over-dir results in the following valgrind trace ==30597== Syscall param writev(vector[...]) points to uninitialised byte(s) ==30597== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==30597== by 0x106CB033: writev_handler (async_sock.c:340) ==30597== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==30597== by 0x5AE343E: smbcli_request_simple_recv (rawrequest.c:430) ==30597== by 0x5ADC8BC: smb_raw_close (rawfile.c:847) ==30597== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30597== by 0x1A57F0: test_openx_over_dir (open.c:1495) ==30597== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30597== by 0x955368F: internal_torture_run_test (torture.c:442) ==30597== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30597== by 0x2600BD: run_matching (smbtorture.c:110) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x2601DE: torture_run_named_tests (smbtorture.c:143) ==30597== by 0x261E5D: main (smbtorture.c:665) ==30597== Address 0x187e41d6 is 598 bytes inside a block of size 1,325 alloc'd ==30597== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30597== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==30597== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==30597== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==30597== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==30597== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==30597== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==30597== by 0x5ADC869: smb_raw_close_send (rawfile.c:832) ==30597== by 0x5ADC8AC: smb_raw_close (rawfile.c:846) ==30597== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30597== by 0x1A57F0: test_openx_over_dir (open.c:1495) ==30597== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30597== by 0x955368F: internal_torture_run_test (torture.c:442) ==30597== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30597== by 0x2600BD: run_matching (smbtorture.c:110) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x25FF7F: run_matching (smbtorture.c:95) ==30597== by 0x2601DE: torture_run_named_tests (smbtorture.c:143) ==30597== by 0x261E5D: main (smbtorture.c:665) ==30597== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 2a06c992c81010ef9408bb9db065a2d1b2b49876 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 16:04:26 2016 +0100 s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture test raw.open.chained-ntcreatex.chained-ntcreatex results in the following valgrind trace ==30405== Syscall param writev(vector[...]) points to uninitialised byte(s) ==30405== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==30405== by 0x106CB033: writev_handler (async_sock.c:340) ==30405== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==30405== by 0x5AE343E: smbcli_request_simple_recv (rawrequest.c:430) ==30405== by 0x5ADC8BC: smb_raw_close (rawfile.c:847) ==30405== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30405== by 0x1A66B4: test_chained_ntcreatex_readx (open.c:1735) ==30405== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30405== by 0x955368F: internal_torture_run_test (torture.c:442) ==30405== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30405== by 0x2600A4: run_matching (smbtorture.c:110) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==30405== by 0x261E44: main (smbtorture.c:665) ==30405== Address 0x187e1196 is 598 bytes inside a block of size 1,325 alloc'd ==30405== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30405== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==30405== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==30405== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==30405== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==30405== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==30405== by 0x5ADC869: smb_raw_close_send (rawfile.c:832) ==30405== by 0x5ADC8AC: smb_raw_close (rawfile.c:846) ==30405== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30405== by 0x1A66B4: test_chained_ntcreatex_readx (open.c:1735) ==30405== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30405== by 0x955368F: internal_torture_run_test (torture.c:442) ==30405== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30405== by 0x2600A4: run_matching (smbtorture.c:110) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==30405== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 83cb2bae8dfc6939b540a0a9bcc5eda05ba2ce5a Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 15:52:12 2016 +0100 s4:torture:basic: fix 'Conditional jump or move ' valgrind error running smbtorture test base.bench-holdopen.bench-holdopen yields the following valgrind trace. ==29953== Conditional jump or move depends on uninitialised value(s) ==29953== at 0xF4634F0: _talloc_zero_array (in /usr/lib64/libtalloc.so.2.1.5) ==29953== by 0x5AE257E: smbcli_request_setup_transport (rawrequest.c:101) ==29953== by 0x5AE04AF: smb_raw_echo_send (clitransport.c:554) ==29953== by 0x5AE0774: smb_raw_echo (clitransport.c:609) ==29953== by 0x4183D3: torture_holdopen (misc.c:288) ==29953== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==29953== by 0x955368F: internal_torture_run_test (torture.c:442) ==29953== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29953== by 0x2600A4: run_matching (smbtorture.c:110) ==29953== by 0x25FF66: run_matching (smbtorture.c:95) ==29953== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==29953== by 0x261E44: main (smbtorture.c:665) ==29953== ==29953== Conditional jump or move depends on uninitialised value(s) ==29953== at 0xF4630E3: _talloc_zero (in /usr/lib64/libtalloc.so.2.1.5) ==29953== by 0x5AE257E: smbcli_request_setup_transport (rawrequest.c:101) ==29953== by 0x5AE04AF: smb_raw_echo_send (clitransport.c:554) ==29953== by 0x5AE0774: smb_raw_echo (clitransport.c:609) ==29953== by 0x4183D3: torture_holdopen (misc.c:288) ==29953== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==29953== by 0x955368F: internal_torture_run_test (torture.c:442) ==29953== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==29953== by 0x2600A4: run_matching (smbtorture.c:110) ==29953== by 0x25FF66: run_matching (smbtorture.c:95) ==29953== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==29953== by 0x261E44: main (smbtorture.c:665) ==29953== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit d94940276a4e37cb936aa63df20618b3c13105e0 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 14:30:44 2016 +0100 s4:torture:basic: fix 'Syscall param writev(vector[...])' valgrind error smbtorture test base.winattr.winattr yields the following trace ==25514== Syscall param writev(vector[...]) points to uninitialised byte(s) ==25514== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==25514== by 0x106CB033: writev_handler (async_sock.c:340) ==25514== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==25514== by 0x5AEEC7E: smb_raw_nttrans_recv (rawtrans.c:408) ==25514== by 0x5AF6543: smb_raw_query_secdesc_recv (rawacl.c:67) ==25514== by 0x5AF580F: smb_raw_fileinfo_recv (rawfileinfo.c:699) ==25514== by 0x5AF58BE: smb_raw_fileinfo (rawfileinfo.c:721) ==25514== by 0x454AC3: torture_winattrtest (attr.c:217) ==25514== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==25514== by 0x955368F: internal_torture_run_test (torture.c:442) ==25514== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==25514== by 0x2600A4: run_matching (smbtorture.c:110) ==25514== by 0x25FF66: run_matching (smbtorture.c:95) ==25514== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==25514== by 0x261E44: main (smbtorture.c:665) ==25514== Address 0x187d69c6 is 598 bytes inside a block of size 1,325 alloc'd ==25514== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==25514== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==25514== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==25514== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==25514== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==25514== by 0x5AEE9B2: smb_raw_nttrans_send (rawtrans.c:310) ==25514== by 0x5AF64F0: smb_raw_query_secdesc_send (rawacl.c:51) ==25514== by 0x5AF56E5: smb_raw_fileinfo_send (rawfileinfo.c:658) ==25514== by 0x5AF58A3: smb_raw_fileinfo (rawfileinfo.c:720) ==25514== by 0x454AC3: torture_winattrtest (attr.c:217) ==25514== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==25514== by 0x955368F: internal_torture_run_test (torture.c:442) ==25514== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==25514== by 0x2600A4: run_matching (smbtorture.c:110) ==25514== by 0x25FF66: run_matching (smbtorture.c:95) ==25514== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==25514== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 03302bcb8649aade7d9ed7e011710e4430f542ae Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 13:02:59 2016 +0100 s4:libcli: fix 'Conditional jump or move' valgrind error smbtorture test base.tcondev.tcondev causes the following valgrind trace ==23282== Conditional jump or move depends on uninitialised value(s) ==23282== at 0x9BE5632: smbcli_tconX (cliconnect.c:148) ==23282== by 0x41021C: tcon_devtest (base.c:91) ==23282== by 0x411A01: run_tcon_devtype_test (base.c:522) ==23282== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==23282== by 0x955368F: internal_torture_run_test (torture.c:442) ==23282== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==23282== by 0x2600A4: run_matching (smbtorture.c:110) ==23282== by 0x25FF66: run_matching (smbtorture.c:95) ==23282== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==23282== by 0x261E44: main (smbtorture.c:665) ==23282== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit c20fb11665e1e90269d6a9a1589652d568f6ac2a Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 12:37:03 2016 +0100 s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error. smbtorture test base.aliases.setpathinfo_aliases.setpathinfo_aliases results in the following valgrind trace ==23067== Syscall param writev(vector[...]) points to uninitialised byte(s) ==23067== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==23067== by 0x106CB033: writev_handler (async_sock.c:340) ==23067== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==23067== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==23067== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==23067== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==23067== by 0x423EB4: setpathinfo_aliases (aliases.c:367) ==23067== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==23067== by 0x955368F: internal_torture_run_test (torture.c:442) ==23067== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==23067== by 0x2600A4: run_matching (smbtorture.c:110) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==23067== by 0x261E44: main (smbtorture.c:665) ==23067== Address 0x187e0096 is 598 bytes inside a block of size 1,325 alloc'd ==23067== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==23067== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==23067== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==23067== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==23067== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==23067== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==23067== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==23067== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==23067== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==23067== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==23067== by 0x423EB4: setpathinfo_aliases (aliases.c:367) ==23067== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==23067== by 0x955368F: internal_torture_run_test (torture.c:442) ==23067== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==23067== by 0x2600A4: run_matching (smbtorture.c:110) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x25FF66: run_matching (smbtorture.c:95) ==23067== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==23067== by 0x261E44: main (smbtorture.c:665) ==23067== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 6806c1486e3d30b102f8bb31dcc59989a29b4cf9 Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 12:20:35 2016 +0100 s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error smbtorture test base.aliases.setfileinfo_aliases.setfileinfo_aliases results in the following valgrind trace ==22757== Syscall param writev(vector[...]) points to uninitialised byte(s) ==22757== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==22757== by 0x106CB033: writev_handler (async_sock.c:340) ==22757== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==22757== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==22757== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==22757== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22757== by 0x423C91: setfileinfo_aliases (aliases.c:327) ==22757== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22757== by 0x955368F: internal_torture_run_test (torture.c:442) ==22757== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22757== by 0x2600A4: run_matching (smbtorture.c:110) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22757== by 0x261E44: main (smbtorture.c:665) ==22757== Address 0x187dfee6 is 598 bytes inside a block of size 1,325 alloc'd ==22757== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22757== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==22757== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==22757== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==22757== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==22757== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==22757== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==22757== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==22757== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==22757== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22757== by 0x423C91: setfileinfo_aliases (aliases.c:327) ==22757== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22757== by 0x955368F: internal_torture_run_test (torture.c:442) ==22757== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22757== by 0x2600A4: run_matching (smbtorture.c:110) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x25FF66: run_matching (smbtorture.c:95) ==22757== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22757== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit a5ce559a800fd8e80289325fd94b881b9af7fb7a Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 11:57:58 2016 +0100 s4:torture:basic: fix valgrind 'Syscall param writev(vector[...])' error running smbtorture test base.aliases.FINDFIRST aliases.FINDFIRST aliases results in the following valgrind trace ==22639== Syscall param writev(vector[...]) points to uninitialised byte(s) ==22639== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==22639== by 0x106CB033: writev_handler (async_sock.c:340) ==22639== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==22639== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==22639== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==22639== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22639== by 0x423672: findfirst_aliases (aliases.c:213) ==22639== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22639== by 0x955368F: internal_torture_run_test (torture.c:442) ==22639== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22639== by 0x2600A4: run_matching (smbtorture.c:110) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22639== by 0x261E44: main (smbtorture.c:665) ==22639== Address 0x187dfd26 is 598 bytes inside a block of size 1,325 alloc'd ==22639== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22639== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==22639== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==22639== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==22639== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==22639== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==22639== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==22639== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==22639== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==22639== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22639== by 0x423672: findfirst_aliases (aliases.c:213) ==22639== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22639== by 0x955368F: internal_torture_run_test (torture.c:442) ==22639== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22639== by 0x2600A4: run_matching (smbtorture.c:110) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x25FF66: run_matching (smbtorture.c:95) ==22639== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22639== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 4d5a73e2465bb366bc1bdf3086eb45076511d60a Author: Noel Power <noel.po...@suse.com> Date: Mon Apr 18 11:50:08 2016 +0100 s4:torture:basic fix 'Syscall param writev(vector[...])' valgrind error smbtorture 'base.aliases.QPATHINFO aliases.QPATHINFO aliases' results in following valgrind trace ==22469== Syscall param writev(vector[...]) points to uninitialised byte(s) ==22469== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==22469== by 0x106CB033: writev_handler (async_sock.c:340) ==22469== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==22469== by 0x5AE6019: smb_raw_write_recv (rawreadwrite.c:303) ==22469== by 0x5AE63FD: smb_raw_write (rawreadwrite.c:344) ==22469== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22469== by 0x423431: qpathinfo_aliases (aliases.c:171) ==22469== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22469== by 0x955368F: internal_torture_run_test (torture.c:442) ==22469== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22469== by 0x2600A4: run_matching (smbtorture.c:110) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22469== by 0x261E44: main (smbtorture.c:665) ==22469== Address 0x187dfb86 is 598 bytes inside a block of size 1,325 alloc'd ==22469== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==22469== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==22469== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==22469== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==22469== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==22469== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==22469== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==22469== by 0x5AE5FDD: smb_raw_write_send (rawreadwrite.c:289) ==22469== by 0x5AE63E6: smb_raw_write (rawreadwrite.c:343) ==22469== by 0x9BE50CA: smbcli_write (clireadwrite.c:118) ==22469== by 0x423431: qpathinfo_aliases (aliases.c:171) ==22469== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==22469== by 0x955368F: internal_torture_run_test (torture.c:442) ==22469== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==22469== by 0x2600A4: run_matching (smbtorture.c:110) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x25FF66: run_matching (smbtorture.c:95) ==22469== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==22469== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 60b2298a73a0a82c4b29b071900293f8b3f8e132 Author: Noel Power <noel.po...@suse.com> Date: Fri Apr 15 12:51:32 2016 +0100 s4:lib:registry: fix 'Conditional jump or move' valgrind error. smbtorture local.registry.diff.dotreg.test_diff_apply produces the following valgrind trace ==18367== Conditional jump or move depends on uninitialised value(s) ==18367== at 0xA02ED96: reg_dotreg_diff_load (patchfile_dotreg.c:252) ==18367== by 0xA031C6C: reg_diff_load (patchfile.c:375) ==18367== by 0xA0323AB: reg_diff_apply (patchfile.c:542) ==18367== by 0x15F116: test_diff_apply (diff.c:72) ==18367== by 0x955460C: wrap_test_with_simple_test (torture.c:731) ==18367== by 0x955366F: internal_torture_run_test (torture.c:442) ==18367== by 0x9553A4B: torture_run_test_restricted (torture.c:542) ==18367== by 0x260074: run_matching (smbtorture.c:110) ==18367== by 0x25FF36: run_matching (smbtorture.c:95) ==18367== by 0x25FF36: run_matching (smbtorture.c:95) ==18367== by 0x25FF36: run_matching (smbtorture.c:95) ==18367== by 0x260195: torture_run_named_tests (smbtorture.c:143) ==18367== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 9cb4b1b24042ae1b74200d77facf536e17c6e767 Author: Noel Power <noel.po...@suse.com> Date: Fri Apr 15 15:59:08 2016 +0100 s4:torture:rpc: fix valgrind 'Syscall param writev(vector[...])' valgrind error when running smbtorture rpc.samba3.regconfig.regconfig Note: to fix this particular error only the action_taken variable needed to be initialised. ZERO-ing the structs for completeness. ==14958== Syscall param writev(vector[...]) points to uninitialised byte(s) ==14958== at 0xFB9FC87: writev (in /lib64/libc-2.19.so) ==14958== by 0x106C8003: writev_handler (async_sock.c:340) ==14958== by 0xF67407E: epoll_event_loop (tevent_epoll.c:728) ==14958== by 0xF67469C: epoll_event_loop_once (tevent_epoll.c:926) ==14958== by 0xF671586: std_event_loop_once (tevent_standard.c:114) ==14958== by 0xF66AD42: _tevent_loop_once (tevent.c:533) ==14958== by 0xF66CB9D: tevent_req_poll (tevent_req.c:256) ==14958== by 0x5D19305: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==14958== by 0x88B2DED: dcerpc_binding_handle_call (binding_handle.c:556) ==14958== by 0xBBCE851: dcerpc_winreg_CreateKey_r (ndr_winreg_c.c:1430) ==14958== by 0x3D47C5: torture_samba3_createshare (samba3rpc.c:3192) ==14958== by 0x3D50AC: torture_samba3_regconfig (samba3rpc.c:3299) ==14958== by 0x9553F42: wrap_simple_test (torture.c:632) ==14958== by 0x955366F: internal_torture_run_test (torture.c:442) ==14958== by 0x9553A4B: torture_run_test_restricted (torture.c:542) ==14958== by 0x260074: run_matching (smbtorture.c:110) ==14958== by 0x25FF36: run_matching (smbtorture.c:95) ==14958== by 0x25FF36: run_matching (smbtorture.c:95) ==14958== by 0x260195: torture_run_named_tests (smbtorture.c:143) ==14958== by 0x261E14: main (smbtorture.c:665) ==14958== Address 0x18868ec6 is 598 bytes inside a block of size 1,325 alloc'd ==14958== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==14958== by 0xF45EE38: __talloc_with_prefix (talloc.c:668) ==14958== by 0xF45EFF5: _talloc_pool (talloc.c:721) ==14958== by 0xF45F167: _talloc_pooled_object (talloc.c:790) ==14958== by 0xF66C664: _tevent_req_create (tevent_req.c:66) ==14958== by 0xB0D49CF: smb1cli_req_create (smbXcli_base.c:1322) ==14958== by 0xB0E1E3D: smb1cli_trans_send (smb1cli_trans.c:512) ==14958== by 0xB0ED44D: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==14958== by 0xB0EC817: tstream_smbXcli_np_writev_write_next (tstream_smbXcli_np.c:578) ==14958== by 0xB0EC4A7: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==14958== by 0xC259DDA: tstream_writev_send (tsocket.c:695) ==14958== by 0xC25AD44: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==14958== by 0xF66BF73: tevent_queue_immediate_trigger (tevent_queue.c:149) ==14958== by 0xF66BBFB: tevent_common_loop_immediate (tevent_immediate.c:135) ==14958== by 0xF674602: epoll_event_loop_once (tevent_epoll.c:907) ==14958== by 0xF671586: std_event_loop_once (tevent_standard.c:114) ==14958== by 0xF66AD42: _tevent_loop_once (tevent.c:533) ==14958== by 0xF66CB9D: tevent_req_poll (tevent_req.c:256) ==14958== by 0x5D19305: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==14958== by 0x88B2DED: dcerpc_binding_handle_call (binding_handle.c:556) ==14958== by 0xBBCE851: dcerpc_winreg_CreateKey_r (ndr_winreg_c.c:1430) ==14958== by 0x3D47C5: torture_samba3_createshare (samba3rpc.c:3192) ==14958== by 0x3D50AC: torture_samba3_regconfig (samba3rpc.c:3299) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit c901d98d6e6aa5444c3427d8b7cc559aa9279cdc Author: Noel Power <noel.po...@suse.com> Date: Fri Apr 15 16:15:54 2016 +0100 s4:torture:rpc: fix valgrind 'Syscall param writev(vector[...])' error running smbtorture test rpc.samba3.winreg.winreg yields the following valgrind trace ==18533== Syscall param writev(vector[...]) points to uninitialised byte(s) ==18533== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==18533== by 0x106CB033: writev_handler (async_sock.c:340) ==18533== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18533== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18533== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==18533== by 0xF673ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==18533== by 0x5D19325: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==18533== by 0x88B2E0D: dcerpc_binding_handle_call (binding_handle.c:556) ==18533== by 0xBBD049F: dcerpc_winreg_EnumValue_r (ndr_winreg_c.c:2354) ==18533== by 0x3D3E3E: enumvalues (samba3rpc.c:2982) ==18533== by 0x3D40A5: enumkeys (samba3rpc.c:3042) ==18533== by 0x3D4085: enumkeys (samba3rpc.c:3041) ==18533== Address 0x1886edd6 is 598 bytes inside a block of size 1,325 alloc'd ==18533== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18533== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==18533== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==18533== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==18533== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==18533== by 0xB0ED47D: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==18533== by 0xB0EC847: tstream_smbXcli_np_writev_write_next (tstream_smbXcli_np.c:578) ==18533== by 0xB0EC4D7: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==18533== by 0xC259DFA: tstream_writev_send (tsocket.c:695) ==18533== by 0xC25AD64: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==18533== by 0xF673023: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.26) ==18533== by 0xF677EED: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18533== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 9e8d748db3a0d65f888ce9ea150def2a3a00dd02 Author: Noel Power <noel.po...@suse.com> Date: Fri Apr 15 16:30:52 2016 +0100 s4:torture:rpc: fix valgrind Syscall param writev(vector[...]) error running smbtorture rpc.srvsvc.srvsvc\ (admin\ access).NetDiskEnum results in the following valgrind trace ==30237== Syscall param writev(vector[...]) points to uninitialised byte(s) ==30237== at 0xDD01C67: writev (in /lib64/libc-2.19.so) ==30237== by 0xE1D09D4: writev_handler (async_sock.c:340) ==30237== by 0xD81A12A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30237== by 0xD8185F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30237== by 0xD8147FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==30237== by 0xD815ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==30237== by 0x5AC726D: tevent_req_poll_ntstatus (in /usr/lib64/libtevent-util.so.0.0.1) ==30237== by 0x8120CEA: dcerpc_binding_handle_call (in /usr/lib64/libdcerpc-binding.so.0.0.1) ==30237== by 0xA9AC6EC: dcerpc_srvsvc_NetDiskEnum_r (ndr_srvsvc_c.c:5388) ==30237== by 0x2ADDF8: ??? (in /usr/bin/smbtorture) ==30237== by 0x898DF8C: ??? (in /usr/lib64/libtorture.so.0.0.1) ==30237== by 0x1F0816: ??? (in /usr/bin/smbtorture) ==30237== Address 0x15952676 is 598 bytes inside a block of size 1,325 alloc'd ==30237== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30237== by 0xCCCAA73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==30237== by 0xD81566D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==30237== by 0xA2B7910: smb1cli_req_create (smbXcli_base.c:1322) ==30237== by 0xA2BA4E3: smb1cli_trans_send (smb1cli_trans.c:512) ==30237== by 0xA2C1F91: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==30237== by 0xA2C23AE: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==30237== by 0xAC8E43C: tstream_writev_send (tsocket.c:695) ==30237== by 0xAC8E9BA: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==30237== by 0xD815023: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.26) Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 409cd516ca4faf0a7305a917d93d72a81b80bc9c Author: Noel Power <noel.po...@suse.com> Date: Fri Apr 15 16:22:02 2016 +0100 s4:libnet: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture rpc.dfs.netdfs.StdRoot yields the following valgrind trace ==18861== Syscall param writev(vector[...]) points to uninitialised byte(s) ==18861== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==18861== by 0x106CB033: writev_handler (async_sock.c:340) ==18861== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF673ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0x5D19325: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==18861== by 0x88B2E0D: dcerpc_binding_handle_call (binding_handle.c:556) ==18861== by 0xBC6D0D2: dcerpc_srvsvc_NetShareDel_r (ndr_srvsvc_c.c:4272) ==18861== by 0x9786C0C: libnet_DelShare (libnet_share.c:195) ==18861== by 0x2E0174: test_NetShareDel (dfs.c:103) ==18861== by 0x2E126F: test_cleanup_stdroot (dfs.c:488) ==18861== Address 0x18869b46 is 598 bytes inside a block of size 1,325 alloc'd ==18861== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18861== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==18861== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==18861== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==18861== by 0xB0ED47D: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==18861== by 0xB0EC847: tstream_smbXcli_np_writev_write_next (tstream_smbXcli_np.c:578) ==18861== by 0xB0EC4D7: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==18861== by 0xC259DFA: tstream_writev_send (tsocket.c:695) ==18861== by 0xC25AD64: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==18861== by 0xF673023: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF677EED: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Volker Lendecke <v...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit fcf2cbb0957595c09e69abdeaab59e800d4ce37b Author: Ralph Boehme <s...@samba.org> Date: Sun Apr 24 07:44:12 2016 +0200 selftest/samba4.blackbox.export.keytab: check AS-REQ with SPN Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 20dc68050df7b1b0c9d06f8251183a0a6283fcaf Author: Ralph Boehme <s...@samba.org> Date: Sun Apr 24 07:39:25 2016 +0200 s4/heimdal: allow SPNs in AS-REQ This allows testing keytabs with service tickets. Windows KDCs allow this as well. Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 957741ce65f56e7f1a76111a7de1c4f00a7659f7 Author: Ralph Boehme <s...@samba.org> Date: Fri Apr 22 23:59:12 2016 +0200 selftest/samba4.blackbox.export.keytab: check exported keytabs Now that we have a usable ktutil, actually verify that the exported keytabs contains the keys we expect. Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 5927e46000a0ca0f6405bdba5fd89e566c96c8fa Author: Ralph Boehme <s...@samba.org> Date: Fri Apr 22 16:38:01 2016 +0200 selftest/samba4.blackbox.export.keytab: use spn based on fqdn Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 3116e8d3beaba0b28d0226fcc7625783e6b32694 Author: Ralph Boehme <s...@samba.org> Date: Fri Apr 22 22:05:54 2016 +0200 s4: add a minimal ktutil for selftest This minimalistic version of ktutil dumps all principal names and encryption types from a keytab, eg: ./bin/samba4ktutil test.keytab ktpassu...@hillhouse.site (arcfour-hmac-md5) ktpassu...@hillhouse.site (aes256-cts-hmac-sha1-96) ktpassu...@hillhouse.site (aes128-cts-hmac-sha1-96) ktpassu...@hillhouse.site (des-cbc-md5) ktpassu...@hillhouse.site (des-cbc-crc) This is all we need to run some tests against keytabs exported with `samba-tool domain exportkeytab`. Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit deab6c6df76180f875c411c3f6b1a9cf6696b88c Author: Ralph Boehme <s...@samba.org> Date: Sun Apr 17 16:28:00 2016 +0200 s4/libnet: fix exporting to keytab by SPN Fix a regression introduced by 5c5d586d3ebd40 that broke exporting service principals by their spn with samba-tool exportkeytab --principal=<SPN>. Iterating with samba_kdc_nextkey() only returns UPNs, so this can't work with SPNs. If we want to search for a specific SPN, we have to use samba_kdc_fetch(). Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit 35b2fb4ff3252a8fc340c8d7278314c7a0f6f894 Author: Ralph Boehme <s...@samba.org> Date: Thu Apr 21 20:55:36 2016 +0200 krb5_wrap: fix keep_old_entries logic in smb_krb5_kt_seek_and_delete_old_entries() This fixes an regression introduced in 5c5d586d3ebd40 at a higher level in the caller smb_krb5_kt_add_entry(): calling smb_krb5_kt_add_entry with keep_old_entries=false resulted in only one enctype per principal remaining in the exported keytab. The function smb_krb5_kt_seek_and_delete_old_entries() is called from smb_krb5_kt_add_entry() when adding keys to a keytab. When the keytab contains keys with the same kvno as the key to be added and keep_old_entries is false, the key is deleted without checking the encryption type of the key. This means that when adding keys for a principal only the last enctype will be in the exported keytab. Fix this by checking the encryption type and only treat a key as "old" if keytab_key_kvno <= new_key_kvno and keytab_key_enctype == new_key_enctype. Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> commit b26ae7fbf66b4d79efc7a49164f93011d963333b Author: Ralph Boehme <s...@samba.org> Date: Thu Apr 21 20:54:12 2016 +0200 krb5_wrap: add enctype arg to smb_krb5_kt_seek_and_delete_old_entries() Unused in this commit, the next commit will use it to avoid deleting keys with the same kvno but a different enctype. Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> ----------------------------------------------------------------------- Summary of changes: lib/krb5_wrap/krb5_samba.c | 14 +++ lib/krb5_wrap/krb5_samba.h | 1 + source3/libads/kerberos_keytab.c | 1 + source4/heimdal/kdc/kerberos5.c | 6 +- source4/kdc/ktutil.c | 122 +++++++++++++++++++++++ source4/kdc/wscript_build | 5 + source4/lib/registry/patchfile_dotreg.c | 2 +- source4/libcli/cliconnect.c | 5 +- source4/libnet/libnet_export_keytab.c | 39 +++++--- source4/libnet/libnet_share.c | 1 + source4/torture/basic/aliases.c | 8 +- source4/torture/basic/attr.c | 3 +- source4/torture/basic/misc.c | 2 +- source4/torture/libnet/domain.c | 2 + source4/torture/libnet/libnet_share.c | 4 + source4/torture/raw/acls.c | 2 + source4/torture/raw/offline.c | 3 + source4/torture/raw/open.c | 4 + source4/torture/raw/streams.c | 2 + source4/torture/raw/tconrate.c | 2 +- source4/torture/rpc/dsgetinfo.c | 5 +- source4/torture/rpc/samba3rpc.c | 8 +- source4/torture/rpc/srvsvc.c | 1 + source4/torture/smb2/create.c | 2 + source4/torture/smb2/notify.c | 2 + source4/torture/smb2/oplock.c | 9 +- source4/torture/smb2/streams.c | 18 ++++ source4/torture/vfs/fruit.c | 8 ++ testprogs/blackbox/test_export_keytab_heimdal.sh | 40 +++++++- 29 files changed, 288 insertions(+), 33 deletions(-) create mode 100644 source4/kdc/ktutil.c Changeset truncated at 500 lines: diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c index 247b83b..d1e60eb 100644 --- a/lib/krb5_wrap/krb5_samba.c +++ b/lib/krb5_wrap/krb5_samba.c @@ -1485,6 +1485,7 @@ krb5_error_code smb_krb5_keytab_name(TALLOC_CTX *mem_ctx, krb5_error_code smb_krb5_kt_seek_and_delete_old_entries(krb5_context context, krb5_keytab keytab, krb5_kvno kvno, + krb5_enctype enctype, const char *princ_s, krb5_principal princ, bool flush, @@ -1518,6 +1519,8 @@ krb5_error_code smb_krb5_kt_seek_and_delete_old_entries(krb5_context context, DEBUG(3, (__location__ ": Will try to delete old keytab entries\n")); while (!krb5_kt_next_entry(context, keytab, &kt_entry, &cursor)) { bool name_ok = false; + krb5_enctype kt_entry_enctype = + smb_get_enctype_from_kt_entry(&kt_entry); if (!flush && (princ_s != NULL)) { ret = smb_krb5_unparse_name(tmp_ctx, context, @@ -1587,6 +1590,16 @@ krb5_error_code smb_krb5_kt_seek_and_delete_old_entries(krb5_context context, continue; } + if (!flush && + (kt_entry.vno == kvno) && + (kt_entry_enctype != enctype)) + { + DEBUG(5, (__location__ ": Saving entry with kvno [%d] " + "enctype [%d] for principal: %s.\n", + kvno, kt_entry_enctype, princ_s)); + continue; + } + DEBUG(5, (__location__ ": Found old entry for principal: %s " "(kvno %d) - trying to remove it.\n", princ_s, kt_entry.vno)); @@ -1694,6 +1707,7 @@ krb5_error_code smb_krb5_kt_add_entry(krb5_context context, ret = smb_krb5_kt_seek_and_delete_old_entries(context, keytab, kvno, + enctype, princ_s, princ, false, diff --git a/lib/krb5_wrap/krb5_samba.h b/lib/krb5_wrap/krb5_samba.h index f198d72..15da9a1 100644 --- a/lib/krb5_wrap/krb5_samba.h +++ b/lib/krb5_wrap/krb5_samba.h @@ -193,6 +193,7 @@ krb5_error_code smb_krb5_keytab_name(TALLOC_CTX *mem_ctx, krb5_error_code smb_krb5_kt_seek_and_delete_old_entries(krb5_context context, krb5_keytab keytab, krb5_kvno kvno, + krb5_enctype enctype, const char *princ_s, krb5_principal princ, bool flush, diff --git a/source3/libads/kerberos_keytab.c b/source3/libads/kerberos_keytab.c index 340e552..8a3363c 100644 --- a/source3/libads/kerberos_keytab.c +++ b/source3/libads/kerberos_keytab.c @@ -280,6 +280,7 @@ int ads_keytab_flush(ADS_STRUCT *ads) ret = smb_krb5_kt_seek_and_delete_old_entries(context, keytab, kvno, + KRB5_ENCTYPE_NULL, NULL, NULL, true, diff --git a/source4/heimdal/kdc/kerberos5.c b/source4/heimdal/kdc/kerberos5.c index 7e7aefd..3762abe 100644 --- a/source4/heimdal/kdc/kerberos5.c +++ b/source4/heimdal/kdc/kerberos5.c @@ -762,9 +762,9 @@ kdc_check_flags(krb5_context context, return KRB5KDC_ERR_POLICY; } - if(!client->flags.client){ + if (!is_as_req && !client->flags.client){ kdc_log(context, config, 0, - "Principal may not act as client -- %s", client_name); + "Principal may only act as client in AS-REQ -- %s", client_name); return KRB5KDC_ERR_POLICY; } @@ -1055,7 +1055,7 @@ _kdc_as_rep(krb5_context context, */ ret = _kdc_db_fetch(context, config, client_princ, - HDB_F_GET_CLIENT | flags, NULL, + HDB_F_GET_ANY | flags, NULL, &clientdb, &client); if(ret == HDB_ERR_NOT_FOUND_HERE) { kdc_log(context, config, 5, "client %s does not have secrets at this KDC, need to proxy", client_name); diff --git a/source4/kdc/ktutil.c b/source4/kdc/ktutil.c new file mode 100644 index 0000000..2fcd79a --- /dev/null +++ b/source4/kdc/ktutil.c @@ -0,0 +1,122 @@ +/* + Unix SMB/CIFS implementation. + + Minimal ktutil for selftest + + Copyright (C) Ralph Boehme <s...@samba.org> 2016 + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. +*/ + +#include "includes.h" +#include "krb5_wrap/krb5_samba.h" + +static void smb_krb5_err(TALLOC_CTX *mem_ctx, + krb5_context context, + int exit_code, + krb5_error_code code, + const char *msg) +{ + char *krb5_err_str = smb_get_krb5_error_message(context, + code, + mem_ctx); + printf("%s: %s\n", msg, krb5_err_str ? krb5_err_str : "UNKOWN"); + + talloc_free(mem_ctx); + exit(exit_code); +} + +int main (int argc, char **argv) +{ + TALLOC_CTX *mem_ctx = talloc_init("ktutil"); + krb5_context context; + krb5_keytab keytab; + krb5_kt_cursor cursor; + krb5_keytab_entry entry; + krb5_error_code ret; + char *keytab_name = NULL; + + if (mem_ctx == NULL) { + printf("talloc_init() failed\n"); + exit(1); + } + + if (argc != 2) { + printf("Usage: %s KEYTAB\n", argv[0]); + exit(1); + } + + keytab_name = argv[1]; + + initialize_krb5_error_table(); + + ret = krb5_init_context(&context); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "krb5_context"); + } + + ret = smb_krb5_open_keytab_relative(context, keytab_name, false, &keytab); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "open keytab"); + } + + ret = krb5_kt_start_seq_get(context, keytab, &cursor); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "krb5_kt_start_seq_get"); + } + + for (ret = krb5_kt_next_entry(context, keytab, &entry, &cursor); + ret == 0; + ret = krb5_kt_next_entry(context, keytab, &entry, &cursor)) + { + char *principal = NULL; + char *enctype_str = NULL; + krb5_enctype enctype = smb_get_enctype_from_kt_entry(&entry); + + ret = smb_krb5_unparse_name(mem_ctx, + context, + entry.principal, + &principal); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "krb5_enctype_to_string"); + } + + ret = smb_krb5_enctype_to_string(context, + enctype, + &enctype_str); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "krb5_enctype_to_string"); + } + + printf("%s (%s)\n", principal, enctype_str); + + TALLOC_FREE(principal); + SAFE_FREE(enctype_str); + smb_krb5_kt_free_entry(context, &entry); + } + + ret = krb5_kt_end_seq_get(context, keytab, &cursor); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "krb5_kt_end_seq_get"); + } + + ret = krb5_kt_close(context, keytab); + if (ret) { + smb_krb5_err(mem_ctx, context, 1, ret, "krb5_kt_close"); + } + + krb5_free_context(context); + talloc_free(mem_ctx); + return 0; +} diff --git a/source4/kdc/wscript_build b/source4/kdc/wscript_build index 3c9c77b..f0662e5 100755 --- a/source4/kdc/wscript_build +++ b/source4/kdc/wscript_build @@ -122,4 +122,9 @@ bld.SAMBA_SUBSYSTEM('MIT_SAMBA', ''', enabled=(not bld.CONFIG_SET('SAMBA4_USES_HEIMDAL') and bld.CONFIG_SET('HAVE_KDB_H')) ) +bld.SAMBA_BINARY('samba4ktutil', + 'ktutil.c', + deps='krb5samba', + install=False) + bld.RECURSE('mit-kdb') diff --git a/source4/lib/registry/patchfile_dotreg.c b/source4/lib/registry/patchfile_dotreg.c index f537b97..49f71f9 100644 --- a/source4/lib/registry/patchfile_dotreg.c +++ b/source4/lib/registry/patchfile_dotreg.c @@ -249,7 +249,7 @@ _PUBLIC_ WERROR reg_dotreg_diff_load(int fd, while ((line = afdgets(fd, mem_ctx, 0))) { /* Remove '\r' if it's a Windows text file */ - if (line[strlen(line)-1] == '\r') { + if (strlen(line) && line[strlen(line)-1] == '\r') { line[strlen(line)-1] = '\0'; } diff --git a/source4/libcli/cliconnect.c b/source4/libcli/cliconnect.c index 35d963e..58118b0 100644 --- a/source4/libcli/cliconnect.c +++ b/source4/libcli/cliconnect.c @@ -142,13 +142,16 @@ NTSTATUS smbcli_tconX(struct smbcli_state *cli, const char *sharename, tcon.tconx.in.device = devtype; status = smb_raw_tcon(cli->tree, mem_ctx, &tcon); - + if (!NT_STATUS_IS_OK(status)) { + goto out; + } cli->tree->tid = tcon.tconx.out.tid; if (tcon.tconx.out.options & SMB_EXTENDED_SIGNATURES) { smb1cli_session_protect_session_key(cli->tree->session->smbXcli); } +out: talloc_free(mem_ctx); return status; diff --git a/source4/libnet/libnet_export_keytab.c b/source4/libnet/libnet_export_keytab.c index ee2c470..8bceecc 100644 --- a/source4/libnet/libnet_export_keytab.c +++ b/source4/libnet/libnet_export_keytab.c @@ -56,10 +56,27 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx, goto done; } - for (code = samba_kdc_firstkey(context, db_ctx, &sentry); - code == 0; - code = samba_kdc_nextkey(context, db_ctx, &sentry)) { - bool principal_found = false; + if (copy_one_principal) { + krb5_principal k5_princ; + + code = smb_krb5_parse_name(context, principal, &k5_princ); + if (code != 0) { + *error_string = smb_get_krb5_error_message(context, + code, + mem_ctx); + status = NT_STATUS_UNSUCCESSFUL; + goto done; + } + + code = samba_kdc_fetch(context, db_ctx, k5_princ, + SDB_F_GET_ANY, 0, &sentry); + + krb5_free_principal(context, k5_princ); + } else { + code = samba_kdc_firstkey(context, db_ctx, &sentry); + } + + for (; code == 0; code = samba_kdc_nextkey(context, db_ctx, &sentry)) { int i; code = krb5_unparse_name(context, @@ -73,17 +90,7 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx, goto done; } - if (principal != NULL) { - int cmp; - - cmp = strcmp(principal, entry_principal); - if (cmp == 0) { - principal_found = true; - } - } - - if (sentry.entry.keys.len == 0 || - (copy_one_principal && !principal_found)) { + if (sentry.entry.keys.len == 0) { SAFE_FREE(entry_principal); sdb_free_entry(&sentry); sentry = (struct sdb_entry_ex) { @@ -123,7 +130,7 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx, } } - if (principal_found) { + if (copy_one_principal) { break; } diff --git a/source4/libnet/libnet_share.c b/source4/libnet/libnet_share.c index 7c9121b..d8e8240 100644 --- a/source4/libnet/libnet_share.c +++ b/source4/libnet/libnet_share.c @@ -175,6 +175,7 @@ NTSTATUS libnet_DelShare(struct libnet_context *ctx, struct srvsvc_NetShareDel s; ZERO_STRUCT(c); + ZERO_STRUCT(s); c.level = LIBNET_RPC_CONNECT_SERVER; c.in.name = r->in.server_name; diff --git a/source4/torture/basic/aliases.c b/source4/torture/basic/aliases.c index acd33a4..ee3ea50 100644 --- a/source4/torture/basic/aliases.c +++ b/source4/torture/basic/aliases.c @@ -150,6 +150,7 @@ static bool qpathinfo_aliases(struct torture_context *tctx, struct smbcli_state const char *fname = "\\qpathinfo_aliases.txt"; int fnum; + ZERO_STRUCT(t2); t2.in.max_param = 2; t2.in.max_data = UINT16_MAX; t2.in.max_setup = 0; @@ -159,7 +160,6 @@ static bool qpathinfo_aliases(struct torture_context *tctx, struct smbcli_state t2.in.setup = &setup; t2.in.params = data_blob_talloc_zero(tctx, 6); t2.in.data = data_blob(NULL, 0); - ZERO_STRUCT(t2.out); smbcli_unlink(cli->tree, fname); fnum = create_complex_file(cli, cli, fname); @@ -192,6 +192,7 @@ static bool findfirst_aliases(struct torture_context *tctx, struct smbcli_state const char *fname = "\\findfirst_aliases.txt"; int fnum; + ZERO_STRUCT(t2); t2.in.max_param = 16; t2.in.max_data = UINT16_MAX; t2.in.max_setup = 0; @@ -201,7 +202,6 @@ static bool findfirst_aliases(struct torture_context *tctx, struct smbcli_state t2.in.setup = &setup; t2.in.params = data_blob_talloc_zero(tctx, 12); t2.in.data = data_blob(NULL, 0); - ZERO_STRUCT(t2.out); smbcli_unlink(cli->tree, fname); fnum = create_complex_file(cli, cli, fname); @@ -306,6 +306,7 @@ static bool setfileinfo_aliases(struct torture_context *tctx, struct smbcli_stat const char *fname = "\\setfileinfo_aliases.txt"; int fnum; + ZERO_STRUCT(t2); t2.in.max_param = 2; t2.in.max_data = 0; t2.in.max_setup = 0; @@ -315,7 +316,6 @@ static bool setfileinfo_aliases(struct torture_context *tctx, struct smbcli_stat t2.in.setup = &setup; t2.in.params = data_blob_talloc_zero(tctx, 6); t2.in.data = data_blob(NULL, 0); - ZERO_STRUCT(t2.out); smbcli_unlink(cli->tree, fname); fnum = create_complex_file(cli, cli, fname); @@ -345,6 +345,7 @@ static bool setpathinfo_aliases(struct torture_context *tctx, const char *fname = "\\setpathinfo_aliases.txt"; int fnum; + ZERO_STRUCT(t2); t2.in.max_param = 32; t2.in.max_data = UINT16_MAX; t2.in.max_setup = 0; @@ -354,7 +355,6 @@ static bool setpathinfo_aliases(struct torture_context *tctx, t2.in.setup = &setup; t2.in.params = data_blob_talloc_zero(tctx, 4); t2.in.data = data_blob(NULL, 0); - ZERO_STRUCT(t2.out); smbcli_unlink(cli->tree, fname); diff --git a/source4/torture/basic/attr.c b/source4/torture/basic/attr.c index 8d51fa3..9eb9ec8 100644 --- a/source4/torture/basic/attr.c +++ b/source4/torture/basic/attr.c @@ -198,7 +198,8 @@ bool torture_winattrtest(struct torture_context *tctx, union smb_fileinfo query, query_org; NTSTATUS status; struct security_descriptor *sd1, *sd2; - + ZERO_STRUCT(query); + ZERO_STRUCT(query_org); /* Test winattrs for file */ smbcli_unlink(cli1->tree, fname); diff --git a/source4/torture/basic/misc.c b/source4/torture/basic/misc.c index 4e84e38..cbf1e9f 100644 --- a/source4/torture/basic/misc.c +++ b/source4/torture/basic/misc.c @@ -284,7 +284,7 @@ bool torture_holdopen(struct torture_context *tctx, while (1) { struct smb_echo ec; - + ZERO_STRUCT(ec); status = smb_raw_echo(cli->transport, &ec); torture_comment(tctx, "."); fflush(stdout); diff --git a/source4/torture/libnet/domain.c b/source4/torture/libnet/domain.c index 71753de..c1cfc91 100644 --- a/source4/torture/libnet/domain.c +++ b/source4/torture/libnet/domain.c @@ -33,6 +33,8 @@ static bool test_domainopen(struct torture_context *tctx, NTSTATUS status; struct libnet_DomainOpen io; + ZERO_STRUCT(io); + torture_comment(tctx, "opening domain\n"); io.in.domain_name = talloc_strdup(mem_ctx, domname->string); diff --git a/source4/torture/libnet/libnet_share.c b/source4/torture/libnet/libnet_share.c index b9e969f..3c50883 100644 --- a/source4/torture/libnet/libnet_share.c +++ b/source4/torture/libnet/libnet_share.c @@ -176,6 +176,10 @@ static bool test_addshare(struct torture_context *tctx, union srvsvc_NetShareInfo info; struct srvsvc_NetShareInfo2 i; + ZERO_STRUCT(i); + ZERO_STRUCT(info); + ZERO_STRUCT(add); + i.name = share; i.type = STYPE_DISKTREE; i.path = "C:\\WINDOWS\\TEMP"; diff --git a/source4/torture/raw/acls.c b/source4/torture/raw/acls.c index 360d937..dfeb13d 100644 --- a/source4/torture/raw/acls.c +++ b/source4/torture/raw/acls.c @@ -238,6 +238,8 @@ static bool test_nttrans_create_ext(struct torture_context *tctx, NTSTATUS (*delete_func)(struct smbcli_tree *, const char *) = test_dir ? smbcli_rmdir : smbcli_unlink; + ZERO_STRUCT(ace); + if (!torture_setup_dir(cli, BASEDIR)) return false; diff --git a/source4/torture/raw/offline.c b/source4/torture/raw/offline.c index 85b1235..9391b09 100644 --- a/source4/torture/raw/offline.c +++ b/source4/torture/raw/offline.c @@ -93,6 +93,7 @@ static void loadfile_callback(struct composite_context *ctx) printf("Failed to read file '%s' - %s\n", state->loadfile->in.fname, nt_errstr(status)); test_failed++; + return; } /* check the data is correct */ @@ -184,6 +185,8 @@ static void getoffline_callback(struct smbcli_request *req) NTSTATUS status; union smb_fileinfo io; -- Samba Shared Repository