The branch, master has been updated via 8267ec2 s4-kdc: Do not leak memory on error in kpasswd_make_error_reply() from 7a0ff3b unix_msg: add a test for dgram socket caching
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 8267ec209a6c588f48e6e8d37d4d7a9cae7a2cb3 Author: Andreas Schneider <a...@samba.org> Date: Tue Sep 13 10:25:07 2016 +0200 s4-kdc: Do not leak memory on error in kpasswd_make_error_reply() CID 1372874 Signed-off-by: Andreas Schneider <a...@samba.org> Reviewed-by: Jeremy Allison <j...@samba.org> Autobuild-User(master): Jeremy Allison <j...@samba.org> Autobuild-Date(master): Tue Sep 13 22:13:31 CEST 2016 on sn-devel-144 ----------------------------------------------------------------------- Summary of changes: source4/kdc/kpasswd-helper.c | 2 ++ 1 file changed, 2 insertions(+) Changeset truncated at 500 lines: diff --git a/source4/kdc/kpasswd-helper.c b/source4/kdc/kpasswd-helper.c index 996b318..6de2837 100644 --- a/source4/kdc/kpasswd-helper.c +++ b/source4/kdc/kpasswd-helper.c @@ -54,11 +54,13 @@ bool kpasswd_make_error_reply(TALLOC_CTX *mem_ctx, */ #ifndef SAMBA4_USES_HEIMDAL if (slen < 2) { + talloc_free(s); return false; } slen -= 2; #endif if (2 + slen < slen) { + talloc_free(s); return false; } error_data->length = 2 + slen; -- Samba Shared Repository