The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree.
The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-07-31-1947/flakey.log The failure seems to be in the "samba" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-07-31-1947/samba.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2018-07-31-1947/samba.stdout The top commit at the time of the failure was: commit 8dac16e82d04a64d8dee42285fe3fd32cc26f0af Author: Stefan Metzmacher <me...@samba.org> Date: Tue Jul 31 09:45:00 2018 +0200 smb2_query_directory: make 'return true' explicit in smb2_query_directory_next_entry() 'return req' should do the same as 'return true' for a bool function, it's implicitly expanded as 'return (req!=NULL)?true:false. There's no point in that as 'req' is always a valid pointer. This was most likely just a copy and paste bug. So we make this explicit now and avoid that Coverity reports this: CID 1438158: Null pointer dereferences (REVERSE_INULL) Null-checking "req" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Signed-off-by: Stefan Metzmacher <me...@samba.org> Reviewed-by: Volker Lendecke <v...@samba.org> Autobuild-User(master): Volker Lendecke <v...@samba.org> Autobuild-Date(master): Tue Jul 31 14:20:49 CEST 2018 on sn-devel-144 and the last 50 lines of the stdout log were: [815(5032)/897 at 1h17m22s] samba4.rpc.echo(rodc) [816(5042)/897 at 1h17m26s] samba4.rpc.echo(rodc:local) [817(5052)/897 at 1h17m30s] samba4.rpc.echo.testallowed(rodc:local) [818(5062)/897 at 1h17m33s] samba4.rpc.echo.testdenied(rodc:local) [819(5072)/897 at 1h17m36s] samba4.blackbox.smbclient(rodc:local)(rodc:local) [820(5074)/897 at 1h17m37s] samba4.rpc.echo(restoredc) [821(5084)/897 at 1h17m41s] samba4.rpc.echo(restoredc:local) [822(5094)/897 at 1h17m44s] samba4.rpc.echo.testallowed(restoredc:local) [823(5104)/897 at 1h17m48s] samba4.rpc.echo.testdenied(restoredc:local) [824(5114)/897 at 1h17m51s] samba4.blackbox.smbclient(restoredc:local)(restoredc:local) [825(5116)/897 at 1h17m51s] samba4.rpc.echo(renamedc) [826(5126)/897 at 1h17m55s] samba4.rpc.echo(renamedc:local) [827(5136)/897 at 1h17m59s] samba4.rpc.echo.testallowed(renamedc:local) [828(5146)/897 at 1h18m2s] samba4.rpc.echo.testdenied(renamedc:local) [829(5156)/897 at 1h18m5s] samba4.blackbox.smbclient(renamedc:local)(renamedc:local) [830(5158)/897 at 1h18m6s] samba4.rpc.echo(labdc) [831(5168)/897 at 1h18m9s] samba4.rpc.echo(labdc:local) [832(5178)/897 at 1h18m13s] samba4.rpc.echo.testallowed(labdc:local) [833(5188)/897 at 1h18m13s] samba4.rpc.echo.testdenied(labdc:local) [834(5198)/897 at 1h18m13s] samba4.blackbox.smbclient(labdc:local)(labdc:local) [835(5200)/897 at 1h18m14s] samba.tests.samba_tool.rodc(rodc:local) [836(5209)/897 at 1h18m43s] samba.blackbox.rpcclient_samlogon(rodc:local) [837(5213)/897 at 1h18m44s] samba.blackbox.rpcclient_samlogon_testallowed(rodc:local) [838(5217)/897 at 1h18m45s] samba.blackbox.rpcclient_samlogon_testdenied(rodc:local) [839(5221)/897 at 1h18m45s] samba4.drs.ridalloc_exop.python(vampire_dc)(vampire_dc) [840(5232)/897 at 1h24m5s] samba4.drs.samba_tool_drs.python(vampire_dc)(vampire_dc:local) [841(5246)/897 at 1h27m21s] samba4.drs.samba_tool_drs_showrepl.python(vampire_dc)(vampire_dc:local) Good, failed as expected after 0 rounds: '/memdisk/autobuild/fl/b2047065/samba/bin/samba-tool drs showrepl --summary -v --color=yes localvampiredc -USAMBADOMAIN/Administrator%locDCpass1' UNEXPECTED(failure): samba4.drs.samba_tool_drs_showrepl.python(vampire_dc).samba_tool_drs_showrepl.SambaToolDrsShowReplTests.test_samba_tool_showrepl_summary_forced_failure(vampire_dc:local) REASON: Exception: Exception: Traceback (most recent call last): File "/memdisk/autobuild/fl/b2047065/samba/source4/torture/drs/python/samba_tool_drs_showrepl.py", line 314, in test_samba_tool_showrepl_summary_forced_failure self.assertIn('There are failing connections', e.stdout) AssertionError: 'There are failing connections' not found in '' FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba4.ldap.rodc_rwdc.python(rodc)(rodc:local) -> 437 samba4.drs.ridalloc_exop.python(vampire_dc)(vampire_dc) -> 320 samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 231 samba4.rpc.samr.passwords.lockout on ncacn_np with (ad_dc_ntvfs) -> 226 samba4.rpc.samr.passwords.pwdlastset on ncacn_np with (ad_dc_ntvfs) -> 200 samba4.drs.samba_tool_drs.python(vampire_dc)(vampire_dc:local) -> 196 samba4.ldap.password_lockout.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 166 samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 137 samba4.ldap.secdesc.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 114 samba4.raw.notify(ad_dc_ntvfs) -> 106 ERROR: test failed with exit code 1