Hi Alexander, On Wed, Sep 5, 2018 at 6:41 PM, Alexander Bokovoy <a...@samba.org> wrote: > On ke, 05 syys 2018, Andrew Bartlett wrote: >> The branch, master has been updated >> via 8de348e third_party: Import exact files from waf-2.0.8/waflib >> via 8f022a0 script/autobuild: Fix formatting in send_email >> via 67ed1ea script/autobuild: re-use CACHE_SUFFIX from waflib >> via 72c3ff9 buildtools/wafsamba: use CACHE_SUFFIX instead of a >> hard-coded name >> via 6fc9f1a lib/mscat: fix logging in wscript >> via 4c7c10b lib/audit_logging: update to waf 2.0 >> via f495f64 buildtools/wafsamba: remove ENFORCE_GROUP_ORDERING >> via 0a9d98b ctdb/wscript: rework how version number is retrieved >> via fdd89fe selftest/tests.py: update to support waf 2.0 >> via 72a9e6d wscript: port build_system_heimdal to waf 2.0 >> via 1efe689 wscript: port build_system_mitkrb5 to waf 2.0 >> via 7944ed6 buildtools/wafsamba: port stale_files to waf 2.0 >> via 2a3fcdf buildtools/wafsamba: generate build options output with >> waf 2.0 >> via 75d5bcb selftest/wscript: properly handle env.cwd which is a >> list, not a string >> via 31f8945 wafsamba: install Python modules back to bin/python, not >> bin/python_modules >> via 77f3a13 buildtools/wafsamba: use cflags instead of ccflags for >> waf 2.0 >> via 1d25ae5 buildtools/wafsamba: use context instead of options for >> cross-compile checks for waf 2.0 >> via aebcd69 buildtools/wafsamba: crosscompile should use >> Utils.subprocess in waf 2.0 >> via fb43723 buildtools/wafsamba: use top and out for waf 2.0 >> via 5c3d31e cdtb/wscript: use top and out for waf 2.0 >> via 699977a wscript: adopt to waf 2.0 >> via 0fdba4b buildtools/wafsamba: use top for waf 2.0 >> via cdda0d9 buildtools/wafsamba: change SAMBA_BUILD_ENV to use >> bldnode.abspath() >> via 35ebfd3 selftest/wscript: handle lists in environmental >> variables in waf >> via 2a63619 waf heimdal: use absolute path to compile_et >> via 1fdcbd0 wafsamba: use correct context for APPNAME >> via 850ceec buildtools/wafsamba: compile asn1 files by adding >> missing code from compat15 >> via 2e401d2 wscript: adopt to waf-2.0 >> via 175be93 ctdb/wscript: adopt to waf-2.0 >> via 7aaa1e6 buildtools/wafsamba/samba_abi: always_run helper was >> deprecated in waf 2.0 >> via 9f2f5b4 source3/libsmb/wscript: remove unneeded import >> via d00ba40 nsswitch/libwbclient/wscript: import from waflib >> via 944fce2 auth/wscript: import from waflib >> via 3fc4786 buildtools/wafsamba: add install_dir to build context >> via 69c655f buildtools/wafsamba: reduce imports >> via 7eab91a buildtools/wafsamba: adopt to waf 2.0.8 >> via 3b7dfc5 third_party/waf: upgrade to waf 2.0.8 >> via 79c4ba2 auth/wscript: fix options use >> via c5ab9ea heimdal wscript changes >> via ef4b2d4 wscript_configure_system_mitkrb5: update to handle waf >> 2.0.4 >> via e58ca30 wscript_build_embedded_heimdal: update to handle waf >> 2.0.4 >> via 1dc80eb wscript_build: update to handle waf 2.0.4 >> via c73b779 wscript: update to handle waf 2.0.4 >> via 0119a87 third_party/wscript: update to handle waf 2.0.4 >> via f14b8cb third_party/uid_wrapper/wscript: update to handle waf >> 2.0.4 >> via 051e7e7 third_party/socket_wrapper/wscript: update to handle waf >> 2.0.4 >> via 4c44153 third_party/resolv_wrapper/wscript: update to handle waf >> 2.0.4 >> via 7e2deed third_party/popt/wscript: update to handle waf 2.0.4 >> via 2847a38 third_party/pam_wrapper/wscript: update to handle waf >> 2.0.4 >> via 2b21e67 third_party/nss_wrapper/wscript: update to handle waf >> 2.0.4 >> via 3e71f06 third_party/cmocka/wscript: update to handle waf 2.0.4 >> via ba03d12 third_party/aesni-intel/wscript: update to handle waf >> 2.0.4 >> via ca5008a testsuite/headers/wscript_build: update to handle waf >> 2.0.4 >> via 0c423a3 source4/lib/tls/wscript: update to handle waf 2.0.4 >> via c797e92 source4/heimdal_build/wscript_configure: update to >> handle waf 2.0.4 >> via 055aae9 source4/heimdal_build/wscript_build: update to handle >> waf 2.0.4 >> via 029ac7d source4/dsdb/samdb/ldb_modules/wscript: update to handle >> waf 2.0.4 >> via 8b5ad02 source3/wscript_configure_system_ncurses: update to >> handle waf 2.0.4 >> via 91e099d source3/wscript: update to handle waf 2.0.4 >> via c898f18 source3/build/charset.py: update to handle waf 2.0.4 >> via 0de67cf selftest/wscript: update to handle waf 2.0.4 >> via fa1ca71 python/wscript: update to handle waf 2.0.4 >> via 7f6ce8f pidl/wscript: update to handle waf 2.0.4 >> via e1e5b57 packaging/wscript: update to handle waf 2.0.4 >> via 8a74116 nsswitch/wscript_build: update to handle waf 2.0.4 >> via e676183 lib/util/wscript_configure: update to handle waf 2.0.4 >> via 5f57714 lib/util/wscript: update to handle waf 2.0.4 >> via d4cef3b lib/tevent/wscript: update to handle waf 2.0.4 >> via 15288c3 lib/tdb/wscript: update to handle waf 2.0.4 >> via 62bb573 lib/talloc/wscript: update to handle waf 2.0.4 >> via ea57883 lib/replace/wscript: update to handle waf 2.0.4 >> via 0c703f1 lib/ldb/wscript: update to handle waf 2.0.4 >> via b0a12c8 lib/crypto/wscript_configure: update to handle waf 2.0.4 >> via b999fd3 lib/crypto/wscript: update to handle waf 2.0.4 >> via 18c3598 dynconfig/wscript: update to handle waf 2.0.4 >> via efa94eb docs-xml/wscript_build: update to handle waf 2.0.4 >> via 65074d8 ctdb/wscript: update to handle waf 2.0.4 >> via 4e65b33 third_party:waf: update to upstream 2.0.4 release >> via faef275 build:wafsamba: Remove unnecessary parameters to >> cmd_and_log >> via 247d12c build:wafsamba: Ignore cfg_file absolute paths >> differences >> via cbc6534 thirdparty:waf: New files for waf 1.9.10 >> via 48cf9cc selftest/tests.py: Update path to waflib >> via 5967335 script/autobuild: use --out instead of -b when calling >> configure >> via 9aa8f2b build:wafsamba: detail where we are processing the >> autobuild >> via 5d99786 build:wafsamba: Update dist/distcheck commands >> via 8077f46 build:wafsamba: Build on waf 1.9 >> from f3e349b krb5-samba: interdomain trust uses different salt >> principal >> >> https://git.samba.org/?p=samba.git;a=shortlog;h=master > Thank you, Andrew, for the reviews and persistent push to complete this! > > We are using WAF 2.x now which should allow us to concentrate on > switching to Python 3 for the build process as well for all our > libraries and components. > > If you see any build issues related to the WAF, please report them. > Autobuild succeeded but we might still have pieces of Python code that > aren't excercised through the autobuild targets.
Great job updating to the latest waf. Now fixing all the corner cases... ;-) On freebsd-11, waf does not want to use clang and complains that it cannot find a C compiler. ./configure --enable-developer Setting top to : /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11 Setting out to : /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/ctdb/bin Checking for 'gcc' (C compiler) : not found Checking for 'generic_cc' (C compiler) : not found could not configure a C compiler! (complete log in /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/ctdb/bin/config.log) Here are the lines in the config.log file: ---------------------------------------- Setting top to /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11 ---------------------------------------- Setting out to /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/ctdb/bin ---------------------------------------- Checking for 'gcc' (C compiler) find program=['gcc', 'cc'] paths=['/sbin', '/bin', '/usr/sbin', '/usr/bin', '/usr/local/sbin', '/usr/local/bin', '/usr/local/jenkins/bin'] var='CC' -> ['/usr/bin/cc'] ['/usr/bin/cc', '-dM', '-E', '-'] [lots of #defines deleted] from /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/buildtools/wafsamba: Could not find gcc/g++ (only Clang), if renamed try eg: CC=gcc48 CXX=g++48 waf configure not found ---------------------------------------- Checking for 'generic_cc' (C compiler) not found from /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/buildtools/wafsamba: could not configure a C compiler! If I try to force CC=cc, then I get some python exception: $ CC=cc ./configure --enable-developer Setting top to : /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11 Setting out to : /usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/ctdb/bin Checking for 'gcc' (C compiler) : not found Checking for 'generic_cc' (C compiler) : cc Traceback (most recent call last): File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Scripting.py", line 158, in waf_entry_point run_commands() File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Scripting.py", line 251, in run_commands ctx = run_command(cmd_name) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Scripting.py", line 235, in run_command ctx.execute() File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Configure.py", line 159, in execute super(ConfigurationContext, self).execute() File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Context.py", line 204, in execute self.recurse([os.path.dirname(g_module.root_path)]) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Context.py", line 286, in recurse user_function(self) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/ctdb/wscript", line 118, in configure conf.RECURSE('lib/replace') File "./../buildtools/wafsamba/samba_utils.py", line 30, in fun return f(*k, **kw) File "./../buildtools/wafsamba/samba_utils.py", line 433, in RECURSE return ctx.recurse(relpath) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Context.py", line 286, in recurse user_function(self) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Utils.py", line 816, in wrap ret = fun(*k) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/lib/replace/wscript", line 30, in configure conf.RECURSE('buildtools/wafsamba') File "./../buildtools/wafsamba/samba_utils.py", line 30, in fun return f(*k, **kw) File "./../buildtools/wafsamba/samba_utils.py", line 433, in RECURSE return ctx.recurse(relpath) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Context.py", line 286, in recurse user_function(self) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/third_party/waf/waflib/Utils.py", line 816, in wrap ret = fun(*k) File "/usr/local/jenkins/workspace/samba-master/label/x86_64-freebsd11/buildtools/wafsamba/wscript", line 236, in configure conf.CHECK_STANDARD_LIBPATH() File "./../buildtools/wafsamba/samba_utils.py", line 30, in fun return f(*k, **kw) File "./../buildtools/wafsamba/samba_conftests.py", line 516, in CHECK_STANDARD_LIBPATH raise Errors.WafError('Unexpected error running "%s"' % (cmd)) UnboundLocalError: local variable 'cmd' referenced before assignment Amitay.