The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree.
The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-23-0356/flakey.log The failure seems to be in the "ctdb" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-23-0356/ctdb.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-23-0356/ctdb.stdout The top commit at the time of the failure was: commit 30622ed876cffff305a9b03686edb48de987704f Author: Volker Lendecke <v...@samba.org> Date: Tue May 21 15:26:55 2019 +0200 smbd: Fix a panic Opening a file with a stale (smbd died) LEVEL_II oplock makes vfs_set_filelen-> ... ->contend_level2_oplocks_begin_default trigger the immediate leading to do_break_to_none. This goes through because fsp->oplock_type is not initialized yet, thus 0. Also, file_has_read_oplocks is still valid, because the smbd that has died could not clean up the brlock.tdb entry. Later in the code the exclusive oplock is granted, which is then found by do_break_to_none, making it panic. This patch just runs the direct FTRUNCATE instead of vfs_set_filelen. This means the contend_level2_oplock code is skipped. The relevant break (LEVEL_II to NONE) is now done in delay_for_oplock() with the nice effect of removing a comment that was very confusing to me. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13957 Signed-off-by: Volker Lendecke <v...@samba.org> Reviewed-by: Ralph Boehme <s...@samba.org> Autobuild-User(master): Ralph Böhme <s...@samba.org> Autobuild-Date(master): Wed May 22 20:09:29 UTC 2019 on sn-devel-184 and the last 50 lines of the stdout log were: PASSED tests/tool/ctdb.stop.003.sh PASSED tests/tool/ctdb.unban.001.sh PASSED tests/tool/ctdb.unban.002.sh PASSED tests/tool/ctdb.unban.003.sh PASSED tests/tool/ctdb.uptime.001.sh PASSED tests/tool/ctdb.writekey.001.sh PASSED tests/simple/00_ctdb_onnode.sh PASSED tests/simple/01_ctdb_reclock_command.sh PASSED tests/simple/02_ctdb_tunables.sh PASSED tests/simple/05_ctdb_listnodes.sh PASSED tests/simple/06_ctdb_getpid.sh PASSED tests/simple/07_ctdb_process_exists.sh PASSED tests/simple/08_ctdb_isnotrecmaster.sh PASSED tests/simple/09_ctdb_ping.sh PASSED tests/simple/11_ctdb_ip.sh PASSED tests/simple/12_ctdb_getdebug.sh PASSED tests/simple/13_ctdb_setdebug.sh PASSED tests/simple/14_ctdb_statistics.sh PASSED tests/simple/15_ctdb_statisticsreset.sh PASSED tests/simple/16_ctdb_config_add_ip.sh PASSED tests/simple/17_ctdb_config_delete_ip.sh PASSED tests/simple/18_ctdb_reloadips.sh PASSED tests/simple/19_ip_takeover_noop.sh PASSED tests/simple/20_delip_iface_gc.sh PASSED tests/simple/21_ctdb_attach.sh PASSED tests/simple/23_ctdb_moveip.sh PASSED tests/simple/24_ctdb_getdbmap.sh PASSED tests/simple/25_dumpmemory.sh PASSED tests/simple/26_ctdb_config_check_error_on_unreachable_ctdb.sh PASSED tests/simple/27_ctdb_detach.sh PASSED tests/simple/28_zero_eventscripts.sh PASSED tests/simple/32_ctdb_disable_enable.sh PASSED tests/simple/35_ctdb_getreclock.sh PASSED tests/simple/42_ctdb_stop_continue.sh PASSED tests/simple/43_stop_recmaster_yield.sh PASSED tests/simple/51_message_ring.sh PASSED tests/simple/52_fetch_ring.sh PASSED tests/simple/53_transaction_loop.sh PASSED tests/simple/54_transaction_loop_recovery.sh PASSED tests/simple/55_ctdb_ptrans.sh PASSED tests/simple/56_replicated_transaction_recovery.sh PASSED tests/simple/58_ctdb_restoredb.sh PASSED tests/simple/60_recoverd_missing_ip.sh *FAILED* tests/simple/69_recovery_resurrect_deleted.sh 516/517 tests passed Not cleaning up TEST_VAR_DIR=tests/var autotest exited with exit status 1 Makefile:22: recipe for target 'autotest' failed