The branch, master has been updated via 4171736339b lib: Stay ASCII-compatible for toupper_m/tolower_m from 79132b333d7 script: Fix check_symbols() with gcov build
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 4171736339bdff4a18b2be016415b8f87b6f383d Author: Volker Lendecke <v...@samba.org> Date: Fri Feb 18 17:36:08 2022 +0100 lib: Stay ASCII-compatible for toupper_m/tolower_m This is an alternative patch for MR2339: It seems that Windows AD in turkish locale is ASCII-compatible with 'i'. Björn tells me that the turkish locale is the only one where upper/lower casing letters in the ASCII range is not compatible to ASCII. Simplify our code by not calling the locale-specific standard toupper/tolower for the ASCII range but rely on our tables. Signed-off-by: Volker Lendecke <v...@samba.org> Reviewed-by: Alexander Bokovoy <a...@samba.org> Reviewed-by: Andreas Schneider <a...@samba.org> Autobuild-User(master): Volker Lendecke <v...@samba.org> Autobuild-Date(master): Mon Apr 4 11:45:24 UTC 2022 on sn-devel-184 ----------------------------------------------------------------------- Summary of changes: lib/util/charset/codepoints.c | 6 ------ 1 file changed, 6 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/util/charset/codepoints.c b/lib/util/charset/codepoints.c index 3f380b9fed6..c35241e2983 100644 --- a/lib/util/charset/codepoints.c +++ b/lib/util/charset/codepoints.c @@ -16441,9 +16441,6 @@ void smb_init_locale(void) **/ _PUBLIC_ codepoint_t toupper_m(codepoint_t val) { - if (val < 128) { - return toupper(val); - } if (val >= ARRAY_SIZE(upcase_table)) { return val; } @@ -16455,9 +16452,6 @@ _PUBLIC_ codepoint_t toupper_m(codepoint_t val) **/ _PUBLIC_ codepoint_t tolower_m(codepoint_t val) { - if (val < 128) { - return tolower(val); - } if (val >= ARRAY_SIZE(lowcase_table)) { return val; } -- Samba Shared Repository