The branch, v4-18-test has been updated via 14ce7756e7a python/samba: Adjust tarfile extraction filter from 96793d42907 smbd: don't leak the fsp if close_file_smb() fails
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-18-test - Log ----------------------------------------------------------------- commit 14ce7756e7a5403144126f55be1f7022374c64ea Author: Noel Power <noel.po...@suse.com> Date: Fri Jul 14 14:53:29 2023 +0100 python/samba: Adjust tarfile extraction filter The 'data_filter' is far too restrictive, this filter doesn't apply any mode bits to directories which in turn will result in unexpected directory permissions of the amongst others msg.[ls]ock directories. With 'data_filter' and a 'patched' python at best we experience CI failures with samba-ad-back1 & samba-ad-back2 CI jobs due to server startup failures, at worst user/admins will need to adjust directory permissions post backup. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15390 Signed-off-by: Noel Power <noel.po...@suse.com> Reviewed-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> (cherry picked from commit e401ae44b2f952fc2686065fbfb3a563e3d4066a) Autobuild-User(v4-18-test): Jule Anger <jan...@samba.org> Autobuild-Date(v4-18-test): Mon Jul 24 10:19:13 UTC 2023 on atb-devel-224 ----------------------------------------------------------------------- Summary of changes: python/samba/safe_tarfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/python/samba/safe_tarfile.py b/python/samba/safe_tarfile.py index 7a2b0382a79..21366178475 100644 --- a/python/samba/safe_tarfile.py +++ b/python/samba/safe_tarfile.py @@ -31,7 +31,7 @@ class TarFile(UnsafeTarFile): # New in version 3.11.4 (also has been backported) # https://docs.python.org/3/library/tarfile.html#tarfile.TarFile.extraction_filter # https://peps.python.org/pep-0706/ - extraction_filter = staticmethod(tarfile.data_filter) + extraction_filter = staticmethod(tarfile.tar_filter) except AttributeError: def extract(self, member, path="", set_attrs=True, *, numeric_owner=False): -- Samba Shared Repository