The branch, master has been updated via 269738d6ce4 lib/replace: fix strlcat/strlcpy compile for Honggfuzz via f0e0ff262ab tldap: avoid infinite loop when filter contains "\)" via 17e35c26914 fuzz: add fuzzer for ldb_comparison_fold via 019bee54c6b fuzz: add fuzzer for sess_crypt_blob via f404ef3c2aa libcli:auth:sess_crypt_blob: ensure key has 7 bytes via 5c007600dcd util/base64: add a note about zero length strings via c3ded9d9343 lib/fuzzing:fuzz_sddl_access_check fix nul-term check via 5c81f349354 lib/fuzzing: LLVMFuzzerTestOneInput() takes const uint8_t* via 43b44827d63 s4:torture: Fix code spelling via 3ec0c61c4d3 s4:smb_server: Fix code spelling via d61c3684c59 s4:smb_server: Add missing newlines to logging messages via 6386306671e s4:samba: Add missing newline to logging message via 56561fd0455 s4:rpc_server: Fix typo via 29c927054dd s4:rpc_server: Remove unnecessary parentheses via 2e1adcfc2db s4:rpc_server/backupkey: Fix leaks via 68bf480b9c8 s4:rpc_server: Add missing newlines to logging messages via 5b2e60588aa s4:policy: Fix leak via 36bbfe62fa7 s4:param: Add missing newlines to logging messages via c4d055ded21 s4:ntvfs: Add missing newline to logging message via 90a9f78afeb s4:librpc: Add missing newline to logging message via 45abe2853fe s4:libnet: Add missing newlines to logging messages via b07dd255a44 s4:lib: Add missing newlines to logging messages via fd6c3e6b7ca s4:ldap_server: Add missing newlines to logging messages via 178a7ed8a9c s4:dsdb:tests: Remove unused variables via 5a19ea9bce3 s4:dsdb:tests: Use control that was (presumably) intended via 68388153c0e s4:dsdb: Do not dereference a NULL pointer via 4fad62d953c s4:dsdb: Check result of talloc functions via c850ffdec75 s4:dsdb: Correct error messages via d4db9a2793f s4:dsdb: Fix leaks via 54714b35806 s4:dsdb: Remove unnecessary parentheses via cb2053ee17e s4:dsdb: Improve grammar via 79cc9adf3c9 s4:dsdb: Add missing newlines to logging messages via 1e753542aa7 s4:dns_server: Add missing newline to logging message via ffbd69ed71f s4:client: Add missing newlines to logging messages via 3076bb6cb92 s4:cldap_server: Add missing newline to logging message via e663c1d96b3 s4:auth: Correct condition and remove redundant check via c590d8d3a38 s4:auth: Check return value of talloc_reference() via 703978c7763 s4:auth: Fix leaks via 146a9260fb8 s3:winbindd: Fix debug messages via ac0f599cabf s3:winbindd: Add missing newlines to logging messages via 90a3aca4324 s3:vfs: Add missing space in debug message via 88acf7de082 s3:utils: Fix code spelling via a30b6d1eb7c s3:utils: Add missing newlines to logging messages via aec5307ef72 s3:smbd: Add missing space to warning message via 732923e7e0a s3:smbd: Fix code spelling via 44d3f17aa9e s3:smbd Remove unnecessary newlines from logging messages via aff878dc82b s3:smbd: Add missing newlines to logging messages via 867b192cadb s3:rpc_server: Fix typo via ce0ace6700f s3:rpc_server: Add missing space to debug message via f7e86f5045e s3:rpc_server: Fix incomplete logging messages via c172de6ee4a s3:rpc_server: Add missing newlines to logging messages via 687a0f016fc s3:rpc_client: Add missing newlines to logging messages via cd3d9aa25d7 s3:registry: Add missing newlines to logging messages via 6489f31378e s3:printing: Fix code spelling via 575f0016d43 s3:printing: Add missing spaces to error messages via 1fbfe05023e s3:printing: Add missing newlines to logging messages via f80a8516b3a s3:passdb: Fix typo via 1b082f7bd64 s3:passdb: Add missing newlines to logging messages via 4fef81f183f s3:nmbd: Add missing newlines to logging messages via e9882f8207d s3:modules: Fix error message via ae147ebc584 s3:modules: Correct escape sequence via fa24c5de840 s3:modules: Remove redundant newlines in logging messages via cef6692ba00 s3:modules: Add missing newlines to logging messages via 728eebbfbb6 s3:libsmb: Add missing parenthesis to logging message via bba1613d552 s3:libsmb: Add missing newlines to logging messages via 956c7a2828e s3:librpc: Add missing newline to logging message via f798cf932e2 s3:libnet: Add missing newline to logging message via 67decfc75b6 s3:libads: Add missing newlines to logging messages via 09a13ca46e3 tldap: Use portable integer constant via 769aa901999 s3:lib: Use portable format specifiers via c7d71dd1255 s3:lib: Add missing newlines to logging messages via 8ea7b8a0af7 s3:groupdb: Add missing newline to logging message via 45a50fa96ba s3:client: Remove unnecessary newline from logging message via 34545cdf3d8 s3:lib: Consistently return a string with a trailing newline via 8505094b3b9 s3:client: Add missing newlines to logging messages via 29b2dcb4f5e s3:auth: Add missing newlines to logging messages via dc3bcd5e781 librpc: Fix typo via 6913aebd593 librpc:ndr: Fix leaks via 38b93532a76 libcli/security: Remove unnecessary cast via aa0cddad52c libcli/security: Use portable format specifiers via dbf53bf3d5e libcli/security: Fix integer overflow via 5cf61ed2e3b libcli/security: Remove unused function sid_compare_domain() via 8d658eaf1d7 s3:modules: Call dom_sid_compare_domain() instead of sid_compare_domain() via 3870e00fc5a libcli/security: Call dom_sid_compare_domain() instead of sid_compare_domain() via f05ed66295a libcli/auth: Add missing newline to logging message via 8ff5c514196 lib/util: Fix code spelling via 6ee008d2d91 lib:socket: Add missing newlines to logging messages via ea888d6901a lib:mscat: Add missing newlines to logging messages via f14d5a01874 talloc: Fix typo via 9769b594f43 ctdb: Add missing newline to logging message via def62de106d auth: Add missing newlines to logging messages via f6babaa9b66 nsswitch:libwbclient: Fix memory leak via 355fd3c7bf8 lib:charset: Update NUM_CHARSETS to reflect true value via b6c35d03c10 ndr_string: Move string length calculation fallback into default case via 45ef3ab99c3 smbXcli: Remove call to utf16_len_n() via 150d457b555 ldb: Work around inconsistent behaviour in PyObject_AsMessageElement() via d278f97d5e9 ldb: Clarify documentation for PyObject_AsMessageElement() via 77015f3ca03 ldb: Don’t leak ‘el’ via 229d270deb0 ldb: Check talloc_zero_array() return value via dc89fabbb50 ldb: Don’t leak ‘msg’ via 5820558592b ldb: Check talloc_strdup() return value via 41e0951d915 ldb: Don’t decrement reference count until object is no longer needed via 1cb91c6a78f ldb: Fix leaks via d5c309a547f ldb: Account for ‘name’ possibly being NULL via 6ce9c6a306d ldb: Don’t pass NULL pointer into strcasecmp() via d6a6dcc0c6b libcli/ldap: Don’t try to encode NULL name via 40b529f8dd9 libgpo:admx: Fix code spelling via b3e684b5352 tests/krb5: Correct comment via ccf99477207 python:tests: Remove references to now-gone files via 07299ab7927 pyglue: Add missing whitespace in docstrings via 9a123429c3a pyglue: Fix leak via fa9f9d49157 python: Check return value of talloc_strndup() via b270333fe48 python: Fix leak via d0efff68ceb python:samba:kcc: Fix log message formatting via f47aef77433 python: Use correct function signatures via 245044d65d5 samba-tool/ntacl: Remove unused imports via 3c15ff6e489 samba-tool/ntacl: Remove unused variable via 1a7a5dcd721 samba-tool/ntacl: Remove unused and unnecessary return via 1fc549ae390 testprogs: Fix code spelling via 26429996838 selftest: Add missing import via d4a643e61b2 selftest: Fix code spelling via ebfa5ff6a11 s4:rpc_server/backupkey: Fix code spelling via 13a04d67917 s4:rpc_server: Add missing newlines to debugging messages via 9c880e868d2 s4:librpc: Fix code spelling via 936c9ae1439 s4:libcli/smb_composite: Fix code spelling via 1dc8cb3e279 s4:libcli/ldap: Fix code spelling via 85beb883b17 s4:kdc: Avoid operator precedence issues via 4bc1dd32b53 s4:kdc: Fix comment via 1713f25538c s4:kdc: Inline some variables via 0182ddf97d1 s4:kdc: Use newer debugging macros via 54c38cf9d9e s4:kdc: Use portable format specifiers via b86cd80f29f s4:kdc: Remove casts in debug messages via 1286b952acc s4:kdc: Remove redundant comment via 8648c9f65be s4:kdc: Remove unused variable via dfad7f876e1 s4:kdc: Fix code spelling via 119067e4892 s4:kdc: Check that client and server are not NULL (CID 1534695) via f4d73ee8922 s4:kdc: Add missing newlines to logging messages via 0c868428eb6 s4:dsdb: Fix code spelling via 57969727b3b s4:dsdb: Move comment to more appropriate place via abcfaa79d06 s4:dsdb: Add missing newlines to logging messages via af8fbe8517a nmbd_become_lmb.c: Fix debug message formatting via 4d6118e4412 s3:utils: Fix debug message formatting via ae68493941f s3:eventlog: Fix code spelling via d17dda03c61 pidl: Remove unneeded semicolon via ae9e56a1bc4 librpc/ndr: Fix code spelling via b25a6b12a94 librpc/py_security: Don’t pass a NULL pointer to PyUnicode_FromString() via 64834e26681 librpc/ndr: Format NDR pull sizes as ‘size_t’ via ee6ef91f9cd ndr/dns-utils: Make error message slightly more readable via 872164137c3 ndr_string: Remove dodgy-looking casts via dd53e0524f8 ndr_string: Fix typo via 2a2604bfb30 ndr_string: Add overflow check in ndr_pull_charset_to_null() via 448ed84c361 librpc/ndr: Remove unneeded casts via e69968d248f librpc/rpc: Add missing newline to logging message via 748cbac2fa7 libcli/security: Cast isupper() argument to ‘unsigned char’ via 60f4d873b75 libcli/security: Remove unnecessary code via 2b33c919c59 libcli/auth: Fix code spelling via 0e653af8d62 libcli: Add missing newlines to logging messages via 731e233acab s4:auth: Add missing newlines to logging messages via 8090e595415 lib/ldb-samba: Add missing newline to logging message via 5c67b452217 lib/util: Add missing newlines to logging messages via a8085b3dd5e ctdb: Add missing newlines to logging messages via 50c6ca69424 auth: Fix code spelling via aa0d17a79bc auth: Add missing newlines to logging messages via aa9ca519467 lib/replace: Const-qualify sys_errlist via 8ed6955365d lib:dbwrap: Remove unneeded space in debug message from f87f02f6f99 ctdb-doc: Fix documentation for ctdb event status
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 269738d6ce42a2e4979bfca33328fbf0bf0e6d10 Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Fri Jul 28 15:36:21 2023 +1200 lib/replace: fix strlcat/strlcpy compile for Honggfuzz Otherwise we getthis kind of thing: ../../lib/replace/replace.c:837:3: error: implicit declaration of function 'strlcpy' is invalid in C99 [-Werror,-Wimplicit-function-declaration] strlcpy(buf, s, buflen); ../../third_party/heimdal/lib/roken/getarg.c:288:6: error: implicit declaration of function 'strlcat' is invalid in C99 [-Werror,-Wimplicit-function-declaration] strlcat(buf, "]", sizeof(buf)); because we found the symbol names in libc, but didn't check that the functions are declared in <string.h>. We already include <bsd/string.h> whenever we have it. Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> Autobuild-User(master): Andrew Bartlett <abart...@samba.org> Autobuild-Date(master): Tue Aug 8 05:35:08 UTC 2023 on atb-devel-224 commit f0e0ff262ab720e2e0cd48aa82549ad9c5ed69ec Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Sun Dec 20 12:17:56 2020 +1300 tldap: avoid infinite loop when filter contains "\)" BUG: https://bugzilla.samba.org/show_bug.cgi?id=14600 Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 17e35c269141bcefbe31ff8be0c343b6b13165f9 Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Sat Mar 6 12:40:17 2021 +1300 fuzz: add fuzzer for ldb_comparison_fold Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 019bee54c6b3521daef72b266b69c9c40a8fd278 Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Fri Dec 18 17:56:29 2020 +1300 fuzz: add fuzzer for sess_crypt_blob Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f404ef3c2aa06c801826db7d3a4cca08a60e3a0e Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Sat May 14 15:05:16 2022 +1200 libcli:auth:sess_crypt_blob: ensure key has 7 bytes Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5c007600dcdfd60b0ef8f164716573ee644869a1 Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Fri May 13 10:59:24 2022 +1200 util/base64: add a note about zero length strings Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit c3ded9d934358260af9251c7c42e903d37a1bdd4 Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Sat Aug 5 14:18:46 2023 +1200 lib/fuzzing:fuzz_sddl_access_check fix nul-term check We were wanting to ensure the string contains a zero byte, but instead were checking for a non-zero byte. Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5c81f349354cffdf6cfd3f2983634a85da474543 Author: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Date: Sat Aug 5 14:30:24 2023 +1200 lib/fuzzing: LLVMFuzzerTestOneInput() takes const uint8_t* We have been using `uint8_t *`, which works fine as far as linking goes, but leads fuzz target developers to sometimes forget why they can't just modify the passed in string instead of copying it for modification (e.g. to NUL-terminate). REF: https://llvm.org/docs/LibFuzzer.html#fuzz-target Signed-off-by: Douglas Bagnall <douglas.bagn...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 43b44827d63949162d1ffebdc71aaa09b93dba42 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 14:52:13 2023 +1200 s4:torture: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 3ec0c61c4d38518bdba0b529e37ff3a1df9a2bb8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:52:07 2023 +1200 s4:smb_server: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d61c3684c595a6a10ae03d69644b160357415550 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:54:43 2023 +1200 s4:smb_server: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 6386306671e392b4e5b121c56931c92c28ca2852 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:54:26 2023 +1200 s4:samba: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 56561fd0455e99820e480202c39eb43c109a56e4 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:45:41 2023 +1200 s4:rpc_server: Fix typo Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 29c927054dd3d5d2aef13d3f1ac6ee2e03d93faa Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:51:33 2023 +1200 s4:rpc_server: Remove unnecessary parentheses Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 2e1adcfc2db533e951ce59f794b469bc867e7d10 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 28 11:53:57 2023 +1200 s4:rpc_server/backupkey: Fix leaks Allocate these objects on a shorter-lived memory context. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 68bf480b9c87bf08274cbcbee2fcd990263e83ad Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:54:15 2023 +1200 s4:rpc_server: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5b2e60588aad58b37f9a44bada8b4b137654a888 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 11:23:29 2023 +1200 s4:policy: Fix leak Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 36bbfe62fa79a88d871d1a8049c048494cc1e493 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:54:03 2023 +1200 s4:param: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit c4d055ded21900290a1509523072c5705f444b38 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:53:51 2023 +1200 s4:ntvfs: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 90a9f78afebaf03f3b9e62eb7f84c1210c9a9d6c Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:53:35 2023 +1200 s4:librpc: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 45abe2853fe0ed8c802ac638ac92a3b4892e8d03 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:53:23 2023 +1200 s4:libnet: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit b07dd255a44898cd7bee4ca84becdc4fb971f938 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:53:13 2023 +1200 s4:lib: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit fd6c3e6b7cab29e88faf1fda598e44b86a6accbf Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:52:59 2023 +1200 s4:ldap_server: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 178a7ed8a9c32d82b26108589ab5f82b1779cfbc Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Aug 3 09:45:47 2023 +1200 s4:dsdb:tests: Remove unused variables Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5a19ea9bce39c5a4c679b490f3c75b387c2d17e4 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Aug 3 09:38:15 2023 +1200 s4:dsdb:tests: Use control that was (presumably) intended Otherwise ‘control4’ goes unused. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 68388153c0e5b353d324cb18d7512b2598e7a189 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 15:12:30 2023 +1200 s4:dsdb: Do not dereference a NULL pointer Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 4fad62d953cf225209e21f117bb02815c88560ff Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 15:05:24 2023 +1200 s4:dsdb: Check result of talloc functions Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit c850ffdec75c7674a839c3a37aaeab12e2663128 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 15:04:58 2023 +1200 s4:dsdb: Correct error messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d4db9a2793f4d51b85d266605f97c165f4d883dc Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Aug 3 11:39:12 2023 +1200 s4:dsdb: Fix leaks Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 54714b3580649d6e27eb1c4f005ade7bf1f198d7 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:51:14 2023 +1200 s4:dsdb: Remove unnecessary parentheses Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit cb2053ee17eb5d70a33a8724891cf0f63be08f54 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Jul 4 12:55:53 2023 +1200 s4:dsdb: Improve grammar Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 79cc9adf3c941a85891016dd23efeb70be0696a4 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:52:45 2023 +1200 s4:dsdb: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1e753542aa76e65988a76fd76eac67c00554712d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:52:33 2023 +1200 s4:dns_server: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ffbd69ed71f591426eff45f92d0bbde619d86dc0 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:52:17 2023 +1200 s4:client: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 3076bb6cb9279642745af8a2e9171eedff198a56 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:51:55 2023 +1200 s4:cldap_server: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit e663c1d96b3fa90a70bbae1ae2507232c11c94a0 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 12:41:45 2023 +1200 s4:auth: Correct condition and remove redundant check Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit c590d8d3a38e136cdb4d59985a3db420b80ae7d8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Aug 3 10:49:51 2023 +1200 s4:auth: Check return value of talloc_reference() Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 703978c7763b193e502f177973ee62818a0f2985 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Aug 3 10:47:42 2023 +1200 s4:auth: Fix leaks Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 146a9260fb8c595fe12e3ad865ffc108342d6b16 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:45:19 2023 +1200 s3:winbindd: Fix debug messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ac0f599cabf53cef51fc2deaf2994b1a1b1fa11d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:51:21 2023 +1200 s3:winbindd: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 90a3aca43248317ca0ddc7185e03b78f614c2c18 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:50:11 2023 +1200 s3:vfs: Add missing space in debug message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 88acf7de082bd8627237be35b1d8529fab461fb0 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 14:54:17 2023 +1200 s3:utils: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit a30b6d1eb7cb85b28628a191761897027726b153 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:51:02 2023 +1200 s3:utils: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit aec5307ef72946c282b8d1c2be6a2e1a6df6d45e Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:44:51 2023 +1200 s3:smbd: Add missing space to warning message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 732923e7e0a5023b9ded5d55ef35fd26cb2666d8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:44:40 2023 +1200 s3:smbd: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 44d3f17aa9e27a7277dbee9ba8c7c966fc6efc38 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 8 12:15:18 2023 +1200 s3:smbd Remove unnecessary newlines from logging messages time_to_asc() adds a trailing newline of its own. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit aff878dc82b80294f8ef97d31a69b3ec1e96cca8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:50:39 2023 +1200 s3:smbd: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 867b192cadbca101761ecf7ee116dd35016f4b45 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:44:18 2023 +1200 s3:rpc_server: Fix typo Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ce0ace6700fbe08a42e2f6ddb9121b074947a207 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:21:45 2023 +1200 s3:rpc_server: Add missing space to debug message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f7e86f5045e27bb2056c80ceacc40424c733d59d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:50:04 2023 +1200 s3:rpc_server: Fix incomplete logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit c172de6ee4a1e2d193bb4b24fa74135342e31bad Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:48:06 2023 +1200 s3:rpc_server: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 687a0f016fc776dcd0641cd3793d761b81641b20 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:47:47 2023 +1200 s3:rpc_client: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit cd3d9aa25d77e9c90fc9daba0e0fb93cb0a1df40 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:47:30 2023 +1200 s3:registry: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 6489f31378eb79647fd96188eafaec6bde8a9d98 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 8 12:20:31 2023 +1200 s3:printing: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 575f0016d43ef2c8ea88ecc6e3f13180ea2acd9d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:50:43 2023 +1200 s3:printing: Add missing spaces to error messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1fbfe05023e22e65711461130464efab63ea514e Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:47:10 2023 +1200 s3:printing: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f80a8516b3acd717feefe650e57d2d2d0b2d2a50 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:44:07 2023 +1200 s3:passdb: Fix typo Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1b082f7bd64c2888640253090ac8d6a8a08174b3 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:46:42 2023 +1200 s3:passdb: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 4fef81f183fc403913fc52831db1cdbbcc76c0ae Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:46:18 2023 +1200 s3:nmbd: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit e9882f8207d2d74870bbc8beff77d7cdafe46b7a Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:45:42 2023 +1200 s3:modules: Fix error message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ae147ebc584ab2b44b11022003dacea480d19d46 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:44:54 2023 +1200 s3:modules: Correct escape sequence Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit fa24c5de8400be98436da5c1b57f302cff83cbb8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:43:37 2023 +1200 s3:modules: Remove redundant newlines in logging messages ctime() and time_to_asc() each add a trailing newline of their own. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit cef6692ba0032a02a2807b63c7922b4b22ce8400 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:37:51 2023 +1200 s3:modules: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 728eebbfbb664d23e819286a7a338a9744fb5885 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 8 10:19:06 2023 +1200 s3:libsmb: Add missing parenthesis to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit bba1613d55265c52d2632597a7076938b5a42504 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:37:19 2023 +1200 s3:libsmb: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 956c7a2828e2437486b5f036ea0c6c24b1c1c6a8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:37:05 2023 +1200 s3:librpc: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f798cf932e20b10213be191cdb50a8f5efaf8579 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:36:49 2023 +1200 s3:libnet: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 67decfc75b655120264d6cdac3a4f52808009d83 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:36:27 2023 +1200 s3:libads: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 09a13ca46e322497e63dc8353d4b0a86fbec1e39 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 13:20:22 2023 +1200 tldap: Use portable integer constant Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 769aa9019996d54ac14085c5c4eff8b915763b20 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:49:36 2023 +1200 s3:lib: Use portable format specifiers Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit c7d71dd1255fe521d232a12bf8fa7a2460136b04 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:35:35 2023 +1200 s3:lib: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8ea7b8a0af7a127acd04f8cb5517718c95205ee0 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:35:17 2023 +1200 s3:groupdb: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 45a50fa96ba3f6a8b78940b4080861d515f2d093 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 8 12:15:00 2023 +1200 s3:client: Remove unnecessary newline from logging message time_to_asc() adds a trailing newline of its own. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 34545cdf3d88f3fc564268eefb7a1e1991f543a5 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 8 15:38:26 2023 +1200 s3:lib: Consistently return a string with a trailing newline Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8505094b3b9faf0370beb1ef41702e1ea97d11aa Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:34:52 2023 +1200 s3:client: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 29b2dcb4f5ea9fd63c6104ccc1af2dd94d1dd82f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:34:27 2023 +1200 s3:auth: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit dc3bcd5e7815886ee35c9dbf48fc9ca78c46d7af Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 09:43:48 2023 +1200 librpc: Fix typo Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 6913aebd5934860349f3539a7f6a2c8b0eefd289 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 13:46:50 2023 +1200 librpc:ndr: Fix leaks Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 38b93532a7669f388dca60a25e6a0aaf55474148 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:48:21 2023 +1200 libcli/security: Remove unnecessary cast Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit aa0cddad52c636b0d06845972ac98707e61ae21f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:47:50 2023 +1200 libcli/security: Use portable format specifiers Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit dbf53bf3d5e1cd154840b33f946a7a5c46a283af Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 14:27:31 2023 +1200 libcli/security: Fix integer overflow On a typical machine where the size of ‘int’ is 32 bits or smaller, a sub-authority of 2147483649 would be ordered before a sub-authority of 1, even though it is greater. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5cf61ed2e3b217b0d1313cc7cb94a44b11ef0863 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 14:27:01 2023 +1200 libcli/security: Remove unused function sid_compare_domain() Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8d658eaf1d7b7062556fd28f13f548b30590c668 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 14:26:41 2023 +1200 s3:modules: Call dom_sid_compare_domain() instead of sid_compare_domain() The two functions are identical in behaviour. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 3870e00fc5a22146df81b626b75a65c0e169cef8 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 14:26:03 2023 +1200 libcli/security: Call dom_sid_compare_domain() instead of sid_compare_domain() The two functions are identical in behaviour. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f05ed66295ae80df4e77026dc33e8e3144f570e2 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:34:07 2023 +1200 libcli/auth: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8ff5c514196d1a013f27316b1abaeffea4411d76 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 15:47:18 2023 +1200 lib/util: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 6ee008d2d9197059f2861a51cf2e7a2b05476d2c Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:33:45 2023 +1200 lib:socket: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ea888d6901a3afd20f5ab9d24f678117f1c6d3a6 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:33:05 2023 +1200 lib:mscat: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f14d5a01874fd2c0462976d771fd48167cbd8cbe Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 13 11:42:16 2023 +1200 talloc: Fix typo Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 9769b594f43974c06fce2f243c59dddd500573be Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:32:34 2023 +1200 ctdb: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit def62de106d97dbefc72152c31bde67ba4a3a354 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Aug 7 16:31:51 2023 +1200 auth: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f6babaa9b6618201c9915c1992d0f3926c02c6bd Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Jul 19 12:55:15 2023 +1200 nsswitch:libwbclient: Fix memory leak Found by Balazs Scheidler <ba...@balabit.hu>. Reported by Ferenc Wágner <wf...@niif.hu> at https://lists.samba.org/archive/samba-technical/2023-June/138271.html Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 355fd3c7bf8af31800c351d70302ab48c72694c0 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Jul 11 13:50:53 2023 +1200 lib:charset: Update NUM_CHARSETS to reflect true value CH_DISPLAY was removed in commit 125a2ff262aa312df20eec68802fd5f8a47f492f, but NUM_CHARSETS was not updated to match. By assigning to NUM_CHARSETS the last enumeration value in charset_t, we guard against its falling out of sync again. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit b6c35d03c101ae822263a76e39cf1b016b415268 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Aug 2 10:04:23 2023 +1200 ndr_string: Move string length calculation fallback into default case We are about to add a new enumeration constant (NUM_CHARSETS) to charset_t. To do that we must have a default case in this switch statement, or the compiler will refuse to compile it, stating that we haven’t handled all the cases. The alternative, adding a case for NUM_CHARSETS, would just look silly. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 45ef3ab99c3b49f084696c4b17d811e499572d91 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 10 13:27:56 2023 +1200 smbXcli: Remove call to utf16_len_n() This code was probably intended to refer to ‘blob1’ rather than to ‘blob2’. As it is, it fails to achieve anything. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 150d457b555f9cbe48181f5c33657a77fe083457 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 11:28:01 2023 +1200 ldb: Work around inconsistent behaviour in PyObject_AsMessageElement() PyObject_AsMessageElement() has ‘flags’ and ‘attr_name’ parameters to set properties of the returned MessageElement, but they apply only *sometimes*. ‘attr_name’ not being set can result in cryptic and misleading error messages from various ldb operations. Changing the function’s behaviour to be more consistent could break existing code, so we work around the issue instead. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d278f97d5e9d4266f940e7f65229747906a3b759 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 11:18:49 2023 +1200 ldb: Clarify documentation for PyObject_AsMessageElement() Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 77015f3ca03b0fda1677674af444a5005fc02db1 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 10:43:15 2023 +1200 ldb: Don’t leak ‘el’ Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 229d270deb0ab74101dcc0cbee09edfbe8578dec Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 10:42:38 2023 +1200 ldb: Check talloc_zero_array() return value Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit dc89fabbb506c49bd166680d4f80cdeaec6cb034 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 10:42:01 2023 +1200 ldb: Don’t leak ‘msg’ Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5820558592ba8a16837992648e0dbd61532e803e Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 09:48:35 2023 +1200 ldb: Check talloc_strdup() return value Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 41e0951d915ad5cf660ca227be2f4c844dcbdf8e Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 09:56:49 2023 +1200 ldb: Don’t decrement reference count until object is no longer needed If ‘tmp’ happens to be garbage-collected, ‘name’ will become invalid. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1cb91c6a78f1b564b196ff69d339b75c56d1a6d4 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 09:51:15 2023 +1200 ldb: Fix leaks Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d5c309a547f77e22451e56ab4ca3bc30fae41010 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 09:34:34 2023 +1200 ldb: Account for ‘name’ possibly being NULL Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 6ce9c6a306d67c55e160e70ee50e5e732189c9d6 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 10:37:57 2023 +1200 ldb: Don’t pass NULL pointer into strcasecmp() Doing so is undefined behaviour. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d6a6dcc0c6bce1a19178a69c3c2b61d43d7da5ea Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 10:37:09 2023 +1200 libcli/ldap: Don’t try to encode NULL name Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 40b529f8dd913b494b79f6cdb01f55032a3e5a96 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jun 26 08:50:48 2023 +1200 libgpo:admx: Fix code spelling (NEGOgiation → NEGOtiation) Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit b3e684b53524af0aaadab779ee5b970006150cc9 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Jul 19 12:50:16 2023 +1200 tests/krb5: Correct comment Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ccf994772074c6c40b46b3779e7d4567d030b340 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 17 10:44:36 2023 +1200 python:tests: Remove references to now-gone files Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 07299ab79278e1d70d5a136af6d426c15cb97583 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 28 08:15:15 2023 +1200 pyglue: Add missing whitespace in docstrings Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 9a123429c3aea03f746dad7e38c3ac11ef619fcc Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 28 08:15:02 2023 +1200 pyglue: Fix leak Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit fa9f9d491571d538559c873e166365ece28f4d73 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 28 08:14:47 2023 +1200 python: Check return value of talloc_strndup() Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit b270333fe483e3cee1a70e8a313ec196966a5a0c Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 28 08:14:27 2023 +1200 python: Fix leak Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d0efff68ceb5616343a5f5a68dc5b6d8fb71c8d1 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 6 15:56:38 2023 +1200 python:samba:kcc: Fix log message formatting Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f47aef77433509a64af63fcf18f849747b62e9f1 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 09:26:27 2023 +1200 python: Use correct function signatures Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 245044d65d536923dbc502901ac38e8b1355d3b1 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jun 22 17:02:47 2023 +1200 samba-tool/ntacl: Remove unused imports Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 3c15ff6e4894d0d7d5313bed1ecdda1d59f1a7ad Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jun 22 17:02:19 2023 +1200 samba-tool/ntacl: Remove unused variable Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1a7a5dcd721c4af5370592b6d214adc408f3826d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jun 22 16:59:36 2023 +1200 samba-tool/ntacl: Remove unused and unnecessary return setntacl() just returns None. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1fc549ae390e66f53f70d2f864b126a3da262343 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jun 22 16:04:03 2023 +1200 testprogs: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 26429996838d600e1911a0f94c8cd993866dab29 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 13 11:36:17 2023 +1200 selftest: Add missing import Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d4a643e61b2008dd0a059f7c7eb53641eea1f0d5 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Jul 5 12:06:33 2023 +1200 selftest: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ebfa5ff6a11929c9d43895cf5b566f76a8d6d42d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 15:10:36 2023 +1200 s4:rpc_server/backupkey: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 13a04d6791729a1a6eddced87eac3d07a2ded502 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:39:38 2023 +1200 s4:rpc_server: Add missing newlines to debugging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 9c880e868d260052ed5fdf95c5f3890deb2afa87 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 11:30:59 2023 +1200 s4:librpc: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 936c9ae14393461033ffe2dbc90ce6155f3c10aa Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 12:43:07 2023 +1200 s4:libcli/smb_composite: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1dc8cb3e279194ffedf4ad94511ab1cbc30c502a Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 12:42:43 2023 +1200 s4:libcli/ldap: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 85beb883b1784db18f9940a08c5e96ff6b937f58 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 12:55:24 2023 +1200 s4:kdc: Avoid operator precedence issues Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 4bc1dd32b5393c4b32beccb2bd8e2c89b461417d Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 12:38:09 2023 +1200 s4:kdc: Fix comment Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1713f25538c718b4f0a3b1d46747162ba2c6b828 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 11:49:18 2023 +1200 s4:kdc: Inline some variables IMO, this code is easier to read if the reader can tell at a glance what the values of these enumerations are, rather than having to think about where the values come from. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 0182ddf97d143a7d77722c2ef8768dbd6007aa38 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 11:44:05 2023 +1200 s4:kdc: Use newer debugging macros Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 54c38cf9d9e58858356b36a45bb950fbc35b63b9 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 10:20:11 2023 +1200 s4:kdc: Use portable format specifiers Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit b86cd80f29f742c89a72c5ee9157e6f07bea2d4b Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Aug 1 10:19:45 2023 +1200 s4:kdc: Remove casts in debug messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 1286b952acc5d2543dd4b2d44a85cba06ab8804f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 11:03:03 2023 +1200 s4:kdc: Remove redundant comment We don’t need two copies of the same comment. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8648c9f65becc861a8dc2f580c3547e0e452c1b6 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 09:37:57 2023 +1200 s4:kdc: Remove unused variable Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit dfad7f876e15907589f407f3688cd119935aa9c6 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Jul 11 16:52:25 2023 +1200 s4:kdc: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 119067e48922bd8328c8d237c6ebaa466a198b4f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 3 09:04:01 2023 +1200 s4:kdc: Check that client and server are not NULL (CID 1534695) Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit f4d73ee892286329ac8a52614077c18ab4ccf247 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:37:48 2023 +1200 s4:kdc: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 0c868428eb6db88243c4582c8c0e5cb4ae4735ee Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Wed Jun 28 09:01:34 2023 +1200 s4:dsdb: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 57969727b3b4e0c9f91d93c529b47db67e19827f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jun 22 14:31:12 2023 +1200 s4:dsdb: Move comment to more appropriate place Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit abcfaa79d064319174bd42bcd2d1b0f8ea8f4406 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:18:17 2023 +1200 s4:dsdb: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit af8fbe8517aa0d30efdb7ed03d37830aca7a2d66 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 6 15:49:00 2023 +1200 nmbd_become_lmb.c: Fix debug message formatting Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 4d6118e44122287cc737dd75d4aa0e359deb6786 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 6 15:57:08 2023 +1200 s3:utils: Fix debug message formatting Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ae68493941f4bba03858f71ac9eeece9c15b5f49 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 6 10:49:11 2023 +1200 s3:eventlog: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit d17dda03c61aa0355a0e3cc0bcb9bbfb8a75e997 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 13:51:39 2023 +1200 pidl: Remove unneeded semicolon Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ae9e56a1bc4615ce399d6682be69f05ef04c5619 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 10:41:24 2023 +1200 librpc/ndr: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit b25a6b12a94593dfdf502860abe133040e2b45ba Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 12:22:45 2023 +1200 librpc/py_security: Don’t pass a NULL pointer to PyUnicode_FromString() Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 64834e26681b5b7e13dc1e1cbaf8510bd71c2d48 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 11:18:14 2023 +1200 librpc/ndr: Format NDR pull sizes as ‘size_t’ The arguments to these macros are occasionally of type size_t. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit ee6ef91f9cd600946b0122ecdb4e083b9d527c20 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Tue Jul 18 11:18:54 2023 +1200 ndr/dns-utils: Make error message slightly more readable max_length will always be greater than one, so we can use the plural. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 872164137c3e4f83423b821cce70bf8104db8ed9 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 11:38:14 2023 +1200 ndr_string: Remove dodgy-looking casts Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit dd53e0524f86d552ce3a73469fa46d2547db0d13 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 10 14:42:55 2023 +1200 ndr_string: Fix typo Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 2a2604bfb301879bbaa4747a2d6196b10c0ef3c3 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 10 14:42:23 2023 +1200 ndr_string: Add overflow check in ndr_pull_charset_to_null() This matches ndr_pull_charset(). Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 448ed84c361bc1f10c9d19bfed98c8fc2510cefc Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 6 14:18:33 2023 +1200 librpc/ndr: Remove unneeded casts Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit e69968d248ff41431232823e058b30b64c4bd254 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:16:20 2023 +1200 librpc/rpc: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 748cbac2fa7067bb11e6ad693d92ba7c00f47c61 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 13:26:27 2023 +1200 libcli/security: Cast isupper() argument to ‘unsigned char’ Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 60f4d873b7501bf0b59ad152fd19c0212e637e6b Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 17 15:48:50 2023 +1200 libcli/security: Remove unnecessary code The revision has already been set at the start of this function. Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 2b33c919c599367677225e7e53211f050e6fc7e3 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 20 15:09:42 2023 +1200 libcli/auth: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 0e653af8d626d8ed322d4b64e50f4f3b364af5dd Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:15:40 2023 +1200 libcli: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 731e233acababb54bd17d2b54ce514494b5b7e38 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:17:16 2023 +1200 s4:auth: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8090e595415c8eee2ca5971e8efa3bef3490e41c Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:09:05 2023 +1200 lib/ldb-samba: Add missing newline to logging message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 5c67b452217fa257d19d072db36ff9fe59ce1078 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:14:00 2023 +1200 lib/util: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit a8085b3dd5e7827bbfa2c1e35ccde6bd0882e2ae Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:07:36 2023 +1200 ctdb: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 50c6ca694244e2d16af8ee3c06db6c6fe4ae3d8f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 7 14:18:49 2023 +1200 auth: Fix code spelling Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit aa0d17a79bc8da8d19c317f5f85b84a3fa4d16c5 Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Mon Jul 31 16:06:56 2023 +1200 auth: Add missing newlines to logging messages Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit aa9ca5194674ff7e250f02719a91843c840d203e Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Thu Jul 6 10:48:38 2023 +1200 lib/replace: Const-qualify sys_errlist Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> commit 8ed6955365d7be3b270be32f9993f9a394a2181f Author: Joseph Sutton <josephsut...@catalyst.net.nz> Date: Fri Jul 21 10:29:45 2023 +1200 lib:dbwrap: Remove unneeded space in debug message Signed-off-by: Joseph Sutton <josephsut...@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abart...@samba.org> ----------------------------------------------------------------------- Summary of changes: auth/auth_sam_reply.c | 4 +- auth/credentials/credentials.c | 6 +- auth/credentials/credentials_krb5.c | 2 +- auth/credentials/credentials_ntlm.c | 4 +- ctdb/common/ctdb_ltdb.c | 2 +- ctdb/server/ctdb_daemon.c | 2 +- ctdb/server/ctdb_recoverd.c | 4 +- lib/crypto/py_crypto.c | 4 +- lib/dbwrap/dbwrap.c | 2 +- lib/fuzzing/fuzz_cli_credentials_parse_string.c | 2 +- lib/fuzzing/fuzz_dcerpc_parse_binding.c | 2 +- lib/fuzzing/fuzz_ldap_decode.c | 2 +- ..._ldb_ldif_read.c => fuzz_ldb_comparison_fold.c} | 52 +++--- lib/fuzzing/fuzz_ldb_dn_explode.c | 2 +- lib/fuzzing/fuzz_ldb_ldif_read.c | 2 +- lib/fuzzing/fuzz_ldb_parse_binary_decode.c | 2 +- lib/fuzzing/fuzz_ldb_parse_control.c | 2 +- lib/fuzzing/fuzz_ldb_parse_tree.c | 2 +- lib/fuzzing/fuzz_lzxpress.c | 2 +- lib/fuzzing/fuzz_lzxpress_compress.c | 2 +- lib/fuzzing/fuzz_lzxpress_huffman_compress.c | 2 +- lib/fuzzing/fuzz_lzxpress_huffman_decompress.c | 2 +- lib/fuzzing/fuzz_lzxpress_huffman_round_trip.c | 2 +- lib/fuzzing/fuzz_lzxpress_round_trip.c | 2 +- lib/fuzzing/fuzz_ndr_X.c | 2 +- lib/fuzzing/fuzz_nmblib_parse_packet.c | 2 +- lib/fuzzing/fuzz_oLschema2ldif.c | 2 +- lib/fuzzing/fuzz_parse_lpq_entry.c | 2 +- lib/fuzzing/fuzz_reg_parse.c | 2 +- lib/fuzzing/fuzz_regfio.c | 2 +- lib/fuzzing/fuzz_sddl_access_check.c | 4 +- lib/fuzzing/fuzz_sddl_parse.c | 2 +- lib/fuzzing/fuzz_security_token_vs_descriptor.c | 2 +- ...uzz_ldb_dn_explode.c => fuzz_sess_crypt_blob.c} | 48 +++--- lib/fuzzing/fuzz_stable_sort.c | 2 +- lib/fuzzing/fuzz_stable_sort_r.c | 2 +- lib/fuzzing/fuzz_tiniparser.c | 2 +- lib/fuzzing/fuzzing.h | 2 +- lib/fuzzing/wscript_build | 10 ++ lib/ldb-samba/ldif_handlers.c | 2 +- lib/ldb/common/ldb_msg.c | 18 ++- lib/ldb/pyldb.c | 82 +++++++++- lib/mscat/mscat_ctl.c | 28 ++-- lib/mscat/mscat_pkcs7.c | 24 +-- lib/replace/replace.h | 2 +- lib/replace/wscript | 11 ++ lib/socket/interfaces.c | 8 +- lib/talloc/talloc.h | 2 +- lib/util/base64.c | 10 +- lib/util/charset/charset.h | 14 +- lib/util/debug.h | 4 +- lib/util/util_file.c | 2 +- lib/util/util_str_escape.c | 2 +- lib/util/util_strlist_v3.c | 4 +- libcli/auth/credentials.c | 2 +- libcli/auth/schannel_state_tdb.c | 2 +- libcli/auth/session.c | 4 + libcli/dns/dns_lookup.c | 2 +- libcli/http/http.c | 4 +- libcli/ldap/ldap_message.c | 3 + libcli/named_pipe_auth/npa_tstream.c | 4 +- libcli/security/dom_sid.c | 22 ++- libcli/security/dom_sid.h | 1 - libcli/security/sddl.c | 12 +- libcli/security/security_token.c | 8 +- libcli/security/util_sid.c | 20 +-- libcli/smb/smb2cli_create.c | 2 +- libcli/smb/smbXcli_base.c | 4 - libgpo/admx/ru-RU/samba.adml | 2 +- librpc/ndr/libndr.h | 6 +- librpc/ndr/ndr.c | 18 ++- librpc/ndr/ndr_compression.c | 8 +- librpc/ndr/ndr_dns_utils.c | 2 +- librpc/ndr/ndr_sec_helper.c | 7 +- librpc/ndr/ndr_string.c | 19 ++- librpc/rpc/dcerpc_pkt_auth.c | 2 +- librpc/rpc/dcesrv_auth.c | 2 +- nsswitch/libwbclient/wbc_pam.c | 1 + pidl/lib/Parse/Pidl/Samba4/Python.pm | 2 +- python/modules.c | 6 + python/pyglue.c | 7 +- python/samba/kcc/__init__.py | 4 +- python/samba/netcmd/ntacl.py | 22 ++- python/samba/tests/krb5/authn_policy_tests.py | 2 +- python/samba/tests/ndr.py | 1 + python/samba/tests/source_chars.py | 2 - selftest/target/Samba.pm | 4 +- source3/auth/auth_samba4.c | 2 +- source3/auth/auth_util.c | 2 +- source3/auth/pampass.c | 4 +- source3/client/client.c | 4 +- source3/client/clitar.c | 2 +- source3/groupdb/mapping.c | 2 +- source3/lib/adouble.c | 2 +- source3/lib/eventlog/eventlog.c | 2 +- source3/lib/sysquotas.c | 14 +- source3/lib/time.c | 4 +- source3/lib/tldap.c | 3 +- source3/lib/util_ea.c | 2 +- source3/libads/kerberos_keytab.c | 2 +- source3/libads/krb5_setpw.c | 2 +- source3/libads/ldap.c | 14 +- source3/libnet/libnet_dssync_keytab.c | 2 +- source3/librpc/rpc/dcerpc_helpers.c | 2 +- source3/libsmb/clidfs.c | 2 +- source3/libsmb/cliprint.c | 2 +- source3/libsmb/libsmb_path.c | 4 +- source3/libsmb/libsmb_server.c | 2 +- source3/locale/net/de.po | 2 +- source3/modules/nfs4_acls.c | 4 +- source3/modules/nfs4acl_xattr_nfs.c | 4 +- source3/modules/nfs4acl_xattr_xdr.c | 2 +- source3/modules/vfs_afsacl.c | 4 +- source3/modules/vfs_aixacl2.c | 2 +- source3/modules/vfs_ceph.c | 2 +- source3/modules/vfs_extd_audit.c | 2 +- source3/modules/vfs_fruit.c | 12 +- source3/modules/vfs_glusterfs_fuse.c | 2 +- source3/modules/vfs_gpfs.c | 2 +- source3/modules/vfs_tsmsm.c | 2 +- source3/modules/vfs_unityed_media.c | 8 +- source3/modules/vfs_virusfilter.c | 4 +- source3/modules/vfs_virusfilter_fsav.c | 2 +- source3/modules/vfs_vxfs.c | 2 +- source3/modules/vfs_zfsacl.c | 8 +- source3/nmbd/asyncdns.c | 2 +- source3/nmbd/nmbd.c | 6 +- source3/nmbd/nmbd_become_lmb.c | 2 +- source3/nmbd/nmbd_winsserver.c | 4 +- source3/passdb/pdb_ldap.c | 16 +- source3/passdb/pdb_samba_dsdb.c | 18 +-- source3/passdb/pdb_smbpasswd.c | 2 +- source3/passdb/pdb_tdb.c | 2 +- source3/passdb/py_passdb.c | 2 +- source3/passdb/secrets.c | 2 +- source3/printing/print_cups.c | 4 +- source3/printing/print_iprint.c | 2 +- source3/printing/printer_list.c | 8 +- source3/printing/printing.c | 12 +- source3/registry/reg_format.c | 8 +- source3/registry/reg_parse.c | 6 +- source3/rpc_client/cli_mdssvc.c | 2 +- source3/rpc_client/cli_pipe.c | 2 +- source3/rpc_client/rpc_transport_np.c | 2 +- source3/rpc_server/epmapper/srv_epmapper.c | 2 +- source3/rpc_server/eventlog/srv_eventlog_nt.c | 2 +- source3/rpc_server/lsa/srv_lsa_nt.c | 2 +- source3/rpc_server/mdssvc/marshalling.c | 10 +- source3/rpc_server/mdssvc/mdssvc.c | 2 +- source3/rpc_server/rpc_host.c | 2 +- source3/rpc_server/rpc_server.c | 4 +- source3/rpc_server/rpc_worker.c | 2 +- source3/rpc_server/spoolss/srv_spoolss_nt.c | 7 +- source3/rpc_server/winreg/srv_winreg_nt.c | 3 +- source3/smbd/dosmode.c | 4 +- source3/smbd/file_access.c | 2 +- source3/smbd/mangle_hash2.c | 2 +- source3/smbd/msdfs.c | 2 +- source3/smbd/oplock_linux.c | 2 +- source3/smbd/posix_acls.c | 2 +- source3/smbd/scavenger.c | 4 +- source3/smbd/smb1_lanman.c | 2 +- source3/smbd/smb1_negprot.c | 2 +- source3/smbd/smb1_nttrans.c | 2 +- source3/smbd/smb1_reply.c | 2 +- source3/smbd/smb1_trans2.c | 4 +- source3/smbd/smbXsrv_open.c | 2 +- source3/utils/net_ads.c | 2 +- source3/utils/net_rpc.c | 10 +- source3/utils/nmblookup.c | 2 +- source3/utils/ntlm_auth.c | 4 +- source3/utils/py_net.c | 2 +- source3/utils/smbget.c | 4 +- source3/winbindd/idmap_autorid_tdb.c | 6 +- source3/winbindd/idmap_ldap.c | 4 +- source3/winbindd/winbindd_cache.c | 2 +- source3/winbindd/winbindd_cm.c | 2 +- source3/winbindd/winbindd_dual.c | 8 +- source3/winbindd/winbindd_dual_ndr.c | 10 +- source3/winbindd/winbindd_pam.c | 2 +- source3/winbindd/winbindd_util.c | 12 +- source4/auth/gensec/gensec_krb5.c | 4 +- source4/auth/kerberos/kerberos_pac.c | 4 +- source4/auth/session.c | 12 +- source4/auth/system_session.c | 175 ++++++++++++++++----- source4/cldap_server/cldap_server.c | 2 +- source4/client/cifsdd.c | 6 +- source4/client/client.c | 2 +- source4/dns_server/dnsserver_common.c | 2 +- source4/dsdb/common/dsdb_access.c | 4 +- source4/dsdb/common/dsdb_dn.c | 2 +- source4/dsdb/common/util.c | 97 ++++++++++-- source4/dsdb/common/util_links.c | 2 +- source4/dsdb/kcc/kcc_connection.c | 4 +- source4/dsdb/kcc/kcc_drs_replica_info.c | 14 +- source4/dsdb/repl/drepl_out_helpers.c | 8 +- source4/dsdb/repl/replicated_objects.c | 12 +- source4/dsdb/samdb/cracknames.c | 2 +- source4/dsdb/samdb/ldb_modules/audit_util.c | 2 +- source4/dsdb/samdb/ldb_modules/dirsync.c | 4 +- source4/dsdb/samdb/ldb_modules/password_hash.c | 81 +++++++++- source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 12 +- source4/dsdb/samdb/ldb_modules/util.c | 2 +- source4/dsdb/samdb/samdb.c | 10 +- source4/dsdb/schema/schema_convert_to_ol.c | 6 +- source4/dsdb/tests/python/dirsync.py | 2 +- source4/dsdb/tests/python/ldap_schema.py | 4 - source4/dsdb/tests/python/sec_descriptor.py | 11 +- source4/kdc/db-glue.c | 64 ++++---- source4/kdc/hdb-samba4.c | 2 +- source4/kdc/kdc-proxy.c | 10 +- source4/kdc/kdc-server.c | 22 +-- source4/kdc/kdc-service-mit.c | 14 +- source4/kdc/kpasswd-service.c | 6 +- source4/kdc/kpasswd_glue.c | 8 +- source4/kdc/mit_kdc_irpc.c | 8 +- source4/kdc/mit_samba.c | 35 +++-- source4/kdc/pac-glue.c | 130 +++++++-------- source4/kdc/samba_kdc.h | 4 +- source4/kdc/wdc-samba4.c | 15 +- source4/ldap_server/ldap_backend.c | 2 +- source4/ldap_server/ldap_bind.c | 4 +- source4/ldap_server/ldap_extended.c | 2 +- source4/lib/policy/gp_manage.c | 1 + source4/lib/registry/regf.c | 4 +- source4/libcli/ldap/ldap_bind.c | 2 +- source4/libcli/smb_composite/sesssetup.c | 2 +- source4/libnet/libnet_vampire.c | 6 +- source4/librpc/ndr/py_security.c | 4 + source4/librpc/rpc/dcerpc_auth.c | 4 +- source4/librpc/rpc/dcerpc_roh_channel_out.c | 2 +- source4/ntvfs/posix/pvfs_sys.c | 2 +- source4/param/provision.c | 4 +- source4/param/pyparam.c | 2 +- source4/rpc_server/backupkey/dcesrv_backupkey.c | 8 +- source4/rpc_server/dcerpc_server.c | 2 +- source4/rpc_server/dnsserver/dcerpc_dnsserver.c | 22 +-- source4/rpc_server/dnsserver/dnsdata.c | 10 +- source4/rpc_server/drsuapi/dcesrv_drsuapi.c | 2 +- source4/rpc_server/drsuapi/getncchanges.c | 24 +-- source4/rpc_server/lsa/dcesrv_lsa.c | 4 +- source4/rpc_server/netlogon/dcerpc_netlogon.c | 4 +- source4/rpc_server/samr/dcesrv_samr.c | 8 +- source4/rpc_server/service_rpc.c | 2 +- source4/rpc_server/srvsvc/dcesrv_srvsvc.c | 18 +-- source4/samba/process_prefork.c | 2 +- source4/smb_server/smb/negprot.c | 4 +- source4/smb_server/smb/sesssetup.c | 10 +- source4/smb_server/smb/trans2.c | 8 +- source4/smb_server/smb2/receive.c | 2 +- source4/smb_server/smb2/sesssetup.c | 10 +- source4/torture/dfs/domaindfs.c | 2 +- testprogs/blackbox/test_weak_crypto.sh | 2 +- testprogs/blackbox/test_weak_crypto_server.sh | 2 +- 254 files changed, 1178 insertions(+), 808 deletions(-) copy lib/fuzzing/{fuzz_ldb_ldif_read.c => fuzz_ldb_comparison_fold.c} (57%) copy lib/fuzzing/{fuzz_ldb_dn_explode.c => fuzz_sess_crypt_blob.c} (59%) Changeset truncated at 500 lines: diff --git a/auth/auth_sam_reply.c b/auth/auth_sam_reply.c index 8825ae8f83d..27f04e86434 100644 --- a/auth/auth_sam_reply.c +++ b/auth/auth_sam_reply.c @@ -697,7 +697,7 @@ NTSTATUS make_user_info_dc_netlogon_validation(TALLOC_CTX *mem_ctx, matches. */ if (!base->domain_sid) { - DEBUG(0, ("Cannot operate on a Netlogon Validation without a domain SID")); + DEBUG(0, ("Cannot operate on a Netlogon Validation without a domain SID\n")); talloc_free(user_info_dc); return NT_STATUS_INVALID_PARAMETER; } @@ -899,7 +899,7 @@ NTSTATUS make_user_info_dc_pac(TALLOC_CTX *mem_ctx, */ if (rg->domain_sid == NULL) { talloc_free(user_info_dc); - DEBUG(0, ("Cannot operate on a PAC without a resource domain SID")); + DEBUG(0, ("Cannot operate on a PAC without a resource domain SID\n")); return NT_STATUS_INVALID_PARAMETER; } diff --git a/auth/credentials/credentials.c b/auth/credentials/credentials.c index 0485cc4e64e..3690ac8c3a4 100644 --- a/auth/credentials/credentials.c +++ b/auth/credentials/credentials.c @@ -1882,7 +1882,7 @@ _PUBLIC_ NTSTATUS netlogon_creds_session_encrypt( if (data.data == NULL || data.length == 0) { DBG_ERR("Nothing to encrypt " - "data.data == NULL or data.length == 0"); + "data.data == NULL or data.length == 0\n"); return NT_STATUS_INVALID_PARAMETER; } /* @@ -1890,7 +1890,7 @@ _PUBLIC_ NTSTATUS netlogon_creds_session_encrypt( * NETLOGON pipe session key . */ if (all_zero(data.data, data.length)) { - DBG_ERR("Supplied data all zeros, could leak session key"); + DBG_ERR("Supplied data all zeros, could leak session key\n"); return NT_STATUS_INVALID_PARAMETER; } if (state->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) { @@ -1902,7 +1902,7 @@ _PUBLIC_ NTSTATUS netlogon_creds_session_encrypt( data.data, data.length); } else { - DBG_ERR("Unsupported encryption option negotiated"); + DBG_ERR("Unsupported encryption option negotiated\n"); status = NT_STATUS_NOT_SUPPORTED; } if (!NT_STATUS_IS_OK(status)) { diff --git a/auth/credentials/credentials_krb5.c b/auth/credentials/credentials_krb5.c index 71863367aa5..0ce70557c58 100644 --- a/auth/credentials/credentials_krb5.c +++ b/auth/credentials/credentials_krb5.c @@ -1516,7 +1516,7 @@ _PUBLIC_ int cli_credentials_get_aes256_key(struct cli_credentials *cred, &key); if (krb5_ret != 0) { DEBUG(1,("cli_credentials_get_aes256_key: " - "generation of a aes256-cts-hmac-sha1-96 key failed: %s", + "generation of a aes256-cts-hmac-sha1-96 key failed: %s\n", smb_get_krb5_error_message(smb_krb5_context->krb5_context, krb5_ret, mem_ctx))); return EINVAL; diff --git a/auth/credentials/credentials_ntlm.c b/auth/credentials/credentials_ntlm.c index 38226453c4a..f30abc74fb0 100644 --- a/auth/credentials/credentials_ntlm.c +++ b/auth/credentials/credentials_ntlm.c @@ -347,7 +347,7 @@ done: * * This is required because the nt_hash is calculated over the raw utf16 blob, * which might not be completely valid utf16, which means the conversion - * from CH_UTF16MUNGED to CH_UTF8 might loose information. + * from CH_UTF16MUNGED to CH_UTF8 might lose information. */ _PUBLIC_ bool cli_credentials_set_utf16_password(struct cli_credentials *cred, const DATA_BLOB *password_utf16, @@ -401,7 +401,7 @@ _PUBLIC_ bool cli_credentials_set_utf16_password(struct cli_credentials *cred, * * This is required because the nt_hash is calculated over the raw utf16 blob, * which might not be completely valid utf16, which means the conversion - * from CH_UTF16MUNGED to CH_UTF8 might loose information. + * from CH_UTF16MUNGED to CH_UTF8 might lose information. */ _PUBLIC_ bool cli_credentials_set_old_utf16_password(struct cli_credentials *cred, const DATA_BLOB *password_utf16) diff --git a/ctdb/common/ctdb_ltdb.c b/ctdb/common/ctdb_ltdb.c index 97db5cc64de..663441675a2 100644 --- a/ctdb/common/ctdb_ltdb.c +++ b/ctdb/common/ctdb_ltdb.c @@ -341,7 +341,7 @@ int ctdb_ltdb_delete(struct ctdb_db_context *ctdb_db, TDB_DATA key) return 0; } if (tdb_delete(ctdb_db->ltdb->tdb, key) != 0) { - DEBUG(DEBUG_ERR,("Failed to delete empty record.")); + DEBUG(DEBUG_ERR,("Failed to delete empty record.\n")); return -1; } return 0; diff --git a/ctdb/server/ctdb_daemon.c b/ctdb/server/ctdb_daemon.c index da60144bf2e..eb9d63454de 100644 --- a/ctdb/server/ctdb_daemon.c +++ b/ctdb/server/ctdb_daemon.c @@ -745,7 +745,7 @@ static void daemon_request_call_from_client(struct ctdb_client *client, ctdb_db = find_ctdb_db(client->ctdb, c->db_id); if (!ctdb_db) { - DEBUG(DEBUG_ERR, (__location__ " Unknown database in request. db_id==0x%08x", + DEBUG(DEBUG_ERR, (__location__ " Unknown database in request. db_id==0x%08x\n", c->db_id)); CTDB_DECREMENT_STAT(ctdb, pending_calls); return; diff --git a/ctdb/server/ctdb_recoverd.c b/ctdb/server/ctdb_recoverd.c index 040cbffe953..84e2081ae56 100644 --- a/ctdb/server/ctdb_recoverd.c +++ b/ctdb/server/ctdb_recoverd.c @@ -395,7 +395,7 @@ static void ctdb_set_culprit_count(struct ctdb_recoverd *rec, struct ctdb_banning_state, len); if (t == NULL) { - DBG_WARNING("Memory allocation error"); + DBG_WARNING("Memory allocation error\n"); return; } rec->banning_state = t; @@ -1943,7 +1943,7 @@ static void force_election(struct ctdb_recoverd *rec) ret = send_election_request(rec); if (ret!=0) { - DBG_ERR("Failed to initiate leader election"); + DBG_ERR("Failed to initiate leader election\n"); return; } diff --git a/lib/crypto/py_crypto.c b/lib/crypto/py_crypto.c index 5b3c307057a..35ccc79a99e 100644 --- a/lib/crypto/py_crypto.c +++ b/lib/crypto/py_crypto.c @@ -131,14 +131,14 @@ static PyObject *py_crypto_arcfour_crypt_blob(PyObject *module, PyObject *args) return result; } -static PyObject *py_crypto_set_relax_mode(PyObject *module) +static PyObject *py_crypto_set_relax_mode(PyObject *module, PyObject *Py_UNUSED(ignored)) { GNUTLS_FIPS140_SET_LAX_MODE(); Py_RETURN_NONE; } -static PyObject *py_crypto_set_strict_mode(PyObject *module) +static PyObject *py_crypto_set_strict_mode(PyObject *module, PyObject *Py_UNUSED(ignored)) { GNUTLS_FIPS140_SET_STRICT_MODE(); diff --git a/lib/dbwrap/dbwrap.c b/lib/dbwrap/dbwrap.c index ee4cdc54f92..19f6c29b069 100644 --- a/lib/dbwrap/dbwrap.c +++ b/lib/dbwrap/dbwrap.c @@ -154,7 +154,7 @@ const char *locked_dbs[DBWRAP_LOCK_ORDER_MAX]; static void debug_lock_order(int level) { int i; - DEBUG(level, ("lock order: ")); + DEBUG(level, ("lock order:")); for (i=0; i<DBWRAP_LOCK_ORDER_MAX; i++) { DEBUGADD(level, (" %d:%s", diff --git a/lib/fuzzing/fuzz_cli_credentials_parse_string.c b/lib/fuzzing/fuzz_cli_credentials_parse_string.c index b71ef357309..0b0f97af261 100644 --- a/lib/fuzzing/fuzz_cli_credentials_parse_string.c +++ b/lib/fuzzing/fuzz_cli_credentials_parse_string.c @@ -25,7 +25,7 @@ char buf[MAX_LENGTH + 1]; const enum credentials_obtained obtained = CRED_UNINITIALISED; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { TALLOC_CTX *mem_ctx = NULL; struct cli_credentials *credentials = NULL; diff --git a/lib/fuzzing/fuzz_dcerpc_parse_binding.c b/lib/fuzzing/fuzz_dcerpc_parse_binding.c index 6eb3c15454d..dcbf4404b10 100644 --- a/lib/fuzzing/fuzz_dcerpc_parse_binding.c +++ b/lib/fuzzing/fuzz_dcerpc_parse_binding.c @@ -24,7 +24,7 @@ char buf[MAX_LENGTH + 1]; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { TALLOC_CTX *mem_ctx = NULL; struct dcerpc_binding *binding = NULL; diff --git a/lib/fuzzing/fuzz_ldap_decode.c b/lib/fuzzing/fuzz_ldap_decode.c index e3bcf7b9d0a..be286ea0cfe 100644 --- a/lib/fuzzing/fuzz_ldap_decode.c +++ b/lib/fuzzing/fuzz_ldap_decode.c @@ -27,7 +27,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { TALLOC_CTX *mem_ctx = talloc_init(__FUNCTION__); struct asn1_data *asn1; diff --git a/lib/fuzzing/fuzz_ldb_ldif_read.c b/lib/fuzzing/fuzz_ldb_comparison_fold.c similarity index 57% copy from lib/fuzzing/fuzz_ldb_ldif_read.c copy to lib/fuzzing/fuzz_ldb_comparison_fold.c index f44e1ea5c43..08b2f590760 100644 --- a/lib/fuzzing/fuzz_ldb_ldif_read.c +++ b/lib/fuzzing/fuzz_ldb_comparison_fold.c @@ -1,5 +1,5 @@ /* - Fuzzing ldb_ldif_read_string + Fuzzing ldb_comparison_fold() Copyright (C) Catalyst IT 2020 This program is free software; you can redistribute it and/or modify @@ -17,40 +17,42 @@ */ #include "includes.h" #include "fuzzing/fuzzing.h" -#include "ldb_private.h" +#include "lib/ldb/include/ldb.h" +#include "lib/ldb/include/ldb_handlers.h" +int LLVMFuzzerInitialize(int *argc, char ***argv) +{ + return 0; +} -#define MAX_LENGTH (2 * 1024 * 1024 - 1) -char buf[MAX_LENGTH + 1] = {0}; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { - struct ldb_ldif *ldif = NULL; - const char *s = NULL; - struct ldb_context *ldb = ldb_init(NULL, NULL); - if (ldb == NULL) { + struct ldb_val v1, v2; + struct ldb_context *ldb = NULL; + + if (len < 2) { return 0; } - - if (len > MAX_LENGTH) { - len = MAX_LENGTH; - } - memcpy(buf, input, len); - buf[len] = 0; - s = buf; - ldif = ldb_ldif_read_string(ldb, &s); + v1.length = PULL_LE_U16(input, 0); + if (v1.length > len - 2) { + /* the exact case of v2.length == 0 is still available */ + return 0; + } + len -= 2; + input += 2; - if(ldif != NULL) { - ldb_ldif_write_string(ldb, ldb, ldif); - ldb_ldif_write_redacted_trace_string(ldb, ldb, ldif); + ldb = ldb_init(NULL, NULL); + if (ldb == NULL) { + return 0; } - TALLOC_FREE(ldb); - return 0; -} + v1.data = talloc_memdup(ldb, input, v1.length); + v2.length = len - v1.length; + v2.data = talloc_memdup(ldb, input + v1.length, v2.length); -int LLVMFuzzerInitialize(int *argc, char ***argv) -{ + ldb_comparison_fold(ldb, ldb, &v1, &v2); + talloc_free(ldb); return 0; } diff --git a/lib/fuzzing/fuzz_ldb_dn_explode.c b/lib/fuzzing/fuzz_ldb_dn_explode.c index e024212301b..0e1560e345e 100644 --- a/lib/fuzzing/fuzz_ldb_dn_explode.c +++ b/lib/fuzzing/fuzz_ldb_dn_explode.c @@ -23,7 +23,7 @@ #define MAX_LENGTH (2 * 1024 * 1024 - 1) char buf[MAX_LENGTH + 1] = {0}; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { struct ldb_dn *dn = NULL; struct ldb_context *ldb = ldb_init(NULL, NULL); diff --git a/lib/fuzzing/fuzz_ldb_ldif_read.c b/lib/fuzzing/fuzz_ldb_ldif_read.c index f44e1ea5c43..3c48b6a2878 100644 --- a/lib/fuzzing/fuzz_ldb_ldif_read.c +++ b/lib/fuzzing/fuzz_ldb_ldif_read.c @@ -23,7 +23,7 @@ #define MAX_LENGTH (2 * 1024 * 1024 - 1) char buf[MAX_LENGTH + 1] = {0}; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { struct ldb_ldif *ldif = NULL; const char *s = NULL; diff --git a/lib/fuzzing/fuzz_ldb_parse_binary_decode.c b/lib/fuzzing/fuzz_ldb_parse_binary_decode.c index feb26e28c82..ac2e436a843 100644 --- a/lib/fuzzing/fuzz_ldb_parse_binary_decode.c +++ b/lib/fuzzing/fuzz_ldb_parse_binary_decode.c @@ -34,7 +34,7 @@ static char * possibly_truncate(uint8_t *input, size_t len) } -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { TALLOC_CTX *mem_ctx = talloc_init(__FUNCTION__); struct ldb_val val = {0}; diff --git a/lib/fuzzing/fuzz_ldb_parse_control.c b/lib/fuzzing/fuzz_ldb_parse_control.c index c78222c3c85..722d9f9a6de 100644 --- a/lib/fuzzing/fuzz_ldb_parse_control.c +++ b/lib/fuzzing/fuzz_ldb_parse_control.c @@ -23,7 +23,7 @@ #define MAX_LENGTH (2 * 1024 * 1024 - 1) char buf[MAX_LENGTH + 1] = {0}; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { struct ldb_control *control = NULL; struct ldb_context *ldb = ldb_init(NULL, NULL); diff --git a/lib/fuzzing/fuzz_ldb_parse_tree.c b/lib/fuzzing/fuzz_ldb_parse_tree.c index e22dd776110..1e649401d53 100644 --- a/lib/fuzzing/fuzz_ldb_parse_tree.c +++ b/lib/fuzzing/fuzz_ldb_parse_tree.c @@ -26,7 +26,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { TALLOC_CTX *mem_ctx = talloc_init(__FUNCTION__); struct ldb_parse_tree *tree; diff --git a/lib/fuzzing/fuzz_lzxpress.c b/lib/fuzzing/fuzz_lzxpress.c index 61ce9e6f9c0..ddc7aa0cd68 100644 --- a/lib/fuzzing/fuzz_lzxpress.c +++ b/lib/fuzzing/fuzz_lzxpress.c @@ -25,7 +25,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { static uint8_t output[1024 * 1024] = {0}; diff --git a/lib/fuzzing/fuzz_lzxpress_compress.c b/lib/fuzzing/fuzz_lzxpress_compress.c index 39e909da8aa..9e5c6474bc7 100644 --- a/lib/fuzzing/fuzz_lzxpress_compress.c +++ b/lib/fuzzing/fuzz_lzxpress_compress.c @@ -25,7 +25,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { static uint8_t output[1024 * 1024] = {0}; diff --git a/lib/fuzzing/fuzz_lzxpress_huffman_compress.c b/lib/fuzzing/fuzz_lzxpress_huffman_compress.c index d92131d3a8b..165244ca8bf 100644 --- a/lib/fuzzing/fuzz_lzxpress_huffman_compress.c +++ b/lib/fuzzing/fuzz_lzxpress_huffman_compress.c @@ -29,7 +29,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) #define MAX_SIZE (1024 * 1024) -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { static uint8_t *output; size_t output_len; diff --git a/lib/fuzzing/fuzz_lzxpress_huffman_decompress.c b/lib/fuzzing/fuzz_lzxpress_huffman_decompress.c index da3a101ca1a..d475ff63cf2 100644 --- a/lib/fuzzing/fuzz_lzxpress_huffman_decompress.c +++ b/lib/fuzzing/fuzz_lzxpress_huffman_decompress.c @@ -28,7 +28,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) static uint8_t output[1024 * 1024] = {0}; -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { size_t target_len; if (len < 4) { diff --git a/lib/fuzzing/fuzz_lzxpress_huffman_round_trip.c b/lib/fuzzing/fuzz_lzxpress_huffman_round_trip.c index b59be438ee9..adb8fbfd88d 100644 --- a/lib/fuzzing/fuzz_lzxpress_huffman_round_trip.c +++ b/lib/fuzzing/fuzz_lzxpress_huffman_round_trip.c @@ -28,7 +28,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { /* * we allow compressed to be 25% bigger than decompressed. diff --git a/lib/fuzzing/fuzz_lzxpress_round_trip.c b/lib/fuzzing/fuzz_lzxpress_round_trip.c index ac38368527e..a4043c258b9 100644 --- a/lib/fuzzing/fuzz_lzxpress_round_trip.c +++ b/lib/fuzzing/fuzz_lzxpress_round_trip.c @@ -25,7 +25,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { static uint8_t compressed[1024 * 1280] = {0}; static uint8_t decompressed[1024 * 1024] = {0}; diff --git a/lib/fuzzing/fuzz_ndr_X.c b/lib/fuzzing/fuzz_ndr_X.c index 3c0fe062d96..a3d7199edc9 100644 --- a/lib/fuzzing/fuzz_ndr_X.c +++ b/lib/fuzzing/fuzz_ndr_X.c @@ -150,7 +150,7 @@ static void ndr_print_nothing(struct ndr_print *ndr, const char *format, ...) } -int LLVMFuzzerTestOneInput(uint8_t *data, size_t size) { +int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { uint8_t type; int pull_push_print_flags; uint16_t fuzz_packet_flags, function; diff --git a/lib/fuzzing/fuzz_nmblib_parse_packet.c b/lib/fuzzing/fuzz_nmblib_parse_packet.c index 85dd823e51c..c8a2d035ef7 100644 --- a/lib/fuzzing/fuzz_nmblib_parse_packet.c +++ b/lib/fuzzing/fuzz_nmblib_parse_packet.c @@ -26,7 +26,7 @@ char buf[MAX_LENGTH + 1]; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { struct packet_struct *p = NULL; struct in_addr ip = { diff --git a/lib/fuzzing/fuzz_oLschema2ldif.c b/lib/fuzzing/fuzz_oLschema2ldif.c index 873e8f1ccc7..3bff8cff578 100644 --- a/lib/fuzzing/fuzz_oLschema2ldif.c +++ b/lib/fuzzing/fuzz_oLschema2ldif.c @@ -29,7 +29,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { TALLOC_CTX *mem_ctx; struct conv_options opt; diff --git a/lib/fuzzing/fuzz_parse_lpq_entry.c b/lib/fuzzing/fuzz_parse_lpq_entry.c index 720cc9b51c0..3537ce5bc06 100644 --- a/lib/fuzzing/fuzz_parse_lpq_entry.c +++ b/lib/fuzzing/fuzz_parse_lpq_entry.c @@ -28,7 +28,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) #define MAX_LENGTH (1024 * 1024) char line[MAX_LENGTH + 1]; -int LLVMFuzzerTestOneInput(uint8_t *input, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *input, size_t len) { enum printing_types printing_type; print_queue_struct pq_buf = {0}; diff --git a/lib/fuzzing/fuzz_reg_parse.c b/lib/fuzzing/fuzz_reg_parse.c index a061cd6294b..bbc62ead79a 100644 --- a/lib/fuzzing/fuzz_reg_parse.c +++ b/lib/fuzzing/fuzz_reg_parse.c @@ -31,7 +31,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv) return 0; } -int LLVMFuzzerTestOneInput(uint8_t *buf, size_t len) +int LLVMFuzzerTestOneInput(const uint8_t *buf, size_t len) { const reg_parse_callback cb = {0}; diff --git a/lib/fuzzing/fuzz_regfio.c b/lib/fuzzing/fuzz_regfio.c index c4ced88801b..588efb0afdd 100644 -- Samba Shared Repository