The branch, master has been updated
via fdd133ae650 smbd: fix sharing access check for directories
from 2065f006560 smbd: convert fsp->posix_flags to
fsp->fsp_flags.posix_open
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit fdd133ae650d13cb457f7e7529f3bb6df47d8cee
Author: Ralph Boehme <[email protected]>
Date: Fri Oct 25 17:22:57 2024 +0200
smbd: fix sharing access check for directories
This was missing from commit 6140c3177a0330f42411618c3fca28930ea02a21 and
causes
all opens of directories to be handled as stat opens, bypassing the
sharemode
check.
Not adding a test at this time, as my (hopefully) soon to be merged
Directory
Leases branch has a test which actually detected this problem.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15732
Signed-off-by: Ralph Boehme <[email protected]>
Reviewed-by: Stefan Metzmacher <[email protected]>
Autobuild-User(master): Ralph Böhme <[email protected]>
Autobuild-Date(master): Tue Oct 29 12:44:49 UTC 2024 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
source3/smbd/open.c | 1 +
1 file changed, 1 insertion(+)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 0d05bd953c0..351b8f8e33e 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -5447,6 +5447,7 @@ static NTSTATUS open_directory(connection_struct *conn,
.req = req,
.create_disposition = create_disposition,
.access_mask = access_mask,
+ .open_access_mask = access_mask,
.share_access = share_access,
.oplock_request = NO_OPLOCK,
.lease = NULL,
--
Samba Shared Repository
