The branch, master has been updated
       via  3987cb0bc35 libnet: Fix Coverity ID 1634803 Dereference after null 
check
      from  50f3273e828 examples:winexe: Initialize Trustee.ptstrName at the 
right time

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 3987cb0bc357602c1fd3f1263813c5a5289b72c5
Author: Volker Lendecke <[email protected]>
Date:   Thu Nov 14 17:09:31 2024 +0100

    libnet: Fix Coverity ID 1634803 Dereference after null check
    
    Signed-off-by: Volker Lendecke <[email protected]>
    Reviewed-by: Ralph Boehme <[email protected]>
    
    Autobuild-User(master): Volker Lendecke <[email protected]>
    Autobuild-Date(master): Thu Nov 14 18:29:46 UTC 2024 on atb-devel-224

-----------------------------------------------------------------------

Summary of changes:
 source4/libnet/libnet_site.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source4/libnet/libnet_site.c b/source4/libnet/libnet_site.c
index 369db586fb9..9ee51f3ee86 100644
--- a/source4/libnet/libnet_site.c
+++ b/source4/libnet/libnet_site.c
@@ -85,7 +85,7 @@ NTSTATUS libnet_FindSite(TALLOC_CTX *ctx, struct 
libnet_context *lctx, struct li
 
                map_netlogon_samlogon_response(resp);
 
-               if ((nt5ex->client_site != NULL) ||
+               if ((nt5ex->client_site != NULL) &&
                    (nt5ex->client_site[0] != '\0'))
                {
                        site_name_str = talloc_strdup(tmp_ctx,


-- 
Samba Shared Repository

Reply via email to