The branch, v4-22-test has been updated
via cd4a7251545 libnet4: free tevent request even on error
via 753c9bfdad9 libnet4: check return value of DC lookup
from f941348890b VERSION: Bump version up to Samba 4.22.0rc2...
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-22-test
- Log -----------------------------------------------------------------
commit cd4a725154562237097f174f23a7f96a58adb989
Author: Björn Baumbach <[email protected]>
Date: Mon Feb 10 17:42:12 2025 +0100
libnet4: free tevent request even on error
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15798
Signed-off-by: Björn Baumbach <[email protected]>
Reviewed-by: Volker Lendecke <[email protected]>
Autobuild-User(master): Björn Baumbach <[email protected]>
Autobuild-Date(master): Tue Feb 11 11:05:37 UTC 2025 on atb-devel-224
(cherry picked from commit 8f72b5673e6a26c5a6a69dbc56e91027d0dabe37)
Autobuild-User(v4-22-test): Jule Anger <[email protected]>
Autobuild-Date(v4-22-test): Wed Feb 12 11:37:37 UTC 2025 on atb-devel-224
commit 753c9bfdad987442b17e3877dbd3f8b384ce34e2
Author: Björn Baumbach <[email protected]>
Date: Fri Feb 7 12:03:18 2025 +0100
libnet4: check return value of DC lookup
Avoids possible segmentation fault when the lookup fails.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15798
Pair-programmed-with: Volker Lendecke <[email protected]>
Signed-off-by: Volker Lendecke <[email protected]>
Signed-off-by: Björn Baumbach <[email protected]>
Reviewed-by: Douglas Bagnall <[email protected]>
Autobuild-User(master): Douglas Bagnall <[email protected]>
Autobuild-Date(master): Sat Feb 8 03:30:27 UTC 2025 on atb-devel-224
(cherry picked from commit c5511056708fb1be3c2e1b2ad61af6643f92051c)
-----------------------------------------------------------------------
Summary of changes:
source4/libnet/libnet_lookup.c | 3 +++
1 file changed, 3 insertions(+)
Changeset truncated at 500 lines:
diff --git a/source4/libnet/libnet_lookup.c b/source4/libnet/libnet_lookup.c
index f8477c7258c..fe021b9f4d8 100644
--- a/source4/libnet/libnet_lookup.c
+++ b/source4/libnet/libnet_lookup.c
@@ -224,6 +224,9 @@ NTSTATUS libnet_LookupDCs_recv(struct tevent_req *req,
TALLOC_CTX *mem_ctx,
struct finddcs finddcs_io;
status = finddcs_cldap_recv(req, mem_ctx, &finddcs_io);
talloc_free(req);
+ if (!NT_STATUS_IS_OK(status)) {
+ return status;
+ }
io->out.num_dcs = 1;
io->out.dcs = talloc(mem_ctx, struct nbt_dc_name);
NT_STATUS_HAVE_NO_MEMORY(io->out.dcs);
--
Samba Shared Repository
