The branch, master has been updated
via c716bf33a53 lib/torture: directly remove the dummy signal event
again to avoid flapping tests
from 1909fa3ca1a smbd: Simplify inotify_handler()
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit c716bf33a53b3f090c7e967da776958b1cd70b72
Author: Stefan Metzmacher <[email protected]>
Date: Wed May 28 22:13:55 2025 +0200
lib/torture: directly remove the dummy signal event again to avoid flapping
tests
I don't know why but commit 57a57a189bd9a7348656990b2c888a328b524bb0:
lib/torture: assert that a test doesn't create new talloc children of
context->ev
introduced the regression thad lead to commit
3fa94d9f2fcb165d435c62badde9e3c8569ff40d:
selftest: mark samba4.rpc.samr.passwords.lockout on ncacn_np with
.samr.lockout as flapping
Doing a TALLOC_FREE(dummy_se) still means we have the
tevent_add_fd() from tevent_common_wakeup_init() cached as
talloc child of tevent_context and that is all we need here
and the test is not flagging anymore.
Signed-off-by: Stefan Metzmacher <[email protected]>
Reviewed-by: Ralph Boehme <[email protected]>
Autobuild-User(master): Stefan Metzmacher <[email protected]>
Autobuild-Date(master): Mon Jun 2 19:13:27 UTC 2025 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
lib/torture/torture.c | 2 ++
selftest/flapping.d/samba4.rpc.samr.passwords | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
delete mode 100644 selftest/flapping.d/samba4.rpc.samr.passwords
Changeset truncated at 500 lines:
diff --git a/lib/torture/torture.c b/lib/torture/torture.c
index 78caaa8c9ba..930b6036325 100644
--- a/lib/torture/torture.c
+++ b/lib/torture/torture.c
@@ -605,6 +605,7 @@ static bool internal_torture_run_test(struct
torture_context *_context,
TALLOC_FREE(frame);
return false;
}
+ TALLOC_FREE(dummy_se);
evtb1 = talloc_total_blocks(context->ev);
}
@@ -728,6 +729,7 @@ bool torture_run_tcase_restricted(struct torture_context
*_context,
context = _context;
goto setup_failed;
}
+ TALLOC_FREE(dummy_se);
evtb1 = talloc_total_blocks(context->ev);
diff --git a/selftest/flapping.d/samba4.rpc.samr.passwords
b/selftest/flapping.d/samba4.rpc.samr.passwords
deleted file mode 100644
index 85618be9a08..00000000000
--- a/selftest/flapping.d/samba4.rpc.samr.passwords
+++ /dev/null
@@ -1 +0,0 @@
-^samba4.rpc.samr.passwords.lockout on ncacn_np with
.samr.lockout\(ad_dc_slowtests\)
--
Samba Shared Repository
