The branch, v4-22-test has been updated
       via  f186da9fabf Add check for the GPO link to have at least two 
attributes separated by semicolumn. Allows to handle empty links.
       via  69cccd4c18c WHATSNEW: fix typo
      from  ef1a5896a11 VERSION: Bump version up to Samba 4.22.4...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-22-test


- Log -----------------------------------------------------------------
commit f186da9fabf16799352d130f4335971441f0475e
Author: Aleksandr Sharov <[email protected]>
Date:   Fri Jul 4 15:32:28 2025 +0200

    Add check for the GPO link to have at least two attributes separated by 
semicolumn. Allows to handle empty links.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=15877
    RN: Fix handling of empty GPO link
    
    Singed-off-by: Alex Sharov ([email protected])
    Reviewed-by: Douglas Bagnall <[email protected]>
    Reviewed-by: Andreas Schneider <[email protected]>
    
    Autobuild-User(master): Andreas Schneider <[email protected]>
    Autobuild-Date(master): Thu Jul 10 18:55:33 UTC 2025 on atb-devel-224
    
    (cherry picked from commit 44ee31c0258b0afb3d3f2ce17942cc86e308a690)
    
    Autobuild-User(v4-22-test): Jule Anger <[email protected]>
    Autobuild-Date(v4-22-test): Thu Jul 17 10:48:14 UTC 2025 on atb-devel-224

commit 69cccd4c18c55ea9d4181add16a4f705dc1fe537
Author: Jule Anger <[email protected]>
Date:   Thu Jul 17 11:38:11 2025 +0200

    WHATSNEW: fix typo
    
    Found by script/codespell.sh.
    
    Signed-off-by: Jule Anger <[email protected]>

-----------------------------------------------------------------------

Summary of changes:
 WHATSNEW.txt               | 2 +-
 python/samba/gp/gpclass.py | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 57d9133b43f..f02cc224d48 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -57,7 +57,7 @@ o  Stefan Metzmacher <[email protected]>
      calls like netr_DsRGetDCName.
 
 o  Andreas Schneider <[email protected]>
-   * BUG 15869: Startup messages of rpc deamons fills /var/log/messages.
+   * BUG 15869: Startup messages of rpc daemons fills /var/log/messages.
 
 
 #######################################
diff --git a/python/samba/gp/gpclass.py b/python/samba/gp/gpclass.py
index d86aacec138..07b4fb3e7bd 100644
--- a/python/samba/gp/gpclass.py
+++ b/python/samba/gp/gpclass.py
@@ -673,8 +673,10 @@ class GP_LINK:
         self.gp_opts = int(gPOptions)
 
     def gpo_parse_gplink(self, gPLink):
+        # normally formed link looks like [LDAP://host/path;options]
+        # empty link looks like [ ]
         for p in gPLink.decode().split(']'):
-            if not p:
+            if not p or ';' not in p:
                 continue
             log.debug('gpo_parse_gplink: processing link')
             p = p.lstrip('[')


-- 
Samba Shared Repository

Reply via email to