The branch, master has been updated
via 46989fb6e74 s3:passdb: Fix CIDs 1596750,1596751 uninitialized
pointer read
from 0ef50512489 libcli/security: use talloc_free at the end of sub-tests
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 46989fb6e74e2efed166c80f06174a10ac4daaf4
Author: Michael Adam <[email protected]>
Date: Wed Aug 6 11:27:48 2025 +0200
s3:passdb: Fix CIDs 1596750,1596751 uninitialized pointer read
This fixes two coverity issues of type
CID 1596750 - uninitialized pointer read
CID 1596751 - uninitialized pointer read
It fixes one occurrence in each of
pdb_samba_dsdb_create_user and pdb_samba_dsdb_create_alias
Signed-off-by: Michael Adam <[email protected]>
Reviewed-by: Alexander Bokovoy <[email protected]>
Reviewed-by: Rabinarayan Panigrahi <[email protected]>
Reviewed-by: Shachar Sharon <[email protected]>
Autobuild-User(master): Anoop C S <[email protected]>
Autobuild-Date(master): Thu Aug 7 11:20:25 UTC 2025 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
source3/passdb/pdb_samba_dsdb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
index 0678f7516d1..96d9819316b 100644
--- a/source3/passdb/pdb_samba_dsdb.c
+++ b/source3/passdb/pdb_samba_dsdb.c
@@ -768,7 +768,7 @@ static NTSTATUS pdb_samba_dsdb_create_user(struct
pdb_methods *m,
{
struct pdb_samba_dsdb_state *state = talloc_get_type_abort(
m->private_data, struct pdb_samba_dsdb_state);
- struct dom_sid *sid;
+ struct dom_sid *sid = NULL;
struct ldb_dn *dn;
NTSTATUS status;
TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
@@ -1582,7 +1582,7 @@ static NTSTATUS pdb_samba_dsdb_create_alias(struct
pdb_methods *m,
TALLOC_CTX *frame = talloc_stackframe();
struct pdb_samba_dsdb_state *state = talloc_get_type_abort(
m->private_data, struct pdb_samba_dsdb_state);
- struct dom_sid *sid;
+ struct dom_sid *sid = NULL;
struct ldb_dn *dn;
NTSTATUS status;
--
Samba Shared Repository
