The branch, master has been updated
via e5b00b6511b passdb: Fixing CID 1509029 for time_t in DEBUG statement
from 98755a26fac nsswitch/libwbclient: Fix CID #1034858, #1034859,
#1034860 Resource leak
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit e5b00b6511b53cefe4c7d9bc3db35b4cd8a0e75b
Author: Rabinarayan Panigrahi <[email protected]>
Date: Wed Sep 17 17:02:26 2025 +0530
passdb: Fixing CID 1509029 for time_t in DEBUG statement
In the most likely scenario of time_t being 64 bit signed, we do the
typecast to intmax_t to also log negative values correctly.
Signed-off-by: Rabinarayan Panigrahi <[email protected]>
Reviewed-by: Andreas Schneider <[email protected]>
Reviewed-by: Douglas Bagnall <[email protected]>
Reviewed-by: Anoop C S <[email protected]>
Reviewed-by: Vinit Agnihotri <[email protected]>
Autobuild-User(master): Anoop C S <[email protected]>
Autobuild-Date(master): Wed Sep 24 06:44:50 UTC 2025 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
source3/passdb/pdb_ldap.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c
index 4ab387b5a5c..73830d45fd6 100644
--- a/source3/passdb/pdb_ldap.c
+++ b/source3/passdb/pdb_ldap.c
@@ -1087,17 +1087,17 @@ static bool init_sam_from_ldap(struct ldapsam_privates
*ldap_state,
/* see if we have newer updates */
if (!login_cache_read(sampass, &cache_entry)) {
- DEBUG (9, ("No cache entry, bad count = %u, bad time = %u\n",
+ DEBUG (9, ("No cache entry, bad count = %u, bad time = %jd\n",
(unsigned int)pdb_get_bad_password_count(sampass),
- (unsigned int)pdb_get_bad_password_time(sampass)));
+ (intmax_t)pdb_get_bad_password_time(sampass)));
ret = true;
goto fn_exit;
}
- DEBUG(7, ("ldap time is %u, cache time is %u, bad time = %u\n",
- (unsigned int)ldap_entry_time,
- (unsigned int)cache_entry.entry_timestamp,
- (unsigned int)cache_entry.bad_password_time));
+ DEBUG(7, ("ldap time is %jd, cache time is %jd, bad time = %jd\n",
+ (intmax_t)ldap_entry_time,
+ (intmax_t)cache_entry.entry_timestamp,
+ (intmax_t)cache_entry.bad_password_time));
if (ldap_entry_time > cache_entry.entry_timestamp) {
/* cache is older than directory , so
--
Samba Shared Repository
