The branch, master has been updated
via 90c806d3083 s3:utils:status_json fix Non-boolean returned
via a7e7a68b80c s4:client:http_test fix Non-boolean returned
from 4d638f2101f s3:tests: Use awk for parsing hexkeys
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 90c806d3083d4e88d8c6626becd50b322117f213
Author: Gary Lockyer <[email protected]>
Date: Thu Jan 15 16:10:04 2026 +1300
s3:utils:status_json fix Non-boolean returned
Fix cppcheck
source3/utils/status_json.c:1385:3: style: Non-boolean value returned
from function returning bool [returnNonBoolInBooleanFunction]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924
Signed-off-by: Gary Lockyer <[email protected]>
Reviewed-by: Douglas Bagnall <[email protected]>
Reviewed-by: Anoop C S <[email protected]>
Autobuild-User(master): Anoop C S <[email protected]>
Autobuild-Date(master): Thu Jan 15 09:18:21 UTC 2026 on atb-devel-224
commit a7e7a68b80cbf7fec83e75cc592cda0bcdfb3766
Author: Gary Lockyer <[email protected]>
Date: Thu Jan 15 16:08:22 2026 +1300
s4:client:http_test fix Non-boolean returned
fix cppcheck
source4/client/http_test.c:85:3: style: Non-boolean value returned from
function returning bool [returnNonBoolInBooleanFunction]
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924
Signed-off-by: Gary Lockyer <[email protected]>
Reviewed-by: Douglas Bagnall <[email protected]>
Reviewed-by: Anoop C S <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
source3/utils/status_json.c | 2 +-
source4/client/http_test.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/status_json.c b/source3/utils/status_json.c
index fba0f40508f..169cea69960 100644
--- a/source3/utils/status_json.c
+++ b/source3/utils/status_json.c
@@ -1383,7 +1383,7 @@ bool print_notify_rec_json(struct traverse_state *state,
TALLOC_CTX *tmp_ctx = talloc_stackframe();
if (tmp_ctx == NULL) {
- return -1;
+ return false;
}
sub_json = json_new_object();
diff --git a/source4/client/http_test.c b/source4/client/http_test.c
index 158b2d1a8df..b2c4c04cb85 100644
--- a/source4/client/http_test.c
+++ b/source4/client/http_test.c
@@ -82,7 +82,7 @@ static bool send_http_request(TALLOC_CTX *mem_ctx,
response_size);
if (!req) {
DBG_ERR("no memory\n");
- return -1;
+ return false;
}
if (!tevent_req_set_endtime(req, ev_ctx, timeval_current_ofs(10, 0))) {
--
Samba Shared Repository
