The branch, master has been updated
via e2825363b3a printing: Fix compilation error for native 32-bit time_t
from 52c67b07210 s3:libads: Do not reduce the page size in case of
immediate timeouts
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit e2825363b3accd01e2f5db033c8a0de0e7f532f9
Author: Michael Tokarev <[email protected]>
Date: Wed Jan 21 10:35:15 2026 +0530
printing: Fix compilation error for native 32-bit time_t
commit#e9a7dce599eb12d broke samba compilation for 32-bit time_t.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15976
Used correct pointer type to fix the warning to fix compialtion.
Pair-Programmed-With: Vinit Agnihotri <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
Signed-off-by: Vinit Agnihotri <[email protected]>
Reviewed-by: Günther Deschner <[email protected]>
Reviewed-by: Volker Lendecke <[email protected]>
Autobuild-User(master): Volker Lendecke <[email protected]>
Autobuild-Date(master): Wed Jan 21 19:23:29 UTC 2026 on atb-devel-224
-----------------------------------------------------------------------
Summary of changes:
source3/printing/printing.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/printing/printing.c b/source3/printing/printing.c
index a9e8422efab..bcfd893456b 100644
--- a/source3/printing/printing.c
+++ b/source3/printing/printing.c
@@ -59,6 +59,7 @@ static int fetch_share_cache_time(const char *key_name,
time_t *curr_time)
{
char *key = NULL;
+ int64_t curr_time64 = -1;
key = talloc_asprintf(NULL, "%s/%s", key_name, sharename);
if (key == NULL) {
@@ -66,11 +67,12 @@ static int fetch_share_cache_time(const char *key_name,
return -1;
}
- if (tdb_fetch_int64(tdb, key, curr_time) != 0) {
+ if (tdb_fetch_int64(tdb, key, &curr_time64) != 0) {
DBG_ERR("No timing record found for[%s]!\n", sharename);
TALLOC_FREE(key);
return -1;
}
+ *curr_time = curr_time64;
TALLOC_FREE(key);
return 0;
@@ -82,6 +84,7 @@ static int update_share_cache_time(const char *key_name,
time_t curr_time)
{
char *key = NULL;
+ int64_t curr_time64 = curr_time;
key = talloc_asprintf(NULL, "%s/%s", key_name, sharename);
if (key == NULL) {
@@ -89,7 +92,7 @@ static int update_share_cache_time(const char *key_name,
return -1;
}
- if (tdb_store_int64(tdb, key, (int64_t)curr_time) != 0) {
+ if (tdb_store_int64(tdb, key, curr_time64) != 0) {
DBG_ERR("Unable to update print cache for %s\n", sharename);
TALLOC_FREE(key);
return -1;
--
Samba Shared Repository
