On Fri, May 24, 2002 at 11:27:39AM +1000, Tim Potter wrote: > On Fri, May 24, 2002 at 11:17:59AM +1000, Andrew Bartlett wrote: > > > > Anyway - that looks like a good patch. I've been dying to get rid of all > > > those silly make_nmb_name() calls everywhere but was not brave enough. > > > > I'll proabably add a cli_pipe_connection() function (feel free to suggest > > a better name) that just calls cli_full_connection, but with IPC$ implicit > > and instead specifying the pipe to setup. > > > > How does that sound? > > Sounds good to me. > > One point - is there any reason to pass around the password and the > length of the password to cli_full_connection()?
Not really. Just habit - it is always a null terminated ASCII (or utf8 actually) password. (and everyobdy is just doing strlen for that param anyway...) I'll kill it. Andrew Bartlett