The problem I reported would occur with Samba 2.2.4, but not 2.2.2.  set_sd() in 2.2.4 
returns False if the sd_len passed by the client is 0.  This would be okay, except 
Novell clients apparently set sd_len=0. 

To fix the novell problem, I changed set_sd() to return True, not False if sd_len==0.  
I never got a response on why this code was added to 2.2.4.

-Dan Barrett

static BOOL set_sd(files_struct *fsp, char *data, uint32 sd_len, uint32 
security_info_sent, int *pdef_class,uint32 *pdef_code)
{
        prs_struct pd;
        SEC_DESC *psd = NULL;
        TALLOC_CTX *mem_ctx;
        BOOL ret;


        /* Stock Samba fails if sd_len==0, but some Novell client copies pass SMB 
requests with valid EA info, but no SD.  We want to allow these types of opens.*/  
        if (sd_len == 0) {
                DEBUG(5,("set_sd: sd_len==0. Allowing anyway.\n"));
                *pdef_class = 0;
                *pdef_code = 0;
                return True;
        }

.....

-----Original Message-----
From: Wade Turland [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, June 05, 2002 10:44 PM
To: [EMAIL PROTECTED]
Subject: Problem copying files from Win2k Novell client to Samba
(repost)


The original message was posted by Dan Barrett:
http://lists.samba.org/pipermail/samba-technical/2002-May/036397.html

I'm getting reports of similar problems. Nobody responded before - can
anyone help?

Wade.

-- 
/==============================================================\
|  Wade Turland                  | Locked Bag 1797             |
|  Unix Administrator            | Penrith South DC NSW 1797   |
|  University of Western Sydney  | Phone: +61 2 4736 0806      |
|  Room V137 (Kingswood)         | Fax:   +61 2 4736 0010      |
\==============================================================/
When I heated my home with oil, I used an average of 800 gallons a
year.  I have found that I can keep comfortably warm for an entire
winter with slightly over half that quantity of beer.
                -- Dave Barry, "Postpetroleum Guzzler"



Reply via email to