Jelmer Vernooij wrote: > > Hi, > > Here's my latest patch for today :-). This one brings: > > - convert lp_passdb_backend() parameter to a list
Looks ok. > - fix bug in sid_copy(), which crashed whenever a NULL pointer was > given as an argument. (sometimes caused errors when user doesn't > have access to secrets.tdb) What is the point of this? I see that it won't dereference that null any more, but you really need to actually check that return value now. Either that, or (and this may well be the better approach) simply check that the paramaters are not null in the caller - becouse 95% of the time you *know* its a valid sid. (So add the check to the code that is reading it from secrets.tdb). Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
