This patch is definitely good. I'd like to see it tested more and also see
it be rewritten to gracefully handle unexpected content. That's probably
premature until we get a little more testing. It might still be a good
idea to check it into HEAD.
Anthony Liguori
Linux/Active Directory Interoperability
Linux Technology Center (LTC) - IBM Austin
E-mail: [EMAIL PROTECTED]
Phone: (512) 838-1208
Tie Line: 678-1208
Chere Zhou
<[EMAIL PROTECTED] To: Anthony
Liguori/Austin/[EMAIL PROTECTED]
> cc: Jim McDonough/Portland/[EMAIL
PROTECTED],
[EMAIL PROTECTED]
02/25/2003 02:03 Subject: Re: [PATCH] Re: 3.0a21: "net
ads lookup" for a
PM child domain got messy output
Please respond to
qzhou
How about this new patch (as in the attachment). The change I made from
your
patch, is to add the while loop in pull_c_zero_string which was adopted
from
pull_dotted_string. Now my domains are all happy. Otherwise, a grandchild
domain complains.
I am posting this to samba-technical list, since I though it was what you
intended to do, and we might get more testing of this.
Chere
On Monday 24 February 2003 01:21 pm, Anthony Liguori wrote:
> Lotus Notes won't let me send patches to the samba-technical list anymore
> (I've got to get a forwarding account it seems) but I haven't tested this
> patch enough to apply it to HEAD anyway.
>
> I know it works with your traffic though as I used your dumps as test
data.
> This patch gives a _lot_ more information and makes various fixes.
>
> Note: the patch you submitted to the list doesn't actually work for
domain
> controllers without forests. The 0xc0 stuff are deliminators for these
> strings.
>
> Let me know how this patch works out for you:
>
> (See attached file: net_ads_lookup.patch)
>
> Anthony Liguori
> Linux/Active Directory Interoperability
> Linux Technology Center (LTC) - IBM Austin
> E-mail: [EMAIL PROTECTED]
> Phone: (512) 838-1208
> Tie Line: 678-1208
>
>
>
#### patch-net-ads-lookup has been removed from this note on February 26,
2003 by Anthony Liguori
