On Fri, Nov 14, 2008 at 10:33:19AM +0100, Volker Lendecke wrote: > On Thu, Nov 13, 2008 at 03:50:59PM -0800, Jeremy Allison wrote: > > On Thu, Nov 13, 2008 at 11:54:55PM +0100, Volker Lendecke wrote: > > You'll have to re-add the memcache_is_talloc() > > function (which I deleted :-). > > If you're okay with it, I would re-add it. :-)
Sure, it would make sense again :-). > Except that using void ** as a function parameter is not > portable C. This would need to be void *, cast to void ** > inside the function. But this would blur the nature of that > parameter. Yeah, but it's C, so what can you do :-). Good catch. Don't like non-portable C. Maybe we can add the void ** as a comment in the parameter list after the void * parameter. e.g. /* This is really void ** */ > We have the same with talloc_move, here it is also not > visible from the function parameter that we have a > TALLOC_CTX **, so we probably have to live with the fact > that the function prototype is non-intuitive. C just sucks > in this respect :-) I'm happy with your change, please commit ! Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba