Hi Adam, in this case it is not sufficient to just apply the patches since the are applied to the template file. These are transformed to the proper files (samba.spec, makerpms.sh) by the script release-scripts/create-tarball.
Since it is no good to call create-tarball from the unpacked tarball, I have attached a script for you that you should call from the base dir of the unpacked tarball and that will update the specfile and makerpms.sh for you. I think I am going to check this into relevant branches. Thanks for your feedback. Cheers - Michael Adam Williams wrote: > Karolin Seeger wrote: > >yes, three patches concerning RHEL packaging will be included. > >These patches fix the problem for me. Please report if it they don't work > >for you. > > > >Please find attached the patches. > > > >Karolin > > > Hi Karolin, thanks for the response. I apologize if I sounded rude in > my last message. I applied the patches as follows: > > [r...@roark samba-3.2.7]# patch > -p1<0001-packaging-RHEL-fix-build-of-u-mount.cifs.patch > (Stripping trailing CRs from patch.) > patching file packaging/RHEL/samba.spec.tmpl > [r...@roark samba-3.2.7]# patch > -p1<0001-packaging-RHEL-Fix-syntax-error-in-samba.spec.tmpl.patch > (Stripping trailing CRs from patch.) > patching file packaging/RHEL/samba.spec.tmpl > [r...@roark samba-3.2.7]# patch > -p1<0002-packaging-RHEL-fix-typo-in-u-mount.cifs-installat.patch > (Stripping trailing CRs from patch.) > patching file packaging/RHEL/samba.spec.tmpl > Hunk #1 succeeded at 244 (offset -1 lines). > > > but I still get the same error with makerpms.sh: > > > Linking shared library bin/libnetapi.so.0 > make: Nothing to be done for `pam_smbpass'. > Linking shared library bin/libsmbclient.so.0 > Linking bin/net > + cd client > + gcc -o mount.cifs -O2 -g -D_GNU_SOURCE -Wall -D_GNU_SOURCE > -D_LARGEFILE64_SOURCE mount.cifs.c > /tmp/ccXRkvaz.o: In function `main': > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1415: > undefined reference to `unlock_mtab' > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1416: > undefined reference to `lock_mtab' > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1462: > undefined reference to `unlock_mtab' > /root/rpmbuild/BUILD/samba-3.2.7/source/client/mount.cifs.c:1424: > undefined reference to `unlock_mtab' > collect2: ld returned 1 exit status > error: Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > > > RPM build errors: > Bad exit status from /var/tmp/rpm-tmp.vzKfgV (%build) > makerpms.sh: Done. -- Michael Adam <m...@sernet.de> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-370000-0, fax: +49-551-370000-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.SerNet.DE, mailto: Info @ SerNet.DE
pgpTzCPw7BZEu.pgp
Description: PGP signature
-- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
