[ http://issues.apache.org/jira/browse/SANDESHA2-28?page=all ]
Matt Lovett updated SANDESHA2-28:
---------------------------------
Attachment: clean.patch
Patch as described above
> Correct typos in nls message keys, and add trace, general cleanup
> -----------------------------------------------------------------
>
> Key: SANDESHA2-28
> URL: http://issues.apache.org/jira/browse/SANDESHA2-28
> Project: Apache Sandesha2
> Issue Type: Bug
> Reporter: Matt Lovett
> Priority: Minor
> Attachments: clean.patch
>
>
> The patch I'm about to attach fixes up some typos in the nls keys file. I
> also introduced trace into a couple of classes. Finally I trimmed out some
> unused code that I came across.
> The only parts that have any real impact on the logic are:
> 1) In SandeshaOutHander, I stopped applying RM to fault messages. I did this
> because some of my tests were causing sandesha to throw exceptions during
> create sequence processing on the service side. Without this change the
> handlers try to establish an outbound sequence for the fault message, and
> that hits exactly the same error... throwing another exception. The requester
> ended up without a useful soap fault. Making this change allows the fault to
> travel back to the requester.
> If you don't like the look of this change then we can ignore that bit for
> now. I think we should probably add in some more testcases to exercise the
> fault paths anyway.
> 2) In the Invoker, the code that randomly picks a sequence threw exceptions
> whenever the list has no entries, we called Random::nextInt(0). I changed the
> code to handle the empty list, and also made it round-robin over the
> sequences, which should be less likely to starve unlucky sequences.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
