[ http://issues.apache.org/jira/browse/SANDESHA2-38?page=comments#action_12446872 ] Matt Lovett commented on SANDESHA2-38: --------------------------------------
Hi Chamikara, I'm sorry, I guess I was a bit sloppy - I folded in some cleanup at the same time. Now that we are using Operations that have been located within the AxisService instead of 'new'ing them up each time we need a lot less copying of properties etc. I believe the change is safe - it didn't break any of the unit tests. If you know of some properties that do need to be copied, perhaps we can some up with a cleaner way of handing them without blindly copying everything - perhaps a new plug point would make sense. Equally, it's not critical to clean those methods up right now, so if you like you could apply the rest of the patch. It will work either way. Thanks Matt > Extend SecurityManager to add 'apply' method > -------------------------------------------- > > Key: SANDESHA2-38 > URL: http://issues.apache.org/jira/browse/SANDESHA2-38 > Project: Apache Sandesha2 > Issue Type: Improvement > Reporter: Matt Lovett > Attachments: apply.patch > > > We have an implementation of the SecurityManager that needs to put some > token-related properties > onto the message context for each RM message. The obvious way to achieve this > is to add a new > method like: > public void apply(SecurityToken token, MessageContext outboundMessage) > to the SecurityManager interface. > I'll attach a patch that does this, as well as fix up the various > SecurityManager impls. I'll also take the > chance to beef up the UnitTestSecurityManager so that it uses 'apply' to add > a header into the message, > which allows us to implement a better 'checkProofOfPossession' method. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
