[
https://issues.apache.org/jira/browse/SANDESHA2-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gatford resolved SANDESHA2-137.
--------------------------------------
Resolution: Fixed
Fixed in revision 618392
> Make storage bean cleaner to implement DB persistence
> -----------------------------------------------------
>
> Key: SANDESHA2-137
> URL: https://issues.apache.org/jira/browse/SANDESHA2-137
> Project: Sandesha2
> Issue Type: Improvement
> Environment: all
> Reporter: Francois Mireaux
> Priority: Minor
> Attachments: sandesha2-storage.patch
>
>
> Storage beans (RMSBean, RMDBean...) define constants for flags fields
> (flags, rmsflags, rmdflags...) used in the match method. But those constants
> are private and so unable to be used in DataBase BeanManagers for matching in
> DB instead of in memory. The best solution seems to declare those constants
> as public, see the proposed patch attached :
> Index:
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/InvokerBean.java
> ===================================================================
> ---
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/InvokerBean.java
> (revision 616663)
> +++
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/InvokerBean.java
> (working copy)
> @@ -61,7 +61,7 @@
> * be ignored within the match method.
> */
> private int flags = 0;
> - private static final int MSG_NO_FLAG = 0x00000001;
> + public static final int MSG_NO_FLAG = 0x00000001;
>
> public InvokerBean() {
>
> Index:
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMDBean.java
> ===================================================================
> ---
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMDBean.java
> (revision 616663)
> +++
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMDBean.java
> (working copy)
> @@ -81,8 +81,8 @@
> * be ignored within the match method.
> */
> private int rmdFlags = 0;
> - private static final int NEXT_MSG_NO_FLAG = 0x00000001;
> - private static final int HIGHEST_IN_MSG_FLAG = 0x00000010;
> + public static final int NEXT_MSG_NO_FLAG = 0x00000001;
> + public static final int HIGHEST_IN_MSG_FLAG = 0x00000010;
>
> public RMDBean() {
> }
> Index:
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMSBean.java
> ===================================================================
> ---
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMSBean.java
> (revision 616663)
> +++
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMSBean.java
> (working copy)
> @@ -152,17 +152,17 @@
> * be ignored within the match method.
> */
> private int rmsFlags = 0;
> - private static final int LAST_SEND_ERROR_TIME_FLAG = 0x00000001;
> - private static final int LAST_OUT_MSG_FLAG = 0x00000010;
> - private static final int HIGHEST_OUT_MSG_FLAG = 0x00000100;
> - private static final int NEXT_MSG_NUM_FLAG = 0x00001000;
> - private static final int TERMINATE_ADDED_FLAG = 0x00010000;
> - private static final int TIMED_OUT_FLAG = 0x00100000;
> - private static final int SEQ_CLOSED_CLIENT_FLAG = 0x01000000;
> - private static final int ACKED_MESSAGES_FLAG = 0x10000000;
> - private static final int TERM_PAUSER_FOR_CS = 0x00000002;
> - private static final int EXPECTED_REPLIES = 0x00000020;
> - private static final int SOAP_VERSION_FLAG = 0x00000200;
> + public static final int LAST_SEND_ERROR_TIME_FLAG = 0x00000001;
> + public static final int LAST_OUT_MSG_FLAG = 0x00000010;
> + public static final int HIGHEST_OUT_MSG_FLAG = 0x00000100;
> + public static final int NEXT_MSG_NUM_FLAG = 0x00001000;
> + public static final int TERMINATE_ADDED_FLAG = 0x00010000;
> + public static final int TIMED_OUT_FLAG = 0x00100000;
> + public static final int SEQ_CLOSED_CLIENT_FLAG = 0x01000000;
> + public static final int ACKED_MESSAGES_FLAG = 0x10000000;
> + public static final int TERM_PAUSER_FOR_CS = 0x00000002;
> + public static final int EXPECTED_REPLIES = 0x00000020;
> + public static final int SOAP_VERSION_FLAG = 0x00000200;
>
> public RMSBean() {
> }
> Index:
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMSequenceBean.java
> ===================================================================
> ---
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMSequenceBean.java
> (revision 616663)
> +++
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/RMSequenceBean.java
> (working copy)
> @@ -88,10 +88,10 @@
> * be ignored within the match method.
> */
> private int flags = 0;
> - private static final int LAST_ACTIVATED_TIME_FLAG = 0x00000001;
> - private static final int CLOSED_FLAG = 0x00000010;
> - private static final int TERMINATED_FLAG = 0x00000100;
> - private static final int POLLING_MODE_FLAG = 0x00001000;
> + public static final int LAST_ACTIVATED_TIME_FLAG = 0x00000001;
> + public static final int CLOSED_FLAG = 0x00000010;
> + public static final int TERMINATED_FLAG = 0x00000100;
> + public static final int POLLING_MODE_FLAG = 0x00001000;
>
> public RMSequenceBean() {
>
> Index:
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/SenderBean.java
> ===================================================================
> ---
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/SenderBean.java
> (revision 616663)
> +++
> modules/core/src/main/java/org/apache/sandesha2/storage/beans/SenderBean.java
> (working copy)
> @@ -128,15 +128,15 @@
> * be ignored within the match method.
> */
> private int flags = 0;
> - private static final int SEND_FLAG = 0x00000001;
> - private static final int SEND_COUNT_FLAG = 0x00000010;
> - private static final int MSG_NUMBER_FLAG = 0x00000100;
> - private static final int RESEND_FLAG = 0x00001000;
> - private static final int TIME_TO_SEND_FLAG = 0x00010000;
> - private static final int MSG_TYPE_FLAG = 0x00100000;
> - private static final int LAST_MSG_FLAG = 0x01000000;
> - private static final int IN_MSG_NUM_FLAG = 0x10000000;
> - private static final int TRANSPORT_FLAG = 0x00000002;
> + public static final int SEND_FLAG = 0x00000001;
> + public static final int SEND_COUNT_FLAG = 0x00000010;
> + public static final int MSG_NUMBER_FLAG = 0x00000100;
> + public static final int RESEND_FLAG = 0x00001000;
> + public static final int TIME_TO_SEND_FLAG = 0x00010000;
> + public static final int MSG_TYPE_FLAG = 0x00100000;
> + public static final int LAST_MSG_FLAG = 0x01000000;
> + public static final int IN_MSG_NUM_FLAG = 0x10000000;
> + public static final int TRANSPORT_FLAG = 0x00000002;
>
> public SenderBean() {
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
