Elfyn McBratney <[EMAIL PROTECTED]> tapota : > Hello Mathieu, > > On Wednesday 22 Sep 2004 17:17, Mathieu Roy wrote: >> Elfyn McBratney <[EMAIL PROTECTED]> tapota : >> > Hello, >> > >> > I've started receiving this a couple of times from trackers @ savannah. >> > (For example, see >> > <http://savannah.gnu.org/support/?func=detailitem&item_id=103384>) >> > Is this a known bug? (I couldn't find anything, but to be honest I'm a >> > tad tired...) >> > >> > If not, I'll hack a look around.. >> > >> > Thanks, >> > Elfyn >> > >> >> [...] >> >> ------------------ Additional Follow-up Comments >> >> -------------------------- [(Error - Not Found)] >> >> I've looked around, and without root on lists.gnu, we can't fix it. >> >> Excelated to <sysadmin -AT- gnu -DOT- org>. >> >> Never seen that bug but I guess it looks for "Comment Type" and think >> it found one (god knows why), add the appropriate [ ] and >> finally... include within "(Error - Not Found)" as there's no comment >> type use. >> >> The file to check is frontend/php/include/trackers/format.php (or >> show.php) > > and data.php ;-) > > ./trackers/data.php:2104 if ($result && db_numrows($result) > 0) > ./trackers/data.php:2105 { > ./trackers/data.php:2106 return db_result($result,0,'value'); > ./trackers/data.php:2107 } > ./trackers/data.php:2108 > ./trackers/data.php:2109 # No value found for this value id !!! > ./trackers/data.php:2110 return $value_id.'(Error - Not Found)'; > ./trackers/data.php:2111 > ./trackers/data.php:2112 } >
Interesting. > > Is it ok if I commit a fix for this (attached) given the release >freeze? :-) Actually, discussion on the patch would be better, as I >may have not understood the rationale... I'm afraid a breaking other things, since I think in some place we expect the return to be (Error - Not Found) in case of error. (it's not clean but we can change it later) I already made a little change that makes the format function working truly similarly when it formats email than webpage (assuming that webpages was working right). I made some tests, not to heavy, and it seems to be working. So if my change works, I would rather lets things as they are for this release. -- Mathieu Roy +---------------------------------------------------------------------+ | General Homepage: http://yeupou.coleumes.org/ | | Computing Homepage: http://alberich.coleumes.org/ | | Not a native english speaker: | | http://stock.coleumes.org/doc.php?i=/misc-files/flawed-english | +---------------------------------------------------------------------+ _______________________________________________ Savane-dev mailing list [EMAIL PROTECTED] https://mail.gna.org/listinfo/savane-dev
