Tuesday 22 November, vers 20h, Tobias Toedter tapota :
>
> On Tuesday 22 November 2005 19:17, Mathieu Roy wrote:
> > I believe the following bit of code do the trick already:
> >
> >
> > > The installation configured a specific date format. This is not
> > > nice this will prevent locales from being used
> > if ($sys_datefmt)
> > {
> > return strftime($sys_datefmt, $timestamp);
> > }
> >
> > If $sys_datefmt is set, we actually don't care about arguments,
> > apart from the timestamp.
>
> Alright, although there are two more calls which don't conform to
> either the old or the new format:
>
> files/index.php:156
> include/trackers/general.php:319
>
> Those need to be fixed as well. The first call does not seem to be
> used on Savane anymore, I guess it is a leftover of the old
> sourceforge days?
No, I dont think so. This was not into sourceforge I think. And it is
used by some project at CERN.
>
> The second call is a bit tougher. The cleanest solution would be to
> rewrite trackers_field_date() to accept a unix timestamp instead of
> a preformatted date, because this is the format which is used all
> over in the database and is our internal date
> representation. However, this is probably too much to do on the
> current branch for the 1.3 release.
I agree.
> > > We seem to agree that $sys_datefmt is an unlucky configuration
> > > option and is not recommended by the Savane development team
> > > because it has several drawbacks. So why keep this forever,
> > > instead of providing good alternatives so that the need for a
> > > custom date format is eliminated?
> >
> > There are no real alternative. We want Savane to be i18n-aware,
> > CERN wants the contrary. When it cost us nothing to satisfies
> > both upstream and CERN, is it not really an option to make one
> > unsatisfied just for the sake of cohesion.
> >
> > $sys_datefmt is an unlucky configuration, that should not be used
> > in most cases. Unless the people running a given installation
> > really want to push hard a specific date format. We must not lock
> > this door. We can just keep it closed by default.
>
> I agree. How about changing the configuration help text to something
> more explicit, then? It currently says:
>
> Date formatting. If you want to use the default locale formating,
> comment out (it's usually a good idea)
>
> Can we change the help text to:
>
> Date formatting. Savane normally does a pretty good job at providing
> a correctly localized date. Unless you really know what you are
> doing, leave this commented out.
That would be good.
> ... and, by the way, the item just before that one seems to be
> wrong:
>
> AskSetting("sys_default_locale", "Default locale", "It must be a
> valid locale name.", "french", $sys_default_locale);
>
> Shouldn't the example value be "german" instead of "french"? No,
> just kidding ;-) I think the example should be fr_FR, no?
That may be right, I don't know actually. I'm not sure.
--
Mathieu Roy
+---------------------------------------------------------------------+
| General Homepage: http://yeupou.coleumes.org/ |
| Computing Homepage: http://alberich.coleumes.org/ |
| Not a native english speaker: |
| http://stock.coleumes.org/doc.php?i=/misc-files/flawed-english |
+---------------------------------------------------------------------+
