This mail is an automated notification from the bugs tracker
of the project: Savane.
/**************************************************************************/
[bugs #851] Latest Modifications:
Changes by:
Sylvain Beucler <[EMAIL PROTECTED]>
'Date:
Wed 10/06/2004 at 08:56 (GMT)
------------------ Additional Follow-up Comments ----------------------------
The user name was something like "Jim Lowe, Jr.", so the use of the comma was
justified IMHO.
Currently I do not have the time to do that task, since I am still working on
the merge with the Savannah changes, but I could do it after if nobody did.
/**************************************************************************/
[bugs #851] Full Item Snapshot:
URL: <http://gna.org/bugs/?func=detailitem&item_id=851>
Project: Savane
Submitted by: Sylvain Beucler
On: Tue 10/05/2004 at 21:12
Category: Backend
Severity: 3 - Average
Priority: C - Normal
Resolution: None
Privacy: Public
Assigned to: None
Status: Open
Release:
Planned Release:
Summary: Commas in Real Name not supported
Original Submission: The code that parses the MySQL query result in DB.pm
joins everything with a ","; hence, when there is a comma in the Real Name of a
user account, things are shifted.
What is pretty unfortunate is that scripts seem to rely on this structure, eg
sv_users.pl splits the result using split(","). As a consequence the SSH keys
are replaced by a part of the Real Name and the account is not updated well.
It seems the GetDB() procedure as well as its calls should be rewritten
thorough Savane so as to return a table instead of a string.
Follow-up Comments
------------------
-------------------------------------------------------
Date: Wed 10/06/2004 at 08:56 By: Sylvain Beucler <beuc>
The user name was something like "Jim Lowe, Jr.", so the use of the comma was
justified IMHO.
Currently I do not have the time to do that task, since I am still working on
the merge with the Savannah changes, but I could do it after if nobody did.
-------------------------------------------------------
Date: Wed 10/06/2004 at 08:45 By: Mathieu Roy <yeupou>
"It seems the GetDB() procedure as well as its calls should be rewritten
thorough Savane so as to return a table instead of a string."
In my opinion, the problem is the fact that an user was able to enter a real
name (or whatever field) with a comma.
I think the account creation process disallow that already. But maybe the
"change name" page does not do the appropriate checks.
"It seems the GetDB() procedure as well as its calls should be rewritten
thorough Savane so as to return a table instead of a string."
That could be something interesting to do. When I wrote GetDB, I just grabbed
the way things were done in sv_cvs, the original backend. The point was to
having more or less the same code reorganized. This step being achieved, we can
perfectly improve it.
And I think that each time GetDB() is called, we transform it into a list with
split(). So if GetDB() returning a list, that would be definitely cleaner and
would avoid this bug.
For detailed info, follow this link:
<http://gna.org/bugs/?func=detailitem&item_id=851>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
