This mail is an automated notification from the bugs tracker
of the project: Savane.
/**************************************************************************/
[bugs #314] Latest Modifications:
Changes by:
Mathieu Roy <[EMAIL PROTECTED]>
'Date:
ven 26.03.2004 à 18:40 (Europe/Paris)
What | Removed | Added
---------------------------------------------------------------------------
Resolution | None | Fixed
Assigned to | None | yeupou
Status | Open | Closed
------------------ Additional Follow-up Comments ----------------------------
Hum, the else should be reached if $notif_scope == global. I do not remember at
all the specifics of that issue, but it does make sense to me to have this
ending else.
However, if I correctly understood what you mean, considering we are in the
global notif scope, we should get the value set to 1 if we are not in
"category" or "both" case.
So in the end, it would looks like :
if ($notif_scope != "global")
{
if ($notif_scope == "category")
{ $notif_value = 0; }
if ($notif_scope == "both")
{ $notif_value = 2; }
else { $notif_value = 1; }
}
else
{ $notif_value = 1; }
Tell me if you think I'm wrong on that.
/**************************************************************************/
[bugs #314] Full Item Snapshot:
URL: <http://gna.org/bugs/?func=detailitem&item_id=314>
Project: Savane
Submitted by: Sylvain Beucler
On: ven 26.03.2004 à 08:15
Category: Web Frontend
Severity: 1 - Trivial
Priority: C - Normal
Resolution: Fixed
Assigned to: yeupou
Status: Closed
Release:
Planned Release: 1.0.2
Summary: global notification settings cancel notification
Original Submission: In www/include/trackers/data.php:
if ($notif_scope != "global") {
if ($notif_scope == "category") {
$notif_value = 0;
}
if ($notif_scope == "both") {
$notif_value = 2;
}
} else {
$notif_value = 1;
}
should be
if ($notif_scope != "global") {
if ($notif_scope == "category") {
$notif_value = 0;
}
if ($notif_scope == "both") {
$notif_value = 2;
}
else {
$notif_value = 1;
}
}
In the first version, the 'else' part is never reached, and causes projects
with global notification settings to have their _glnotif field at 0 in the
database, preventing tracker notification.
It is still not perfect because it does not check whether a notification e-mail
address is set (otherwise it should stay at 0), but at least it works :)
Commentaires :
------------------
-------------------------------------------------------
Date: ven 26.03.2004 à 18:40 By: yeupou
Hum, the else should be reached if $notif_scope == global. I do not remember at
all the specifics of that issue, but it does make sense to me to have this
ending else.
However, if I correctly understood what you mean, considering we are in the
global notif scope, we should get the value set to 1 if we are not in
"category" or "both" case.
So in the end, it would looks like :
if ($notif_scope != "global")
{
if ($notif_scope == "category")
{ $notif_value = 0; }
if ($notif_scope == "both")
{ $notif_value = 2; }
else { $notif_value = 1; }
}
else
{ $notif_value = 1; }
Tell me if you think I'm wrong on that.
-------------------------------------------------------
Date: ven 26.03.2004 à 08:19 By: beuc
Sorry, I meant:
if ($notif_scope != "global") {
if ($notif_scope == "category") {
$notif_value = 0;
}
elseif ($notif_scope == "both") {
$notif_value = 2;
}
else {
$notif_value = 1;
}
}
CC List
-------
CC Address | Comment
------------------------------------+-----------------------------
ype | usually works on the notification stuff
For detailed info, follow this link:
<http://gna.org/bugs/?func=detailitem&item_id=314>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
