Lorenzo Hernandez Garcia-Hierro <[EMAIL PROTECTED]> tapota :
> 1. (*) text/plain ( ) text/html
>
> Commit from lorenzo (2004-03-28 22:26 CEST)
> -------------------
>
> Added /inc , img.php and other files description.
>
> savane frontend/php/security/SECURITY-NOTES 1.2
Hello Lorenzo,
PHP Includes are all in frontend/php/includes, and I think any libs
should definitely go there, whatever his purpose (why not?).
So I moved
security/security-lib.php -> include/security.php
security/SECURITY-NOTES,v -> ../../doc/devel/
security/security/img.php -> include/security-img.php
More generally, since you are new in the team, it would be best that
you mention to the list that you want to add new files first.
Also, you must name the functions you wrote like there are all named,
It means that _fwk_filter_encrypt() must be renamed to
security_filter_encrypt()
(I skipped the fkw, I dont get its meaning), the first part must
always be the name of the include file that provides the function.
These two things permits any developer to find a function in a short
time, so it is very important to follow them.
Apart from that, on files you create yourself, like security-img.php,
you should remove copyright line like:
# Copyright 1999-2000 (c) The SourceForge Crew
#
# Copyright 2002-2004 (c) Mathieu Roy <yeupou--at--gnu.org>
Note that if you want to implement major improvements, it should not
be on the trunk, that is not supposed to be broken in any way, but on
branches. On the trunk, only minor improvements and bugfixes are ok.
Thanks,
Regards,
--
Mathieu Roy
+---------------------------------------------------------------------+
| General Homepage: http://yeupou.coleumes.org/ |
| Computing Homepage: http://alberich.coleumes.org/ |
| Not a native english speaker: |
| http://stock.coleumes.org/doc.php?i=/misc-files/flawed-english |
+---------------------------------------------------------------------+
