Hi, First, thanks for the changes :)
Can you explain a bit more the work in frontend/php/include/i18n.php? Is it necessary to have all this boilerplate? Is it because this is a web-based application? Is there a way to make it as simple as a C gettext project? Of course the previous code was no better but I hope this could eventually be pretty much stripped down / removed :) -- Sylvain On Thu, Aug 10, 2006 at 02:44:46PM +0300, Sergey Poznyakoff wrote: > Hello, > > The attached patch addresses several localization-related issues I > found while running Savane on puszcza.gnu.org.ua and preparing Ukrainian > and Polish localizations for it (I'll submit the localizations in a > separate message). It also fixes some other minor inconsistensies/bugs. > > The detailed ChangeLog entry follows. > > Regards, > Sergey > > > 2006-08-10 Sergey Poznyakoff <[EMAIL PROTECTED]> > > * configure: Support for Slackware installations > * frontend/php/include/exit.php: Bugfix - use 'uri=' instead of > 'return_to=' > > * frontend/php/include/i18n.php: Provide a table of default > territory codes for all ISO 639 languages (language code => ISO > 3166 country code mapping). Automatically determine if the > requested translation is available. This removes the need to > modify i18n.php after adding new translations, it suffices to drop > the corresponding .mo files into the locale directory instead. > (ngettext): Add plural rules for Polish and Ukrainian. > > * frontend/php/include/calendar.php (every_calendar_day_name): New > function. It is incorrect to use 'every %s', where %s is a day > name, since in many languages adjective 'every' must concord with > the day name. > * frontend/php/include/search/general.php: Fix typos in messages. > * frontend/php/include/trackers/data.php: Do not pass > $tracker_name verbatim to translated strings - this looks awkward > and hurts readability in localized versions. Use artifact_name() > to obtain a localized string. > Fix typos in message ids. > * frontend/php/include/trackers_run/admin/editqueryforms.php: Add > missing _() markers > * frontend/php/include/trackers_run/admin/field_values.php: Fix > typos in messages. > * frontend/php/include/trackers_run/browse.php: Add a I18N > comment, helping translators to find appropriate translation, as > ngettext cannot be used here. > * frontend/php/news/index.php: Likewise > * frontend/php/include/trackers_run/export.php: Use artifact_name > instead of switch block. > Use every_calendar_day_name() instead of translating 'every %s' > (see commit message for frontend/php/include/calendar.php) > Fix comments appropriately > * frontend/php/include/trackers_run/index.php: Fix typos in messages. > * frontend/php/include/trackers_run/mod.php: Fix typos in > messages. > * frontend/php/include/utils.php (artifact_name): New function. > * frontend/php/include/vars.php: Use utils_get_content() to read > in hashes.txt. This allows to get localized versions of > $DEVEL_STATUS and (if necessary) $LICENSE_URL. > Notice that it implies the need to add `global $LICENSE, > $LICENSE_URL, $DEVEL_STATUS;' to hashes.txt (hashes.$lang.UTF-8) > * frontend/php/index.php: Add missing _() markers. > Use $project->getTypeMailingListFormat to obtain system name for > the list, so that the configuration settings are honored > * frontend/php/mail/index.php: Fix typos in messages. Add missing > _() markers. > * frontend/php/my/admin/editsshkeys.php: Reword the introductory > paragraph for the authorized keys > * frontend/php/my/admin/index.php: Fix typos in messages. > * frontend/php/my/groups.php: Fix typos in messages. > * frontend/php/news/approve.php: Use mysql_real_escape_string to > protect from SQL injection > * frontend/php/news/submit.php: Likewise > * frontend/php/project/admin/editgroupinfo.php: Likewise _______________________________________________ Savane-dev mailing list [email protected] https://mail.gna.org/listinfo/savane-dev
